618 lines
29 KiB
Markdown
618 lines
29 KiB
Markdown
---
|
|
description: Learn how to contribute to GitLab Documentation.
|
|
---
|
|
|
|
# GitLab Documentation guidelines
|
|
|
|
GitLab's documentation is [intended as the single source of truth (SSOT)](https://about.gitlab.com/handbook/documentation/) for information about how to configure, use, and troubleshoot GitLab. The documentation contains use cases and usage instructions for every GitLab feature, organized by product area and subject. This includes topics and workflows that span multiple GitLab features, and the use of GitLab with other applications.
|
|
|
|
In addition to this page, the following resources can help you craft and contribute to documentation:
|
|
|
|
- [Style Guide](styleguide.md) - What belongs in the docs, language guidelines, Markdown standards to follow, links, and more.
|
|
- [Structure and template](structure.md) - Learn the typical parts of a doc page and how to write each one.
|
|
- [Documentation process](workflow.md).
|
|
- [Markdown Guide](../../user/markdown.md) - A reference for all Markdown syntax supported by GitLab.
|
|
- [Site architecture](site_architecture/index.md) - How <https://docs.gitlab.com> is built.
|
|
- [Documentation for feature flags](feature_flags.md) - How to write and update documentation for GitLab features deployed behind feature flags.
|
|
|
|
## Source files and rendered web locations
|
|
|
|
Documentation for GitLab, GitLab Runner, Omnibus GitLab, and Charts is published to <https://docs.gitlab.com>. Documentation for GitLab is also published within the application at `/help` on the domain of the GitLab instance.
|
|
At `/help`, only help for your current edition and version is included. Help for other versions is available at <https://docs.gitlab.com/archives/>.
|
|
|
|
The source of the documentation exists within the codebase of each GitLab application in the following repository locations:
|
|
|
|
| Project | Path |
|
|
| --- | --- |
|
|
| [GitLab](https://gitlab.com/gitlab-org/gitlab/) | [`/doc`](https://gitlab.com/gitlab-org/gitlab/tree/master/doc) |
|
|
| [GitLab Runner](https://gitlab.com/gitlab-org/gitlab-runner/) | [`/docs`](https://gitlab.com/gitlab-org/gitlab-runner/tree/master/docs) |
|
|
| [Omnibus GitLab](https://gitlab.com/gitlab-org/omnibus-gitlab/) | [`/doc`](https://gitlab.com/gitlab-org/gitlab/tree/master/doc) |
|
|
| [Charts](https://gitlab.com/gitlab-org/charts/gitlab) | [`/doc`](https://gitlab.com/gitlab-org/charts/gitlab/tree/master/doc) |
|
|
|
|
Documentation issues and merge requests are part of their respective repositories and all have the label `Documentation`.
|
|
|
|
### Branch naming
|
|
|
|
The [CI pipeline for the main GitLab project](../pipelines.md) is configured to automatically
|
|
run only the jobs that match the type of contribution. If your contribution contains
|
|
**only** documentation changes, then only documentation-related jobs will be run, and
|
|
the pipeline will complete much faster than a code contribution.
|
|
|
|
If you are submitting documentation-only changes to Runner, Omnibus, or Charts,
|
|
the fast pipeline is not determined automatically. Instead, create branches for
|
|
docs-only merge requests using the following guide:
|
|
|
|
| Branch name | Valid example |
|
|
|:----------------------|:-----------------------------|
|
|
| Starting with `docs/` | `docs/update-api-issues` |
|
|
| Starting with `docs-` | `docs-update-api-issues` |
|
|
| Ending in `-docs` | `123-update-api-issues-docs` |
|
|
|
|
## Contributing to docs
|
|
|
|
[Contributions to GitLab docs](workflow.md) are welcome from the entire GitLab community.
|
|
|
|
To ensure that GitLab docs are current, there are special processes and responsibilities for all [feature changes](feature-change-workflow.md), that is development work that impacts the appearance, usage, or administration of a feature.
|
|
|
|
However, anyone can contribute [documentation improvements](improvement-workflow.md) that are not associated with a feature change. For example, adding a new doc on how to accomplish a use case that's already possible with GitLab or with third-party tools and GitLab.
|
|
|
|
## Markdown and styles
|
|
|
|
[GitLab docs](https://gitlab.com/gitlab-org/gitlab-docs) uses [GitLab Kramdown](https://gitlab.com/gitlab-org/gitlab_kramdown)
|
|
as its Markdown rendering engine. See the [GitLab Markdown Guide](https://about.gitlab.com/handbook/markdown-guide/) for a complete Kramdown reference.
|
|
|
|
Adhere to the [Documentation Style Guide](styleguide.md). If a style standard is missing, you are welcome to suggest one via a merge request.
|
|
|
|
## Folder structure and files
|
|
|
|
See the [Structure](styleguide.md#structure) section of the [Documentation Style Guide](styleguide.md).
|
|
|
|
## Metadata
|
|
|
|
To provide additional directives or useful information, we add metadata in YAML
|
|
format to the beginning of each product documentation page.
|
|
|
|
For example, the following metadata would be at the beginning of a product
|
|
documentation page whose content is primarily associated with the Audit Events
|
|
feature:
|
|
|
|
```yaml
|
|
---
|
|
stage: Monitor
|
|
group: APM
|
|
info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers
|
|
---
|
|
```
|
|
|
|
The following list describes the YAML parameters in use:
|
|
|
|
- `redirect_to`: The relative path and filename (with an `.md` extension) of the
|
|
location to which visitors should be redirected for a moved page.
|
|
[Learn more](#changing-document-location).
|
|
- `stage`: The [Stage](https://about.gitlab.com/handbook/product/categories/#devops-stages)
|
|
to which the majority of the page's content belongs.
|
|
- `group`: The [Group](https://about.gitlab.com/company/team/structure/#product-groups)
|
|
to which the majority of the page's content belongs.
|
|
- `info`: The following line, which provides direction to contributors regarding
|
|
how to contact the Technical Writer associated with the page's Stage and
|
|
Group: `To determine the technical writer assigned to the Stage/Group
|
|
associated with this page, see
|
|
https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers`
|
|
- `disqus_identifier`: Identifier for Disqus commenting system. Used to keep
|
|
comments with a page that's been moved to a new URL.
|
|
[Learn more](#redirections-for-pages-with-disqus-comments).
|
|
|
|
## Changing document location
|
|
|
|
Changing a document's location requires specific steps to ensure that
|
|
users can seamlessly access the new doc page, whether they are accessing content
|
|
on a GitLab instance domain at `/help` or at <https://docs.gitlab.com>. Be sure to assign a
|
|
technical writer if you have any questions during the process (such as
|
|
whether the move is necessary), and ensure that a technical writer reviews this
|
|
change prior to merging.
|
|
|
|
If you indeed need to change a document's location, do not remove the old
|
|
document, but instead replace all of its content with the following:
|
|
|
|
```markdown
|
|
---
|
|
redirect_to: '../path/to/file/index.md'
|
|
---
|
|
|
|
This document was moved to [another location](../path/to/file/index.md).
|
|
```
|
|
|
|
Where `../path/to/file/index.md` is usually the relative path to the old document.
|
|
|
|
The `redirect_to` variable supports both full and relative URLs, for example
|
|
`https://docs.gitlab.com/ee/path/to/file.html`, `../path/to/file.html`, `path/to/file.md`.
|
|
It ensures that the redirect will work for <https://docs.gitlab.com> and any `*.md` paths
|
|
will be compiled to `*.html`.
|
|
The new line underneath the front matter informs the user that the document
|
|
changed location and is useful for someone that browses that file from the repository.
|
|
|
|
For example, if you move `doc/workflow/lfs/index.md` to
|
|
`doc/administration/lfs.md`, then the steps would be:
|
|
|
|
1. Copy `doc/workflow/lfs/index.md` to `doc/administration/lfs.md`
|
|
1. Replace the contents of `doc/workflow/lfs/index.md` with:
|
|
|
|
```markdown
|
|
---
|
|
redirect_to: '../../administration/lfs.md'
|
|
---
|
|
|
|
This document was moved to [another location](../../administration/lfs.md).
|
|
```
|
|
|
|
1. Find and replace any occurrences of the old location with the new one.
|
|
A quick way to find them is to use `git grep` on the repository you changed
|
|
the file from:
|
|
|
|
```shell
|
|
git grep -n "workflow/lfs/lfs_administration"
|
|
git grep -n "lfs/lfs_administration"
|
|
```
|
|
|
|
NOTE: **Note:**
|
|
If the document being moved has any Disqus comments on it, there are extra steps
|
|
to follow documented just [below](#redirections-for-pages-with-disqus-comments).
|
|
|
|
Things to note:
|
|
|
|
- Since we also use inline documentation, except for the documentation itself,
|
|
the document might also be referenced in the views of GitLab (`app/`) which will
|
|
render when visiting `/help`, and sometimes in the testing suite (`spec/`).
|
|
You must search these paths for references to the doc and update them as well.
|
|
- The above `git grep` command will search recursively in the directory you run
|
|
it in for `workflow/lfs/lfs_administration` and `lfs/lfs_administration`
|
|
and will print the file and the line where this file is mentioned.
|
|
You may ask why the two greps. Since [we use relative paths to link to
|
|
documentation](styleguide.md#links), sometimes it might be useful to search a path deeper.
|
|
- The `*.md` extension is not used when a document is linked to GitLab's
|
|
built-in help page, which is why we omit it in `git grep`.
|
|
- Use the checklist on the "Change documentation location" MR description template.
|
|
|
|
### Redirections for pages with Disqus comments
|
|
|
|
If the documentation page being relocated already has Disqus comments,
|
|
we need to preserve the Disqus thread.
|
|
|
|
Disqus uses an identifier per page, and for <https://docs.gitlab.com>, the page identifier
|
|
is configured to be the page URL. Therefore, when we change the document location,
|
|
we need to preserve the old URL as the same Disqus identifier.
|
|
|
|
To do that, add to the front matter the variable `disqus_identifier`,
|
|
using the old URL as value. For example, let's say we moved the document
|
|
available under `https://docs.gitlab.com/my-old-location/README.html` to a new location,
|
|
`https://docs.gitlab.com/my-new-location/index.html`.
|
|
|
|
Into the **new document** front matter, we add the following:
|
|
|
|
```yaml
|
|
---
|
|
disqus_identifier: 'https://docs.gitlab.com/my-old-location/README.html'
|
|
---
|
|
```
|
|
|
|
Note: it is necessary to include the file name in the `disqus_identifier` URL,
|
|
even if it's `index.html` or `README.html`.
|
|
|
|
## Merge requests for GitLab documentation
|
|
|
|
Before getting started, make sure you read the introductory section
|
|
"[contributing to docs](#contributing-to-docs)" above and the
|
|
[documentation workflow](workflow.md).
|
|
|
|
- Use the current [merge request description template](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/merge_request_templates/Documentation.md)
|
|
- Label the MR `Documentation` (can only be done by people with `developer` access, for example, GitLab team members)
|
|
- Assign the correct milestone per note below (can only be done by people with `developer` access, for example, GitLab team members)
|
|
|
|
Documentation will be merged if it is an improvement on existing content,
|
|
represents a good-faith effort to follow the template and style standards,
|
|
and is believed to be accurate.
|
|
|
|
Further needs for what would make the doc even better should be immediately addressed
|
|
in a follow-up MR or issue.
|
|
|
|
NOTE: **Note:**
|
|
If the release version you want to add the documentation to has already been
|
|
frozen or released, use the label `~"Pick into X.Y"` to get it merged into
|
|
the correct release. Avoid picking into a past release as much as you can, as
|
|
it increases the work of the release managers.
|
|
|
|
## GitLab `/help`
|
|
|
|
Every GitLab instance includes the documentation, which is available at `/help`
|
|
(`https://gitlab.example.com/help`). For example, <https://gitlab.com/help>.
|
|
|
|
There are [plans](https://gitlab.com/groups/gitlab-org/-/epics/693) to end this
|
|
practice and instead link out from the GitLab application to <https://docs.gitlab.com> URLs.
|
|
|
|
The documentation available online on <https://docs.gitlab.com> is deployed every four hours from the `master` branch of GitLab, Omnibus, and Runner. Therefore,
|
|
after a merge request gets merged, it will be available online on the same day.
|
|
However, it will be shipped (and available on `/help`) within the milestone assigned
|
|
to the MR.
|
|
|
|
For example, let's say your merge request has a milestone set to 11.3, which
|
|
will be released on 2018-09-22. If it gets merged on 2018-09-15, it will be
|
|
available online on 2018-09-15, but, as the feature freeze date has passed, if
|
|
the MR does not have a `~"Pick into 11.3"` label, the milestone has to be changed
|
|
to 11.4 and it will be shipped with all GitLab packages only on 2018-10-22,
|
|
with GitLab 11.4. Meaning, it will only be available under `/help` from GitLab
|
|
11.4 onward, but available on <https://docs.gitlab.com/> on the same day it was merged.
|
|
|
|
### Linking to `/help`
|
|
|
|
When you're building a new feature, you may need to link the documentation
|
|
from GitLab, the application. This is normally done in files inside the
|
|
`app/views/` directory with the help of the `help_page_path` helper method.
|
|
|
|
In its simplest form, the HAML code to generate a link to the `/help` page is:
|
|
|
|
```haml
|
|
= link_to 'Help page', help_page_path('user/permissions')
|
|
```
|
|
|
|
The `help_page_path` contains the path to the document you want to link to with
|
|
the following conventions:
|
|
|
|
- it is relative to the `doc/` directory in the GitLab repository
|
|
- the `.md` extension must be omitted
|
|
- it must not end with a slash (`/`)
|
|
|
|
Below are some special cases where should be used depending on the context.
|
|
You can combine one or more of the following:
|
|
|
|
1. **Linking to an anchor link.** Use `anchor` as part of the `help_page_path`
|
|
method:
|
|
|
|
```haml
|
|
= link_to 'Help page', help_page_path('user/permissions', anchor: 'anchor-link')
|
|
```
|
|
|
|
1. **Opening links in a new tab.** This should be the default behavior:
|
|
|
|
```haml
|
|
= link_to 'Help page', help_page_path('user/permissions'), target: '_blank'
|
|
```
|
|
|
|
1. **Linking to a circle icon.** Usually used in settings where a long
|
|
description cannot be used, like near checkboxes. You can basically use
|
|
any font awesome icon, but prefer the `question-circle`:
|
|
|
|
```haml
|
|
= link_to icon('question-circle'), help_page_path('user/permissions')
|
|
```
|
|
|
|
1. **Using a button link.** Useful in places where text would be out of context
|
|
with the rest of the page layout:
|
|
|
|
```haml
|
|
= link_to 'Help page', help_page_path('user/permissions'), class: 'btn btn-info'
|
|
```
|
|
|
|
1. **Using links inline of some text.**
|
|
|
|
```haml
|
|
Description to #{link_to 'Help page', help_page_path('user/permissions')}.
|
|
```
|
|
|
|
1. **Adding a period at the end of the sentence.** Useful when you don't want
|
|
the period to be part of the link:
|
|
|
|
```haml
|
|
= succeed '.' do
|
|
Learn more in the
|
|
= link_to 'Help page', help_page_path('user/permissions')
|
|
```
|
|
|
|
### GitLab `/help` tests
|
|
|
|
Several [RSpec tests](https://gitlab.com/gitlab-org/gitlab/blob/master/spec/features/help_pages_spec.rb)
|
|
are run to ensure GitLab documentation renders and works correctly. In particular, that [main docs landing page](../../README.md) will work correctly from `/help`.
|
|
For example, [GitLab.com's `/help`](https://gitlab.com/help).
|
|
|
|
## Docs site architecture
|
|
|
|
See the [Docs site architecture](site_architecture/index.md) page to learn
|
|
how we build and deploy the site at <https://docs.gitlab.com> and
|
|
to review all the assets and libraries in use.
|
|
|
|
### Global navigation
|
|
|
|
See the [Global navigation](site_architecture/global_nav.md) doc for information
|
|
on how the left-side navigation menu is built and updated.
|
|
|
|
## Previewing the changes live
|
|
|
|
NOTE: **Note:**
|
|
To preview your changes to documentation locally, follow this
|
|
[development guide](https://gitlab.com/gitlab-org/gitlab-docs/blob/master/README.md#development-when-contributing-to-gitlab-documentation) or [these instructions for GDK](https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/howto/gitlab_docs.md).
|
|
|
|
The live preview is currently enabled for the following projects:
|
|
|
|
- [`gitlab`](https://gitlab.com/gitlab-org/gitlab)
|
|
- [`gitlab-runner`](https://gitlab.com/gitlab-org/gitlab-runner)
|
|
|
|
If your merge request has docs changes, you can use the manual `review-docs-deploy` job
|
|
to deploy the docs review app for your merge request.
|
|
You will need at least Maintainer permissions to be able to run it.
|
|
|
|
![Manual trigger a docs build](img/manual_build_docs.png)
|
|
|
|
NOTE: **Note:**
|
|
You will need to push a branch to those repositories, it doesn't work for forks.
|
|
|
|
The `review-docs-deploy*` job will:
|
|
|
|
1. Create a new branch in the [`gitlab-docs`](https://gitlab.com/gitlab-org/gitlab-docs)
|
|
project named after the scheme: `docs-preview-$DOCS_GITLAB_REPO_SUFFIX-$CI_MERGE_REQUEST_IID`,
|
|
where `DOCS_GITLAB_REPO_SUFFIX` is the suffix for each product, e.g, `ee` for
|
|
EE, `omnibus` for Omnibus GitLab, etc, and `CI_MERGE_REQUEST_IID` is the ID
|
|
of the respective merge request.
|
|
1. Trigger a cross project pipeline and build the docs site with your changes.
|
|
|
|
In case the review app URL returns 404, this means that either the site is not
|
|
yet deployed, or something went wrong with the remote pipeline. Give it a few
|
|
minutes and it should appear online, otherwise you can check the status of the
|
|
remote pipeline from the link in the merge request's job output.
|
|
If the pipeline failed or got stuck, drop a line in the `#docs` chat channel.
|
|
|
|
TIP: **Tip:**
|
|
Someone with no merge rights to the GitLab projects (think of forks from
|
|
contributors) cannot run the manual job. In that case, you can
|
|
ask someone from the GitLab team who has the permissions to do that for you.
|
|
|
|
NOTE: **Note:**
|
|
Make sure that you always delete the branch of the merge request you were
|
|
working on. If you don't, the remote docs branch won't be removed either,
|
|
and the server where the Review Apps are hosted will eventually be out of
|
|
disk space.
|
|
|
|
### Troubleshooting review apps
|
|
|
|
In case the review app URL returns 404, follow these steps to debug:
|
|
|
|
1. **Did you follow the URL from the merge request widget?** If yes, then check if
|
|
the link is the same as the one in the job output.
|
|
1. **Did you follow the URL from the job output?** If yes, then it means that
|
|
either the site is not yet deployed or something went wrong with the remote
|
|
pipeline. Give it a few minutes and it should appear online, otherwise you
|
|
can check the status of the remote pipeline from the link in the job output.
|
|
If the pipeline failed or got stuck, drop a line in the `#docs` chat channel.
|
|
|
|
### Technical aspects
|
|
|
|
If you want to know the in-depth details, here's what's really happening:
|
|
|
|
1. You manually run the `review-docs-deploy` job in a merge request.
|
|
1. The job runs the [`scripts/trigger-build-docs`](https://gitlab.com/gitlab-org/gitlab/blob/master/scripts/trigger-build-docs)
|
|
script with the `deploy` flag, which in turn:
|
|
1. Takes your branch name and applies the following:
|
|
- The `docs-preview-` prefix is added.
|
|
- The product slug is used to know the project the review app originated
|
|
from.
|
|
- The number of the merge request is added so that you can know by the
|
|
`gitlab-docs` branch name the merge request it originated from.
|
|
1. The remote branch is then created if it doesn't exist (meaning you can
|
|
re-run the manual job as many times as you want and this step will be skipped).
|
|
1. A new cross-project pipeline is triggered in the docs project.
|
|
1. The preview URL is shown both at the job output and in the merge request
|
|
widget. You also get the link to the remote pipeline.
|
|
1. In the docs project, the pipeline is created and it
|
|
[skips the test jobs](https://gitlab.com/gitlab-org/gitlab-docs/blob/8d5d5c750c602a835614b02f9db42ead1c4b2f5e/.gitlab-ci.yml#L50-55)
|
|
to lower the build time.
|
|
1. Once the docs site is built, the HTML files are uploaded as artifacts.
|
|
1. A specific Runner tied only to the docs project, runs the Review App job
|
|
that downloads the artifacts and uses `rsync` to transfer the files over
|
|
to a location where NGINX serves them.
|
|
|
|
The following GitLab features are used among others:
|
|
|
|
- [Manual actions](../../ci/yaml/README.md#whenmanual)
|
|
- [Multi project pipelines](../../ci/multi_project_pipeline_graphs.md)
|
|
- [Review Apps](../../ci/review_apps/index.md)
|
|
- [Artifacts](../../ci/yaml/README.md#artifacts)
|
|
- [Specific Runner](../../ci/runners/README.md#prevent-a-specific-runner-from-being-enabled-for-other-projects)
|
|
- [Pipelines for merge requests](../../ci/merge_request_pipelines/index.md)
|
|
|
|
## Testing
|
|
|
|
We treat documentation as code, and so use tests in our CI pipeline to maintain the
|
|
standards and quality of the docs. The current tests, which run in CI jobs when a
|
|
merge request with new or changed docs is submitted, are:
|
|
|
|
- [`docs lint`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L48):
|
|
Runs several tests on the content of the docs themselves:
|
|
- [`lint-doc.sh` script](https://gitlab.com/gitlab-org/gitlab/blob/master/scripts/lint-doc.sh)
|
|
runs the following checks and linters:
|
|
- All cURL examples use the long flags (ex: `--header`, not `-H`).
|
|
- The `CHANGELOG.md` does not contain duplicate versions.
|
|
- No files in `doc/` are executable.
|
|
- No new `README.md` was added.
|
|
- [markdownlint](#markdownlint).
|
|
- [Vale](#vale).
|
|
- Nanoc tests:
|
|
- [`internal_links`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L67)
|
|
checks that all internal links (ex: `[link](../index.md)`) are valid.
|
|
- [`internal_anchors`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L69)
|
|
checks that all internal anchors (ex: `[link](../index.md#internal_anchor)`)
|
|
are valid.
|
|
|
|
### Running tests
|
|
|
|
Apart from [previewing your changes locally](#previewing-the-changes-live), you can also run all lint checks
|
|
and Nanoc tests locally.
|
|
|
|
#### Nanoc tests
|
|
|
|
To execute Nanoc tests locally:
|
|
|
|
1. Navigate to the [`gitlab-docs`](https://gitlab.com/gitlab-org/gitlab-docs) directory.
|
|
1. Run:
|
|
|
|
```shell
|
|
# Check for broken internal links
|
|
bundle exec nanoc check internal_links
|
|
|
|
# Check for broken external links (might take a lot of time to complete).
|
|
# This test is set to be allowed to fail and is run only in the gitlab-docs project CI
|
|
bundle exec nanoc check internal_anchors
|
|
```
|
|
|
|
#### Lint checks
|
|
|
|
Lint checks are performed by the [`lint-doc.sh`](https://gitlab.com/gitlab-org/gitlab/blob/master/scripts/lint-doc.sh)
|
|
script and can be executed as follows:
|
|
|
|
1. Navigate to the `gitlab` directory.
|
|
1. Run:
|
|
|
|
```shell
|
|
MD_DOC_PATH=path/to/my_doc.md scripts/lint-doc.sh
|
|
```
|
|
|
|
Where `MD_DOC_PATH` points to the file or directory you would like to run lint checks for.
|
|
If you omit it completely, it will default to the `doc/` directory.
|
|
The output should be similar to:
|
|
|
|
```plaintext
|
|
=> Linting documents at path /path/to/gitlab as <user>...
|
|
=> Checking for cURL short options...
|
|
=> Checking for CHANGELOG.md duplicate entries...
|
|
=> Checking /path/to/gitlab/doc for executable permissions...
|
|
=> Checking for new README.md files...
|
|
=> Linting markdown style...
|
|
=> Linting prose...
|
|
✔ 0 errors, 0 warnings and 0 suggestions in 1 file.
|
|
✔ Linting passed
|
|
```
|
|
|
|
Note that this requires you to either have the required lint tools installed on your machine,
|
|
or a working Docker installation, in which case an image with these tools pre-installed will be used.
|
|
|
|
### Local linting
|
|
|
|
To help adhere to the [documentation style guidelines](styleguide.md), and improve the content
|
|
added to documentation, consider locally installing and running documentation linters. This will
|
|
help you catch common issues before raising merge requests for review of documentation.
|
|
|
|
Running the following locally allows you to match the checks in the build pipeline:
|
|
|
|
- [markdownlint](#markdownlint).
|
|
- [Vale](#vale).
|
|
|
|
NOTE: **Note:**
|
|
This list does not limit what other linters you can add to your local documentation writing toolchain.
|
|
|
|
#### markdownlint
|
|
|
|
[markdownlint](https://github.com/DavidAnson/markdownlint) checks that Markdown
|
|
syntax follows [certain rules](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#rules),
|
|
and is used by the [`docs-lint` test](#testing) with a [configuration file](#markdownlint-configuration).
|
|
Our [Documentation Style Guide](styleguide.md#markdown) and [Markdown Guide](https://about.gitlab.com/handbook/markdown-guide/)
|
|
elaborate on which choices must be made when selecting Markdown syntax for GitLab
|
|
documentation. This tool helps catch deviations from those guidelines.
|
|
|
|
markdownlint can be used [on the command line](https://github.com/igorshubovych/markdownlint-cli#markdownlint-cli--),
|
|
either on a single Markdown file or on all Markdown files in a project. For example, to run
|
|
markdownlint on all documentation in the [`gitlab` project](https://gitlab.com/gitlab-org/gitlab),
|
|
run the following commands from within your `gitlab` project root directory, which will
|
|
automatically detect the [`.markdownlint.json`](#markdownlint-configuration) configuration
|
|
file in the root of the project, and test all files in `/doc` and its subdirectories:
|
|
|
|
```shell
|
|
markdownlint 'doc/**/*.md'
|
|
```
|
|
|
|
If you wish to use a different configuration file, use the `-c` flag:
|
|
|
|
```shell
|
|
markdownlint -c <config-file-name> 'doc/**/*.md'
|
|
```
|
|
|
|
##### Run markdownlint in an editor
|
|
|
|
markdownlint can also be run as a linter within text editors using [plugins/extensions](https://github.com/DavidAnson/markdownlint#related),
|
|
such as:
|
|
|
|
- [Sublime Text](https://packagecontrol.io/packages/SublimeLinter-contrib-markdownlint)
|
|
- [Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint)
|
|
- [Atom](https://atom.io/packages/linter-node-markdownlint)
|
|
|
|
It is best to use the [same configuration file](#markdownlint-configuration) as what
|
|
is in use in the four repositories that are the sources for <https://docs.gitlab.com>. Each
|
|
plugin/extension has different requirements regarding the configuration file, which
|
|
is explained in each editor's docs.
|
|
|
|
##### markdownlint configuration
|
|
|
|
Each formatting issue that markdownlint checks has an associated
|
|
[rule](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#rules).
|
|
These rules are configured in the `.markdownlint.json` files located in the root of
|
|
four repositories that are the sources for <https://docs.gitlab.com>:
|
|
|
|
- [`gitlab`](https://gitlab.com/gitlab-org/gitlab/blob/master/.markdownlint.json)
|
|
- [`gitlab-runner`](https://gitlab.com/gitlab-org/gitlab-runner/blob/master/.markdownlint.json)
|
|
- [`omnibus-gitlab`](https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/.markdownlint.json)
|
|
- [`charts`](https://gitlab.com/charts/gitlab/blob/master/.markdownlint.json)
|
|
|
|
By default all rules are enabled, so the configuration file is used to disable unwanted
|
|
rules, and also to configure optional parameters for enabled rules as needed. You can
|
|
also check [the issue](https://gitlab.com/gitlab-org/gitlab-foss/-/issues/64352) that
|
|
tracked the changes required to implement these rules, and details which rules were
|
|
on or off when markdownlint was enabled on the docs.
|
|
|
|
#### Vale
|
|
|
|
[Vale](https://errata-ai.gitbook.io/vale/) is a grammar, style, and word usage linter
|
|
for the English language. Vale's configuration is stored in the
|
|
[`.vale.ini`](https://gitlab.com/gitlab-org/gitlab/blob/master/.vale.ini) file
|
|
located in the root directory of the [GitLab repository](https://gitlab.com/gitlab-org/gitlab).
|
|
|
|
Vale supports creating [custom tests](https://errata-ai.github.io/vale/styles/),
|
|
stored in the `doc/.linting/vale/styles/gitlab` directory, that extend any of
|
|
several types of checks.
|
|
|
|
To view linting suggestions locally, you must install Vale on your own machine,
|
|
and from GitLab's root directory (where `.vale.ini` is located), run:
|
|
|
|
```shell
|
|
vale --glob='*.{md}' doc
|
|
```
|
|
|
|
Vale's error-level test results [are displayed](#testing) in CI pipelines.
|
|
|
|
##### Run Vale in an editor
|
|
|
|
You can run Vale as a linter within your text editor of choice, with:
|
|
|
|
- The Sublime Text [`SublimeLinter-contrib-vale` plugin](https://packagecontrol.io/packages/SublimeLinter-contrib-vale)
|
|
- The Visual Studio Code [`testthedocs.vale` extension](https://marketplace.visualstudio.com/items?itemName=testthedocs.vale)
|
|
|
|
We don't use [Vale Server](https://errata-ai.github.io/vale/#using-vale-with-a-text-editor-or-another-third-party-application).
|
|
|
|
##### Disable a Vale test
|
|
|
|
You can disable a specific Vale linting rule or all Vale linting rules for any portion of a document:
|
|
|
|
- To disable a specific rule, add a `<!-- vale gitlab.rulename = NO -->` tag
|
|
before the text, and a `<!-- vale gitlab.rulename = YES -->` tag after the text,
|
|
replacing `rulename` with the filename of a test in the [GitLab styles](https://gitlab.com/gitlab-org/gitlab/-/tree/master/doc/.linting/vale/styles/gitlab) directory.
|
|
- To disable all Vale linting rules, add a `<!-- vale off -->` tag before the text,
|
|
and a `<!-- vale on -->` tag after the text.
|
|
|
|
Whenever possible, exclude only the problematic rule and line(s).
|
|
In some cases, such as list items, you may need to disable linting for the entire
|
|
list until ["Ignore comments are not honored in a Markdown file"](https://github.com/errata-ai/vale/issues/175) is resolved.
|
|
|
|
For more information, see [Vale's documentation](https://errata-ai.gitbook.io/vale/getting-started/markup#markup-based-configuration).
|
|
|
|
## Danger Bot
|
|
|
|
GitLab uses [Danger](https://github.com/danger/danger) for some elements in
|
|
code review. For docs changes in merge requests, whenever a change to files under `/doc`
|
|
is made, Danger Bot leaves a comment with further instructions about the documentation
|
|
process. This is configured in the `Dangerfile` in the GitLab repository under
|
|
[/danger/documentation/](https://gitlab.com/gitlab-org/gitlab/tree/master/danger/documentation).
|