debian-mirror-gitlab/doc/development/documentation/index.md

619 lines
29 KiB
Markdown
Raw Normal View History

2018-11-08 19:23:39 +05:30
---
description: Learn how to contribute to GitLab Documentation.
---
# GitLab Documentation guidelines
2019-12-04 20:38:33 +05:30
GitLab's documentation is [intended as the single source of truth (SSOT)](https://about.gitlab.com/handbook/documentation/) for information about how to configure, use, and troubleshoot GitLab. The documentation contains use cases and usage instructions for every GitLab feature, organized by product area and subject. This includes topics and workflows that span multiple GitLab features, and the use of GitLab with other applications.
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
In addition to this page, the following resources can help you craft and contribute to documentation:
2019-02-15 15:39:39 +05:30
2020-04-08 14:13:33 +05:30
- [Style Guide](styleguide.md) - What belongs in the docs, language guidelines, Markdown standards to follow, links, and more.
2019-02-15 15:39:39 +05:30
- [Structure and template](structure.md) - Learn the typical parts of a doc page and how to write each one.
2019-12-21 20:55:43 +05:30
- [Documentation process](workflow.md).
- [Markdown Guide](../../user/markdown.md) - A reference for all Markdown syntax supported by GitLab.
- [Site architecture](site_architecture/index.md) - How <https://docs.gitlab.com> is built.
2020-05-24 23:13:21 +05:30
- [Documentation for feature flags](feature_flags.md) - How to write and update documentation for GitLab features deployed behind feature flags.
2018-11-08 19:23:39 +05:30
2019-07-31 22:56:46 +05:30
## Source files and rendered web locations
2018-11-08 19:23:39 +05:30
2020-04-08 14:13:33 +05:30
Documentation for GitLab, GitLab Runner, Omnibus GitLab, and Charts is published to <https://docs.gitlab.com>. Documentation for GitLab is also published within the application at `/help` on the domain of the GitLab instance.
2019-12-21 20:55:43 +05:30
At `/help`, only help for your current edition and version is included. Help for other versions is available at <https://docs.gitlab.com/archives/>.
2018-11-08 19:23:39 +05:30
2019-07-31 22:56:46 +05:30
The source of the documentation exists within the codebase of each GitLab application in the following repository locations:
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
| Project | Path |
| --- | --- |
2019-12-04 20:38:33 +05:30
| [GitLab](https://gitlab.com/gitlab-org/gitlab/) | [`/doc`](https://gitlab.com/gitlab-org/gitlab/tree/master/doc) |
2019-02-15 15:39:39 +05:30
| [GitLab Runner](https://gitlab.com/gitlab-org/gitlab-runner/) | [`/docs`](https://gitlab.com/gitlab-org/gitlab-runner/tree/master/docs) |
2019-12-04 20:38:33 +05:30
| [Omnibus GitLab](https://gitlab.com/gitlab-org/omnibus-gitlab/) | [`/doc`](https://gitlab.com/gitlab-org/gitlab/tree/master/doc) |
2019-12-21 20:55:43 +05:30
| [Charts](https://gitlab.com/gitlab-org/charts/gitlab) | [`/doc`](https://gitlab.com/gitlab-org/charts/gitlab/tree/master/doc) |
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
Documentation issues and merge requests are part of their respective repositories and all have the label `Documentation`.
2020-01-01 13:55:28 +05:30
### Branch naming
The [CI pipeline for the main GitLab project](../pipelines.md) is configured to automatically
run only the jobs that match the type of contribution. If your contribution contains
**only** documentation changes, then only documentation-related jobs will be run, and
the pipeline will complete much faster than a code contribution.
If you are submitting documentation-only changes to Runner, Omnibus, or Charts,
the fast pipeline is not determined automatically. Instead, create branches for
docs-only merge requests using the following guide:
| Branch name | Valid example |
|:----------------------|:-----------------------------|
| Starting with `docs/` | `docs/update-api-issues` |
| Starting with `docs-` | `docs-update-api-issues` |
| Ending in `-docs` | `123-update-api-issues-docs` |
2019-02-15 15:39:39 +05:30
## Contributing to docs
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
[Contributions to GitLab docs](workflow.md) are welcome from the entire GitLab community.
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
To ensure that GitLab docs are current, there are special processes and responsibilities for all [feature changes](feature-change-workflow.md), that is development work that impacts the appearance, usage, or administration of a feature.
2019-02-15 15:39:39 +05:30
2019-12-04 20:38:33 +05:30
However, anyone can contribute [documentation improvements](improvement-workflow.md) that are not associated with a feature change. For example, adding a new doc on how to accomplish a use case that's already possible with GitLab or with third-party tools and GitLab.
2018-11-08 19:23:39 +05:30
## Markdown and styles
2019-09-30 21:07:59 +05:30
[GitLab docs](https://gitlab.com/gitlab-org/gitlab-docs) uses [GitLab Kramdown](https://gitlab.com/gitlab-org/gitlab_kramdown)
2020-06-23 00:09:42 +05:30
as its Markdown rendering engine. See the [GitLab Markdown Guide](https://about.gitlab.com/handbook/markdown-guide/) for a complete Kramdown reference.
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
Adhere to the [Documentation Style Guide](styleguide.md). If a style standard is missing, you are welcome to suggest one via a merge request.
2018-11-08 19:23:39 +05:30
2019-07-31 22:56:46 +05:30
## Folder structure and files
See the [Structure](styleguide.md#structure) section of the [Documentation Style Guide](styleguide.md).
2020-06-23 00:09:42 +05:30
## Metadata
To provide additional directives or useful information, we add metadata in YAML
format to the beginning of each product documentation page.
For example, the following metadata would be at the beginning of a product
documentation page whose content is primarily associated with the Audit Events
feature:
```yaml
---
stage: Monitor
group: APM
info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers
---
```
The following list describes the YAML parameters in use:
- `redirect_to`: The relative path and filename (with an `.md` extension) of the
location to which visitors should be redirected for a moved page.
[Learn more](#changing-document-location).
- `stage`: The [Stage](https://about.gitlab.com/handbook/product/categories/#devops-stages)
to which the majority of the page's content belongs.
- `group`: The [Group](https://about.gitlab.com/company/team/structure/#product-groups)
to which the majority of the page's content belongs.
- `info`: The following line, which provides direction to contributors regarding
how to contact the Technical Writer associated with the page's Stage and
Group: `To determine the technical writer assigned to the Stage/Group
associated with this page, see
https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers`
- `disqus_identifier`: Identifier for Disqus commenting system. Used to keep
comments with a page that's been moved to a new URL.
[Learn more](#redirections-for-pages-with-disqus-comments).
2019-07-31 22:56:46 +05:30
## Changing document location
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
Changing a document's location requires specific steps to ensure that
users can seamlessly access the new doc page, whether they are accessing content
2019-12-21 20:55:43 +05:30
on a GitLab instance domain at `/help` or at <https://docs.gitlab.com>. Be sure to assign a
technical writer if you have any questions during the process (such as
2019-02-15 15:39:39 +05:30
whether the move is necessary), and ensure that a technical writer reviews this
change prior to merging.
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
If you indeed need to change a document's location, do not remove the old
2020-05-24 23:13:21 +05:30
document, but instead replace all of its content with the following:
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
```markdown
---
redirect_to: '../path/to/file/index.md'
---
This document was moved to [another location](../path/to/file/index.md).
2018-11-08 19:23:39 +05:30
```
2020-05-24 23:13:21 +05:30
Where `../path/to/file/index.md` is usually the relative path to the old document.
The `redirect_to` variable supports both full and relative URLs, for example
`https://docs.gitlab.com/ee/path/to/file.html`, `../path/to/file.html`, `path/to/file.md`.
It ensures that the redirect will work for <https://docs.gitlab.com> and any `*.md` paths
will be compiled to `*.html`.
The new line underneath the front matter informs the user that the document
changed location and is useful for someone that browses that file from the repository.
2018-11-08 19:23:39 +05:30
2020-04-22 19:07:51 +05:30
For example, if you move `doc/workflow/lfs/index.md` to
2018-11-08 19:23:39 +05:30
`doc/administration/lfs.md`, then the steps would be:
2020-04-22 19:07:51 +05:30
1. Copy `doc/workflow/lfs/index.md` to `doc/administration/lfs.md`
1. Replace the contents of `doc/workflow/lfs/index.md` with:
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
```markdown
---
redirect_to: '../../administration/lfs.md'
---
2019-10-12 21:52:04 +05:30
This document was moved to [another location](../../administration/lfs.md).
```
2018-11-08 19:23:39 +05:30
1. Find and replace any occurrences of the old location with the new one.
2020-05-24 23:13:21 +05:30
A quick way to find them is to use `git grep` on the repository you changed
the file from:
2018-11-08 19:23:39 +05:30
2020-03-13 15:44:24 +05:30
```shell
2019-10-12 21:52:04 +05:30
git grep -n "workflow/lfs/lfs_administration"
git grep -n "lfs/lfs_administration"
```
2018-11-08 19:23:39 +05:30
NOTE: **Note:**
If the document being moved has any Disqus comments on it, there are extra steps
to follow documented just [below](#redirections-for-pages-with-disqus-comments).
Things to note:
- Since we also use inline documentation, except for the documentation itself,
the document might also be referenced in the views of GitLab (`app/`) which will
render when visiting `/help`, and sometimes in the testing suite (`spec/`).
2019-02-15 15:39:39 +05:30
You must search these paths for references to the doc and update them as well.
2018-11-08 19:23:39 +05:30
- The above `git grep` command will search recursively in the directory you run
it in for `workflow/lfs/lfs_administration` and `lfs/lfs_administration`
and will print the file and the line where this file is mentioned.
2020-04-08 14:13:33 +05:30
You may ask why the two greps. Since [we use relative paths to link to
2020-06-23 00:09:42 +05:30
documentation](styleguide.md#links), sometimes it might be useful to search a path deeper.
2018-11-08 19:23:39 +05:30
- The `*.md` extension is not used when a document is linked to GitLab's
2020-06-23 00:09:42 +05:30
built-in help page, which is why we omit it in `git grep`.
2018-11-20 20:47:30 +05:30
- Use the checklist on the "Change documentation location" MR description template.
2018-11-08 19:23:39 +05:30
2019-07-31 22:56:46 +05:30
### Redirections for pages with Disqus comments
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
If the documentation page being relocated already has Disqus comments,
2018-11-08 19:23:39 +05:30
we need to preserve the Disqus thread.
2019-12-21 20:55:43 +05:30
Disqus uses an identifier per page, and for <https://docs.gitlab.com>, the page identifier
2018-11-08 19:23:39 +05:30
is configured to be the page URL. Therefore, when we change the document location,
we need to preserve the old URL as the same Disqus identifier.
2020-05-24 23:13:21 +05:30
To do that, add to the front matter the variable `disqus_identifier`,
using the old URL as value. For example, let's say we moved the document
2018-11-08 19:23:39 +05:30
available under `https://docs.gitlab.com/my-old-location/README.html` to a new location,
`https://docs.gitlab.com/my-new-location/index.html`.
2020-05-24 23:13:21 +05:30
Into the **new document** front matter, we add the following:
2018-11-08 19:23:39 +05:30
```yaml
---
2019-10-12 21:52:04 +05:30
disqus_identifier: 'https://docs.gitlab.com/my-old-location/README.html'
2018-11-08 19:23:39 +05:30
---
```
2019-10-12 21:52:04 +05:30
Note: it is necessary to include the file name in the `disqus_identifier` URL,
2018-11-08 19:23:39 +05:30
even if it's `index.html` or `README.html`.
## Merge requests for GitLab documentation
Before getting started, make sure you read the introductory section
"[contributing to docs](#contributing-to-docs)" above and the
2019-02-15 15:39:39 +05:30
[documentation workflow](workflow.md).
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
- Use the current [merge request description template](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/merge_request_templates/Documentation.md)
2020-05-24 23:13:21 +05:30
- Label the MR `Documentation` (can only be done by people with `developer` access, for example, GitLab team members)
- Assign the correct milestone per note below (can only be done by people with `developer` access, for example, GitLab team members)
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
Documentation will be merged if it is an improvement on existing content,
represents a good-faith effort to follow the template and style standards,
and is believed to be accurate.
Further needs for what would make the doc even better should be immediately addressed
in a follow-up MR or issue.
2018-11-08 19:23:39 +05:30
NOTE: **Note:**
If the release version you want to add the documentation to has already been
2020-05-24 23:13:21 +05:30
frozen or released, use the label `~"Pick into X.Y"` to get it merged into
2018-11-08 19:23:39 +05:30
the correct release. Avoid picking into a past release as much as you can, as
it increases the work of the release managers.
2019-02-15 15:39:39 +05:30
## GitLab `/help`
2019-09-30 21:07:59 +05:30
Every GitLab instance includes the documentation, which is available at `/help`
(`https://gitlab.example.com/help`). For example, <https://gitlab.com/help>.
There are [plans](https://gitlab.com/groups/gitlab-org/-/epics/693) to end this
2019-12-21 20:55:43 +05:30
practice and instead link out from the GitLab application to <https://docs.gitlab.com> URLs.
2019-02-15 15:39:39 +05:30
2020-03-13 15:44:24 +05:30
The documentation available online on <https://docs.gitlab.com> is deployed every four hours from the `master` branch of GitLab, Omnibus, and Runner. Therefore,
after a merge request gets merged, it will be available online on the same day.
However, it will be shipped (and available on `/help`) within the milestone assigned
2019-02-15 15:39:39 +05:30
to the MR.
2020-03-13 15:44:24 +05:30
For example, let's say your merge request has a milestone set to 11.3, which
2019-02-15 15:39:39 +05:30
will be released on 2018-09-22. If it gets merged on 2018-09-15, it will be
available online on 2018-09-15, but, as the feature freeze date has passed, if
2020-05-24 23:13:21 +05:30
the MR does not have a `~"Pick into 11.3"` label, the milestone has to be changed
2019-02-15 15:39:39 +05:30
to 11.4 and it will be shipped with all GitLab packages only on 2018-10-22,
with GitLab 11.4. Meaning, it will only be available under `/help` from GitLab
2020-03-13 15:44:24 +05:30
11.4 onward, but available on <https://docs.gitlab.com/> on the same day it was merged.
2019-02-15 15:39:39 +05:30
### Linking to `/help`
When you're building a new feature, you may need to link the documentation
from GitLab, the application. This is normally done in files inside the
`app/views/` directory with the help of the `help_page_path` helper method.
In its simplest form, the HAML code to generate a link to the `/help` page is:
```haml
= link_to 'Help page', help_page_path('user/permissions')
```
The `help_page_path` contains the path to the document you want to link to with
the following conventions:
- it is relative to the `doc/` directory in the GitLab repository
- the `.md` extension must be omitted
- it must not end with a slash (`/`)
Below are some special cases where should be used depending on the context.
You can combine one or more of the following:
1. **Linking to an anchor link.** Use `anchor` as part of the `help_page_path`
method:
2019-10-12 21:52:04 +05:30
```haml
= link_to 'Help page', help_page_path('user/permissions', anchor: 'anchor-link')
```
2019-02-15 15:39:39 +05:30
1. **Opening links in a new tab.** This should be the default behavior:
2019-10-12 21:52:04 +05:30
```haml
= link_to 'Help page', help_page_path('user/permissions'), target: '_blank'
```
2019-02-15 15:39:39 +05:30
1. **Linking to a circle icon.** Usually used in settings where a long
description cannot be used, like near checkboxes. You can basically use
any font awesome icon, but prefer the `question-circle`:
2019-10-12 21:52:04 +05:30
```haml
= link_to icon('question-circle'), help_page_path('user/permissions')
```
2019-02-15 15:39:39 +05:30
1. **Using a button link.** Useful in places where text would be out of context
with the rest of the page layout:
2019-10-12 21:52:04 +05:30
```haml
= link_to 'Help page', help_page_path('user/permissions'), class: 'btn btn-info'
```
2019-02-15 15:39:39 +05:30
1. **Using links inline of some text.**
2019-10-12 21:52:04 +05:30
```haml
Description to #{link_to 'Help page', help_page_path('user/permissions')}.
```
2019-02-15 15:39:39 +05:30
1. **Adding a period at the end of the sentence.** Useful when you don't want
the period to be part of the link:
2019-10-12 21:52:04 +05:30
```haml
= succeed '.' do
Learn more in the
= link_to 'Help page', help_page_path('user/permissions')
```
2019-02-15 15:39:39 +05:30
### GitLab `/help` tests
2020-05-24 23:13:21 +05:30
Several [RSpec tests](https://gitlab.com/gitlab-org/gitlab/blob/master/spec/features/help_pages_spec.rb)
2019-02-15 15:39:39 +05:30
are run to ensure GitLab documentation renders and works correctly. In particular, that [main docs landing page](../../README.md) will work correctly from `/help`.
For example, [GitLab.com's `/help`](https://gitlab.com/help).
## Docs site architecture
See the [Docs site architecture](site_architecture/index.md) page to learn
2019-12-21 20:55:43 +05:30
how we build and deploy the site at <https://docs.gitlab.com> and
2019-02-15 15:39:39 +05:30
to review all the assets and libraries in use.
### Global navigation
See the [Global navigation](site_architecture/global_nav.md) doc for information
on how the left-side navigation menu is built and updated.
2019-01-03 12:48:30 +05:30
## Previewing the changes live
NOTE: **Note:**
To preview your changes to documentation locally, follow this
2019-09-30 21:07:59 +05:30
[development guide](https://gitlab.com/gitlab-org/gitlab-docs/blob/master/README.md#development-when-contributing-to-gitlab-documentation) or [these instructions for GDK](https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/howto/gitlab_docs.md).
2019-01-03 12:48:30 +05:30
The live preview is currently enabled for the following projects:
2020-05-24 23:13:21 +05:30
- [`gitlab`](https://gitlab.com/gitlab-org/gitlab)
- [`gitlab-runner`](https://gitlab.com/gitlab-org/gitlab-runner)
2019-01-03 12:48:30 +05:30
2019-12-04 20:38:33 +05:30
If your merge request has docs changes, you can use the manual `review-docs-deploy` job
to deploy the docs review app for your merge request.
You will need at least Maintainer permissions to be able to run it.
2019-01-03 12:48:30 +05:30
![Manual trigger a docs build](img/manual_build_docs.png)
NOTE: **Note:**
You will need to push a branch to those repositories, it doesn't work for forks.
The `review-docs-deploy*` job will:
2019-12-21 20:55:43 +05:30
1. Create a new branch in the [`gitlab-docs`](https://gitlab.com/gitlab-org/gitlab-docs)
project named after the scheme: `docs-preview-$DOCS_GITLAB_REPO_SUFFIX-$CI_MERGE_REQUEST_IID`,
where `DOCS_GITLAB_REPO_SUFFIX` is the suffix for each product, e.g, `ee` for
EE, `omnibus` for Omnibus GitLab, etc, and `CI_MERGE_REQUEST_IID` is the ID
of the respective merge request.
1. Trigger a cross project pipeline and build the docs site with your changes.
2019-01-03 12:48:30 +05:30
2019-12-21 20:55:43 +05:30
In case the review app URL returns 404, this means that either the site is not
yet deployed, or something went wrong with the remote pipeline. Give it a few
minutes and it should appear online, otherwise you can check the status of the
remote pipeline from the link in the merge request's job output.
If the pipeline failed or got stuck, drop a line in the `#docs` chat channel.
2019-01-03 12:48:30 +05:30
TIP: **Tip:**
2019-12-04 20:38:33 +05:30
Someone with no merge rights to the GitLab projects (think of forks from
contributors) cannot run the manual job. In that case, you can
2019-01-03 12:48:30 +05:30
ask someone from the GitLab team who has the permissions to do that for you.
NOTE: **Note:**
Make sure that you always delete the branch of the merge request you were
working on. If you don't, the remote docs branch won't be removed either,
and the server where the Review Apps are hosted will eventually be out of
disk space.
### Troubleshooting review apps
In case the review app URL returns 404, follow these steps to debug:
1. **Did you follow the URL from the merge request widget?** If yes, then check if
the link is the same as the one in the job output.
1. **Did you follow the URL from the job output?** If yes, then it means that
either the site is not yet deployed or something went wrong with the remote
pipeline. Give it a few minutes and it should appear online, otherwise you
can check the status of the remote pipeline from the link in the job output.
If the pipeline failed or got stuck, drop a line in the `#docs` chat channel.
### Technical aspects
2019-02-15 15:39:39 +05:30
If you want to know the in-depth details, here's what's really happening:
2019-01-03 12:48:30 +05:30
2019-12-04 20:38:33 +05:30
1. You manually run the `review-docs-deploy` job in a merge request.
1. The job runs the [`scripts/trigger-build-docs`](https://gitlab.com/gitlab-org/gitlab/blob/master/scripts/trigger-build-docs)
2019-01-03 12:48:30 +05:30
script with the `deploy` flag, which in turn:
1. Takes your branch name and applies the following:
2019-12-21 20:55:43 +05:30
- The `docs-preview-` prefix is added.
- The product slug is used to know the project the review app originated
from.
- The number of the merge request is added so that you can know by the
`gitlab-docs` branch name the merge request it originated from.
2019-01-03 12:48:30 +05:30
1. The remote branch is then created if it doesn't exist (meaning you can
re-run the manual job as many times as you want and this step will be skipped).
1. A new cross-project pipeline is triggered in the docs project.
1. The preview URL is shown both at the job output and in the merge request
widget. You also get the link to the remote pipeline.
1. In the docs project, the pipeline is created and it
2019-09-30 21:07:59 +05:30
[skips the test jobs](https://gitlab.com/gitlab-org/gitlab-docs/blob/8d5d5c750c602a835614b02f9db42ead1c4b2f5e/.gitlab-ci.yml#L50-55)
2019-01-03 12:48:30 +05:30
to lower the build time.
1. Once the docs site is built, the HTML files are uploaded as artifacts.
1. A specific Runner tied only to the docs project, runs the Review App job
that downloads the artifacts and uses `rsync` to transfer the files over
to a location where NGINX serves them.
The following GitLab features are used among others:
2019-07-07 11:18:12 +05:30
- [Manual actions](../../ci/yaml/README.md#whenmanual)
2019-09-04 21:01:54 +05:30
- [Multi project pipelines](../../ci/multi_project_pipeline_graphs.md)
2019-01-03 12:48:30 +05:30
- [Review Apps](../../ci/review_apps/index.md)
- [Artifacts](../../ci/yaml/README.md#artifacts)
2020-06-23 00:09:42 +05:30
- [Specific Runner](../../ci/runners/README.md#prevent-a-specific-runner-from-being-enabled-for-other-projects)
2019-12-21 20:55:43 +05:30
- [Pipelines for merge requests](../../ci/merge_request_pipelines/index.md)
2019-01-03 12:48:30 +05:30
2019-02-15 15:39:39 +05:30
## Testing
2018-11-08 19:23:39 +05:30
2019-12-21 20:55:43 +05:30
We treat documentation as code, and so use tests in our CI pipeline to maintain the
standards and quality of the docs. The current tests, which run in CI jobs when a
merge request with new or changed docs is submitted, are:
- [`docs lint`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L48):
Runs several tests on the content of the docs themselves:
- [`lint-doc.sh` script](https://gitlab.com/gitlab-org/gitlab/blob/master/scripts/lint-doc.sh)
2020-04-08 14:13:33 +05:30
runs the following checks and linters:
2019-12-21 20:55:43 +05:30
- All cURL examples use the long flags (ex: `--header`, not `-H`).
- The `CHANGELOG.md` does not contain duplicate versions.
- No files in `doc/` are executable.
- No new `README.md` was added.
2020-04-08 14:13:33 +05:30
- [markdownlint](#markdownlint).
- [Vale](#vale).
- Nanoc tests:
2019-12-21 20:55:43 +05:30
- [`internal_links`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L67)
checks that all internal links (ex: `[link](../index.md)`) are valid.
- [`internal_anchors`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L69)
checks that all internal anchors (ex: `[link](../index.md#internal_anchor)`)
are valid.
2018-11-08 19:23:39 +05:30
2020-04-22 19:07:51 +05:30
### Running tests
2020-04-08 14:13:33 +05:30
Apart from [previewing your changes locally](#previewing-the-changes-live), you can also run all lint checks
and Nanoc tests locally.
#### Nanoc tests
To execute Nanoc tests locally:
1. Navigate to the [`gitlab-docs`](https://gitlab.com/gitlab-org/gitlab-docs) directory.
1. Run:
```shell
# Check for broken internal links
bundle exec nanoc check internal_links
# Check for broken external links (might take a lot of time to complete).
# This test is set to be allowed to fail and is run only in the gitlab-docs project CI
bundle exec nanoc check internal_anchors
```
#### Lint checks
Lint checks are performed by the [`lint-doc.sh`](https://gitlab.com/gitlab-org/gitlab/blob/master/scripts/lint-doc.sh)
script and can be executed as follows:
1. Navigate to the `gitlab` directory.
1. Run:
```shell
MD_DOC_PATH=path/to/my_doc.md scripts/lint-doc.sh
```
Where `MD_DOC_PATH` points to the file or directory you would like to run lint checks for.
If you omit it completely, it will default to the `doc/` directory.
The output should be similar to:
2020-04-22 19:07:51 +05:30
```plaintext
2020-04-08 14:13:33 +05:30
=> Linting documents at path /path/to/gitlab as <user>...
=> Checking for cURL short options...
=> Checking for CHANGELOG.md duplicate entries...
=> Checking /path/to/gitlab/doc for executable permissions...
=> Checking for new README.md files...
=> Linting markdown style...
=> Linting prose...
✔ 0 errors, 0 warnings and 0 suggestions in 1 file.
✔ Linting passed
```
Note that this requires you to either have the required lint tools installed on your machine,
or a working Docker installation, in which case an image with these tools pre-installed will be used.
2020-04-22 19:07:51 +05:30
### Local linting
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
To help adhere to the [documentation style guidelines](styleguide.md), and improve the content
2019-02-15 15:39:39 +05:30
added to documentation, consider locally installing and running documentation linters. This will
help you catch common issues before raising merge requests for review of documentation.
2018-11-08 19:23:39 +05:30
2020-04-22 19:07:51 +05:30
Running the following locally allows you to match the checks in the build pipeline:
2018-11-08 19:23:39 +05:30
2020-04-22 19:07:51 +05:30
- [markdownlint](#markdownlint).
- [Vale](#vale).
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
NOTE: **Note:**
This list does not limit what other linters you can add to your local documentation writing toolchain.
2018-11-08 19:23:39 +05:30
2020-01-01 13:55:28 +05:30
#### markdownlint
2018-11-08 19:23:39 +05:30
2020-01-01 13:55:28 +05:30
[markdownlint](https://github.com/DavidAnson/markdownlint) checks that Markdown
2019-12-04 20:38:33 +05:30
syntax follows [certain rules](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#rules),
and is used by the [`docs-lint` test](#testing) with a [configuration file](#markdownlint-configuration).
2020-06-23 00:09:42 +05:30
Our [Documentation Style Guide](styleguide.md#markdown) and [Markdown Guide](https://about.gitlab.com/handbook/markdown-guide/)
2019-10-12 21:52:04 +05:30
elaborate on which choices must be made when selecting Markdown syntax for GitLab
2019-12-04 20:38:33 +05:30
documentation. This tool helps catch deviations from those guidelines.
2018-11-08 19:23:39 +05:30
2020-01-01 13:55:28 +05:30
markdownlint can be used [on the command line](https://github.com/igorshubovych/markdownlint-cli#markdownlint-cli--),
2019-10-12 21:52:04 +05:30
either on a single Markdown file or on all Markdown files in a project. For example, to run
2020-01-01 13:55:28 +05:30
markdownlint on all documentation in the [`gitlab` project](https://gitlab.com/gitlab-org/gitlab),
2019-12-04 20:38:33 +05:30
run the following commands from within your `gitlab` project root directory, which will
2020-05-24 23:13:21 +05:30
automatically detect the [`.markdownlint.json`](#markdownlint-configuration) configuration
2019-12-04 20:38:33 +05:30
file in the root of the project, and test all files in `/doc` and its subdirectories:
2018-11-08 19:23:39 +05:30
2020-03-13 15:44:24 +05:30
```shell
2019-12-04 20:38:33 +05:30
markdownlint 'doc/**/*.md'
2019-02-15 15:39:39 +05:30
```
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
If you wish to use a different configuration file, use the `-c` flag:
2019-12-04 20:38:33 +05:30
2020-03-13 15:44:24 +05:30
```shell
2019-12-04 20:38:33 +05:30
markdownlint -c <config-file-name> 'doc/**/*.md'
```
2020-06-23 00:09:42 +05:30
##### Run markdownlint in an editor
markdownlint can also be run as a linter within text editors using [plugins/extensions](https://github.com/DavidAnson/markdownlint#related),
2019-12-04 20:38:33 +05:30
such as:
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
- [Sublime Text](https://packagecontrol.io/packages/SublimeLinter-contrib-markdownlint)
- [Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint)
2019-12-04 20:38:33 +05:30
- [Atom](https://atom.io/packages/linter-node-markdownlint)
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
It is best to use the [same configuration file](#markdownlint-configuration) as what
2020-05-24 23:13:21 +05:30
is in use in the four repositories that are the sources for <https://docs.gitlab.com>. Each
2019-12-04 20:38:33 +05:30
plugin/extension has different requirements regarding the configuration file, which
is explained in each editor's docs.
2018-11-08 19:23:39 +05:30
2020-01-01 13:55:28 +05:30
##### markdownlint configuration
2018-11-08 19:23:39 +05:30
2020-01-01 13:55:28 +05:30
Each formatting issue that markdownlint checks has an associated
2019-12-04 20:38:33 +05:30
[rule](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#rules).
These rules are configured in the `.markdownlint.json` files located in the root of
2020-05-24 23:13:21 +05:30
four repositories that are the sources for <https://docs.gitlab.com>:
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
- [`gitlab`](https://gitlab.com/gitlab-org/gitlab/blob/master/.markdownlint.json)
- [`gitlab-runner`](https://gitlab.com/gitlab-org/gitlab-runner/blob/master/.markdownlint.json)
- [`omnibus-gitlab`](https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/.markdownlint.json)
- [`charts`](https://gitlab.com/charts/gitlab/blob/master/.markdownlint.json)
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
By default all rules are enabled, so the configuration file is used to disable unwanted
2019-12-21 20:55:43 +05:30
rules, and also to configure optional parameters for enabled rules as needed. You can
2020-06-23 00:09:42 +05:30
also check [the issue](https://gitlab.com/gitlab-org/gitlab-foss/-/issues/64352) that
2019-12-21 20:55:43 +05:30
tracked the changes required to implement these rules, and details which rules were
2020-01-01 13:55:28 +05:30
on or off when markdownlint was enabled on the docs.
2018-11-08 19:23:39 +05:30
2020-03-13 15:44:24 +05:30
#### Vale
2020-05-24 23:13:21 +05:30
[Vale](https://errata-ai.gitbook.io/vale/) is a grammar, style, and word usage linter
2020-03-13 15:44:24 +05:30
for the English language. Vale's configuration is stored in the
[`.vale.ini`](https://gitlab.com/gitlab-org/gitlab/blob/master/.vale.ini) file
located in the root directory of the [GitLab repository](https://gitlab.com/gitlab-org/gitlab).
Vale supports creating [custom tests](https://errata-ai.github.io/vale/styles/),
stored in the `doc/.linting/vale/styles/gitlab` directory, that extend any of
several types of checks.
To view linting suggestions locally, you must install Vale on your own machine,
and from GitLab's root directory (where `.vale.ini` is located), run:
```shell
vale --glob='*.{md}' doc
```
2020-06-23 00:09:42 +05:30
Vale's error-level test results [are displayed](#testing) in CI pipelines.
##### Run Vale in an editor
You can run Vale as a linter within your text editor of choice, with:
- The Sublime Text [`SublimeLinter-contrib-vale` plugin](https://packagecontrol.io/packages/SublimeLinter-contrib-vale)
- The Visual Studio Code [`testthedocs.vale` extension](https://marketplace.visualstudio.com/items?itemName=testthedocs.vale)
2020-03-13 15:44:24 +05:30
2020-06-23 00:09:42 +05:30
We don't use [Vale Server](https://errata-ai.github.io/vale/#using-vale-with-a-text-editor-or-another-third-party-application).
2020-05-24 23:13:21 +05:30
##### Disable a Vale test
You can disable a specific Vale linting rule or all Vale linting rules for any portion of a document:
- To disable a specific rule, add a `<!-- vale gitlab.rulename = NO -->` tag
before the text, and a `<!-- vale gitlab.rulename = YES -->` tag after the text,
replacing `rulename` with the filename of a test in the [GitLab styles](https://gitlab.com/gitlab-org/gitlab/-/tree/master/doc/.linting/vale/styles/gitlab) directory.
- To disable all Vale linting rules, add a `<!-- vale off -->` tag before the text,
and a `<!-- vale on -->` tag after the text.
Whenever possible, exclude only the problematic rule and line(s).
In some cases, such as list items, you may need to disable linting for the entire
list until ["Ignore comments are not honored in a Markdown file"](https://github.com/errata-ai/vale/issues/175) is resolved.
For more information, see [Vale's documentation](https://errata-ai.gitbook.io/vale/getting-started/markup#markup-based-configuration).
2019-02-15 15:39:39 +05:30
## Danger Bot
2018-11-08 19:23:39 +05:30
2019-02-15 15:39:39 +05:30
GitLab uses [Danger](https://github.com/danger/danger) for some elements in
code review. For docs changes in merge requests, whenever a change to files under `/doc`
is made, Danger Bot leaves a comment with further instructions about the documentation
2020-05-24 23:13:21 +05:30
process. This is configured in the `Dangerfile` in the GitLab repository under
2019-12-04 20:38:33 +05:30
[/danger/documentation/](https://gitlab.com/gitlab-org/gitlab/tree/master/danger/documentation).