11 KiB
stage | group | info |
---|---|---|
Growth | Product Intelligence | To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments |
Metrics Dictionary Guide
This guide describes Metrics Dictionary and how it's implemented
Metrics Definition and validation
We are using JSON Schema to validate the metrics definition.
This process is meant to ensure consistent and valid metrics defined for Usage Ping. All metrics must:
- Comply with the defined JSON schema.
- Have a unique
key_path
. - Have an owner.
All metrics are stored in YAML files:
Each metric is defined in a separate YAML file consisting of a number of fields:
Field | Required | Additional information |
---|---|---|
key_path |
yes | JSON key path for the metric, location in Usage Ping payload. |
name |
no | Metric name suggestion. Can replace the last part of key_path . |
description |
yes | |
product_section |
yes | The section. |
product_stage |
no | The stage for the metric. |
product_group |
yes | The group that owns the metric. |
product_category |
no | The product category for the metric. |
value_type |
yes | string ; one of string , number , boolean , object . |
status |
yes | string ; status of the metric, may be set to data_available , implemented , not_used , deprecated , removed . |
time_frame |
yes | string ; may be set to a value like 7d , 28d , all , none . |
data_source |
yes | string ; may be set to a value like database , redis , redis_hll , prometheus , system . |
instrumentation_class |
no | string ; the class that implements the metric. |
distribution |
yes | array ; may be set to one of ce, ee or ee . The distribution where the tracked feature is available. |
tier |
yes | array ; may be set to one of free, premium, ultimate , premium, ultimate or ultimate . The tier where the tracked feature is available. |
milestone |
no | The milestone when the metric is introduced. |
milestone_removed |
no | The milestone when the metric is removed. |
introduced_by_url |
no | The URL to the Merge Request that introduced the metric. |
extra |
no | object : extra information needed to calculate the metric value. |
skip_validation |
no | This should not be set. Used for imported metrics until we review, update and make them valid. |
Metric statuses
Metric definitions can have one of the following statuses:
data_available
: Metric data is available and used in a Sisense dashboard.implemented
: Metric is implemented but data is not yet available. This is a temporary status for newly added metrics awaiting inclusion in a new release.not_used
: Metric is not used in any dashboard.deprecated
: Metric is deprecated and possibly planned to be removed.removed
: Metric was removed, but it may appear in Usage Ping payloads sent from instances running on older versions of GitLab.
Metric name
To improve metric discoverability by a wider audience, each metric with
instrumentation added at an appointed key_path
receives a name
attribute
filled with the name suggestion, corresponding to the metric data_source
and instrumentation.
Metric name suggestions can contain two types of elements:
- User input prompts: Enclosed by
<>
, these pieces should be replaced or removed when you create a metrics YAML file. - Fixed suggestion: Plaintext parts generated according to well-defined algorithms. They are based on underlying instrumentation, and should not be changed.
For a metric name to be valid, it must not include any prompt, and no fixed suggestions should be changed.
Metric name suggestion examples
Metric with data_source: database
For a metric instrumented with SQL:
SELECT COUNT(DISTINCT user_id) FROM clusters WHERE clusters.management_project_id IS NOT NULL
- Suggested name:
count_distinct_user_id_from_<adjective describing: '(clusters.management_project_id IS NOT NULL)'>_clusters
- Prompt:
<adjective describing: '(clusters.management_project_id IS NOT NULL)'>
should be replaced with an adjective that best represents filter conditions, such asproject_management
- Final metric name: For example,
count_distinct_user_id_from_project_management_clusters
For metric instrumented with SQL:
SELECT COUNT(DISTINCT clusters.user_id)
FROM clusters_applications_helm
INNER JOIN clusters ON clusters.id = clusters_applications_helm.cluster_id
WHERE clusters_applications_helm.status IN (3, 5)
- Suggested name:
count_distinct_user_id_from_<adjective describing: '(clusters_applications_helm.status IN (3, 5))'>_clusters_<with>_<adjective describing: '(clusters_applications_helm.status IN (3, 5))'>_clusters_applications_helm
- Prompt:
<adjective describing: '(clusters_applications_helm.status IN (3, 5))'>
should be replaced with an adjective that best represents filter conditions - Final metric name:
count_distinct_user_id_from_clusters_with_available_clusters_applications_helm
In the previous example, the prompt is irrelevant, and user can remove it. The second
occurrence corresponds with the available
scope defined in Clusters::Concerns::ApplicationStatus
.
It can be used as the right adjective to replace prompt.
The <with>
represents a suggested conjunction for the suggested name of the joined relation.
The person documenting the metric can use it by either:
- Removing the surrounding
<>
. - Using a different conjunction, such as
having
orincluding
.
Metric with data_source: redis
or redis_hll
For metrics instrumented with a Redis-based counter, the suggested name includes only the single prompt to be replaced by the person working with metrics YAML.
- Prompt:
<please fill metric name, suggested format is: {subject}_{verb}{ing|ed}_{object} eg: users_creating_epics or merge_requests_viewed_in_single_file_mode>
- Final metric name: We suggest the metric name should follow the format of
{subject}_{verb}{ing|ed}_{object}
, such asuser_creating_epics
,users_triggering_security_scans
, ormerge_requests_viewed_in_single_file_mode
Metric with data_source: prometheus
or system
For metrics instrumented with Prometheus or coming from the operating system, the suggested name includes only the single prompt by person working with metrics YAML.
- Prompt:
<please fill metric name>
- Final metric name: Due to the variety of cases that can apply to this kind of metric, no naming convention exists. Each person instrumenting a metric should use their best judgment to come up with a descriptive name.
Example YAML metric definition
The linked uuid
YAML file includes an example metric definition, where the uuid
metric is the GitLab
instance unique identifier.
key_path: uuid
description: GitLab instance unique identifier
product_category: collection
product_section: growth
product_stage: growth
product_group: group::product intelligence
value_type: string
status: data_available
milestone: 9.1
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/1521
time_frame: none
data_source: database
distribution:
- ce
- ee
tier:
- free
- premium
- ultimate
Create a new metric definition
The GitLab codebase provides a dedicated generator to create new metric definitions.
For uniqueness, the generated file includes a timestamp prefix, in ISO 8601 format.
The generator takes the key path argument and 2 options and creates the metric YAML definition in corresponding location:
--ee
,--no-ee
Indicates if metric is for EE.--dir=DIR
indicates the metric directory. It must be one of:counts_7d
,7d
,counts_28d
,28d
,counts_all
,all
,settings
,license
.
bundle exec rails generate gitlab:usage_metric_definition counts.issues --dir=7d
create config/metrics/counts_7d/issues.yml
NOTE:
To create a metric definition used in EE, add the --ee
flag.
bundle exec rails generate gitlab:usage_metric_definition counts.issues --ee --dir=7d
create ee/config/metrics/counts_7d/issues.yml
Metrics added dynamic to Usage Ping payload
The Redis HLL metrics are added automatically to Usage Ping payload.
A YAML metric definition is required for each metric. A dedicated generator is provided to create metric definitions for Redis HLL events.
The generator takes category
and event
arguments, as the root key will be redis_hll_counters
, and creates two metric definitions for weekly and monthly timeframes:
bundle exec rails generate gitlab:usage_metric_definition:redis_hll issues i_closed
create config/metrics/counts_7d/i_closed_weekly.yml
create config/metrics/counts_28d/i_closed_monthly.yml
To create a metric definition used in EE, add the --ee
flag.
bundle exec rails generate gitlab:usage_metric_definition:redis_hll issues users_closing_issues --ee
create config/metrics/counts_7d/i_closed_weekly.yml
create config/metrics/counts_28d/i_closed_monthly.yml