fix: don't panic RedisCache actor when result receiver is dropped #2

Merged

realaravinth merged 1 commit from gh-17 into master

2026-06-12 22:19:01 +05:30

realaravinth commented

2026-06-12 18:49:37 +05:30

Owner

If the caller of CachePoW/RetrivePoW/CacheResult/VerifyCaptchaResult
drops the oneshot receiver before the Redis operation completes (e.g.
the HTTP client disconnects mid-request), tx.send() fails and the
unwrap() panics inside the actor context. The actor dies and every
subsequent captcha verification on that instance fails with
"Actor mailbox error" until the process is restarted.

Ignore the send result instead, matching the existing idiom in
master/embedded/master.rs (RemoveCaptcha handler).

Courtesy of https://github.com/leeguooooo

If the caller of CachePoW/RetrivePoW/CacheResult/VerifyCaptchaResult drops the oneshot receiver before the Redis operation completes (e.g. the HTTP client disconnects mid-request), tx.send() fails and the unwrap() panics inside the actor context. The actor dies and every subsequent captcha verification on that instance fails with "Actor mailbox error" until the process is restarted. Ignore the send result instead, matching the existing idiom in master/embedded/master.rs (RemoveCaptcha handler). --- Courtesy of https://github.com/leeguooooo

realaravinth self-assigned this

2026-06-12 18:49:37 +05:30

realaravinth added 1 commit

2026-06-12 18:49:38 +05:30

fix: don't panic RedisCache actor when result receiver is dropped

Lint / fmt (pull_request) Has been cancelled

Details

Lint / clippy (pull_request) Has been cancelled

Details

CI (Linux) / nightly - x86_64-unknown-linux-gnu (pull_request) Has been cancelled

Details

CI (Linux) / stable - x86_64-unknown-linux-gnu (pull_request) Has been cancelled

Details

7abe8d7df5

If the caller of CachePoW/RetrivePoW/CacheResult/VerifyCaptchaResult
drops the oneshot receiver before the Redis operation completes (e.g.
the HTTP client disconnects mid-request), tx.send() fails and the
unwrap() panics inside the actor context. The actor dies and every
subsequent captcha verification on that instance fails with
"Actor mailbox error" until the process is restarted.

Ignore the send result instead, matching the existing idiom in
master/embedded/master.rs (RemoveCaptcha handler).

realaravinth force-pushed gh-17 from 7abe8d7df5

Lint / fmt (pull_request) Has been cancelled

Details

Lint / clippy (pull_request) Has been cancelled

Details

CI (Linux) / nightly - x86_64-unknown-linux-gnu (pull_request) Has been cancelled

Details

CI (Linux) / stable - x86_64-unknown-linux-gnu (pull_request) Has been cancelled

Details

to 0783df997d

ci/woodpecker/push/woodpecker Pipeline was successful

Details