fix: consistency check for Store before creating Category
This commit is contained in:
parent
ae8615b8ee
commit
3a65f2ca17
1 changed files with 41 additions and 2 deletions
|
@ -10,7 +10,9 @@ use mockall::*;
|
||||||
|
|
||||||
use super::errors::*;
|
use super::errors::*;
|
||||||
use crate::inventory::{
|
use crate::inventory::{
|
||||||
application::port::output::db::{category_id_exists::*, category_name_exists_for_store::*},
|
application::port::output::db::{
|
||||||
|
category_id_exists::*, category_name_exists_for_store::*, store_id_exists::*,
|
||||||
|
},
|
||||||
domain::{
|
domain::{
|
||||||
add_category_command::AddCategoryCommand,
|
add_category_command::AddCategoryCommand,
|
||||||
category_added_event::{CategoryAddedEvent, CategoryAddedEventBuilder},
|
category_added_event::{CategoryAddedEvent, CategoryAddedEventBuilder},
|
||||||
|
@ -29,7 +31,7 @@ pub type AddCategoryServiceObj = Arc<dyn AddCategoryUseCase>;
|
||||||
|
|
||||||
#[derive(Clone, Builder)]
|
#[derive(Clone, Builder)]
|
||||||
pub struct AddCategoryService {
|
pub struct AddCategoryService {
|
||||||
// TODO: check if store ID exists
|
db_store_id_exists: StoreIDExistsDBPortObj,
|
||||||
db_category_name_exists_for_store: CategoryNameExistsForStoreDBPortObj,
|
db_category_name_exists_for_store: CategoryNameExistsForStoreDBPortObj,
|
||||||
db_category_id_exists: CategoryIDExistsDBPortObj,
|
db_category_id_exists: CategoryIDExistsDBPortObj,
|
||||||
get_uuid: GetUUIDInterfaceObj,
|
get_uuid: GetUUIDInterfaceObj,
|
||||||
|
@ -38,6 +40,14 @@ pub struct AddCategoryService {
|
||||||
#[async_trait::async_trait]
|
#[async_trait::async_trait]
|
||||||
impl AddCategoryUseCase for AddCategoryService {
|
impl AddCategoryUseCase for AddCategoryService {
|
||||||
async fn add_category(&self, cmd: AddCategoryCommand) -> InventoryResult<CategoryAddedEvent> {
|
async fn add_category(&self, cmd: AddCategoryCommand) -> InventoryResult<CategoryAddedEvent> {
|
||||||
|
if !self
|
||||||
|
.db_store_id_exists
|
||||||
|
.store_id_exists(cmd.store_id())
|
||||||
|
.await?
|
||||||
|
{
|
||||||
|
return Err(InventoryError::StoreIDNotFound);
|
||||||
|
}
|
||||||
|
|
||||||
let mut category_id = self.get_uuid.get_uuid();
|
let mut category_id = self.get_uuid.get_uuid();
|
||||||
|
|
||||||
loop {
|
loop {
|
||||||
|
@ -128,6 +138,7 @@ pub mod tests {
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
let s = AddCategoryServiceBuilder::default()
|
let s = AddCategoryServiceBuilder::default()
|
||||||
|
.db_store_id_exists(mock_store_id_exists_db_port_true(IS_CALLED_ONLY_ONCE))
|
||||||
.db_category_name_exists_for_store(mock_category_name_exists_for_store_db_port_false(
|
.db_category_name_exists_for_store(mock_category_name_exists_for_store_db_port_false(
|
||||||
IS_CALLED_ONLY_ONCE,
|
IS_CALLED_ONLY_ONCE,
|
||||||
))
|
))
|
||||||
|
@ -156,6 +167,7 @@ pub mod tests {
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
let s = AddCategoryServiceBuilder::default()
|
let s = AddCategoryServiceBuilder::default()
|
||||||
|
.db_store_id_exists(mock_store_id_exists_db_port_true(IS_CALLED_ONLY_ONCE))
|
||||||
.db_category_name_exists_for_store(mock_category_name_exists_for_store_db_port_true(
|
.db_category_name_exists_for_store(mock_category_name_exists_for_store_db_port_true(
|
||||||
IS_CALLED_ONLY_ONCE,
|
IS_CALLED_ONLY_ONCE,
|
||||||
))
|
))
|
||||||
|
@ -169,4 +181,31 @@ pub mod tests {
|
||||||
Err(InventoryError::DuplicateCategoryName)
|
Err(InventoryError::DuplicateCategoryName)
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[actix_rt::test]
|
||||||
|
async fn test_service_store_doesnt_exist() {
|
||||||
|
let name = "foo";
|
||||||
|
let description = "bar";
|
||||||
|
let user_id = UUID;
|
||||||
|
let store_id = Uuid::new_v4();
|
||||||
|
|
||||||
|
// description = None
|
||||||
|
let cmd = AddCategoryCommand::new(name.into(), Some(description.into()), store_id, user_id)
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let s = AddCategoryServiceBuilder::default()
|
||||||
|
.db_store_id_exists(mock_store_id_exists_db_port_false(IS_CALLED_ONLY_ONCE))
|
||||||
|
.db_category_name_exists_for_store(mock_category_name_exists_for_store_db_port_false(
|
||||||
|
IS_NEVER_CALLED,
|
||||||
|
))
|
||||||
|
.db_category_id_exists(mock_category_id_exists_db_port_false(IS_NEVER_CALLED))
|
||||||
|
.get_uuid(mock_get_uuid(IS_NEVER_CALLED))
|
||||||
|
.build()
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
s.add_category(cmd.clone()).await,
|
||||||
|
Err(InventoryError::StoreIDNotFound)
|
||||||
|
)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue