Check SPDX-License-Identifier (#21)

Check `SPDX-License-Identifier` in file headers.

Related to https://github.com/go-gitea/gitea/pull/21840

Co-authored-by: Jason Song <i@wolfogre.com>
Reviewed-on: https://gitea.com/gitea/gitea-vet/pulls/21
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-by: Xinyu Zhou <i@sourcehut.net>
Co-authored-by: Jason Song <wolfogre@noreply.gitea.io>
Co-committed-by: Jason Song <wolfogre@noreply.gitea.io>

.golangci.yml

@@ -1,6 +1,5 @@
 linters:
   enable:
-    - deadcode
     - dogsled
     - dupl
     - errcheck
@@ -9,15 +8,12 @@ linters:
     - gocritic
     - gocyclo
     - gofmt
-    - golint
+    - revive
     - gosimple
     - govet
-    - maligned
     - misspell
     - prealloc
     - staticcheck
-    - structcheck
     - typecheck
     - unparam
     - unused
-    - varcheck

Makefile

@@ -17,6 +17,6 @@ vet: build
 lint:
 	@hash golangci-lint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
 		export BINARY="golangci-lint"; \
-		curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(shell $(GO) env GOPATH)/bin v1.24.0; \
+		curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell $(GO) env GOPATH)/bin v1.50.1; \
 	fi
-	golangci-lint run --timeout 5m
+	golangci-lint run --timeout 5m

checks/denylisted-imports.go

@@ -1,6 +1,5 @@
 // Copyright 2022 The Gitea Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
+// SPDX-License-Identifier: MIT
-// license that can be found in the LICENSE file.
 
 package checks
 

checks/imports.go

@@ -1,6 +1,5 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
+// SPDX-License-Identifier: MIT
-// license that can be found in the LICENSE file.
 
 package checks
 

checks/license.go

@@ -1,6 +1,5 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
+// SPDX-License-Identifier: MIT
-// license that can be found in the LICENSE file.
 
 package checks
 
@@ -12,7 +11,9 @@ import (
 )
 
 var (
-	header     = regexp.MustCompile(`.*Copyright.*\d{4}.*(Gitea|Gogs)`)
+	copyrightRegx  = regexp.MustCompile(`.*Copyright.*\d{4}.*(Gitea|Gogs)`)
+	identifierRegx = regexp.MustCompile(`SPDX-License-Identifier: [\w.-]+`)
+
 	goGenerate = "//go:generate"
 	buildTag   = "// +build"
 )
@@ -58,16 +59,22 @@ func runLicense(pass *analysis.Pass) (interface{}, error) {
 			continue
 		}
 
-		var check bool
+		var copyright, identifier bool
 		for _, comment := range file.Comments[commentGroup].List {
-			if header.MatchString(comment.Text) {
+			if copyrightRegx.MatchString(comment.Text) {
-				check = true
+				copyright = true
+			}
+			if identifierRegx.MatchString(comment.Text) {
+				identifier = true
 			}
 		}
 
-		if !check {
+		if !copyright {
 			pass.Reportf(file.Pos(), "Copyright did not match check")
 		}
+		if !identifier {
+			pass.Reportf(file.Pos(), "SPDX-License-Identifier did not match check")
+		}
 	}
 	return nil, nil
 }

checks/migrations.go

@@ -1,6 +1,5 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
+// SPDX-License-Identifier: MIT
-// license that can be found in the LICENSE file.
 
 package checks
 

checks/models.go

@@ -1,6 +1,5 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
+// SPDX-License-Identifier: MIT
-// license that can be found in the LICENSE file.
 
 package checks
 

main.go

@@ -1,6 +1,5 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
-// Use of this source code is governed by a MIT-style
+// SPDX-License-Identifier: MIT
-// license that can be found in the LICENSE file.
 
 package main