Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add a note on TilesCollection and diposing of tiles

Browse source
This commit is contained in:
Danila Fedorin 2021-07-29 10:46:17 -07:00
parent 28248722a3
commit 99a630fb84
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/domain/session/room/timeline/TilesCollection.js
View file

@ -181,6 +181,8 @@ export class TilesCollection extends BaseObservableList {
} }
_replaceTile(tileIdx, existingTile, newTile, updateParams) { _replaceTile(tileIdx, existingTile, newTile, updateParams) {
// TODO What happens with a tile that's being replied to? Can we have
// reference counting of some sort?
existingTile.dispose(); existingTile.dispose();
const prevTile = this._getTileAtIdx(tileIdx - 1); const prevTile = this._getTileAtIdx(tileIdx - 1);
const nextTile = this._getTileAtIdx(tileIdx + 1); const nextTile = this._getTileAtIdx(tileIdx + 1);