From 99a630fb84707331af29bc0aa5b028433feed94e Mon Sep 17 00:00:00 2001 From: Danila Fedorin Date: Thu, 29 Jul 2021 10:46:17 -0700 Subject: [PATCH] Add a note on TilesCollection and diposing of tiles --- src/domain/session/room/timeline/TilesCollection.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/domain/session/room/timeline/TilesCollection.js b/src/domain/session/room/timeline/TilesCollection.js index 0acb2859..83d3aace 100644 --- a/src/domain/session/room/timeline/TilesCollection.js +++ b/src/domain/session/room/timeline/TilesCollection.js @@ -181,6 +181,8 @@ export class TilesCollection extends BaseObservableList { } _replaceTile(tileIdx, existingTile, newTile, updateParams) { + // TODO What happens with a tile that's being replied to? Can we have + // reference counting of some sort? existingTile.dispose(); const prevTile = this._getTileAtIdx(tileIdx - 1); const nextTile = this._getTileAtIdx(tileIdx + 1);