Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use undefined instead of null

Browse source
This commit is contained in:
RMidhunSuresh 2022-02-22 16:44:27 +05:30
parent 5be00f051f
commit 4ae3a5bf7a
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/domain/navigation/Navigation.ts
View file

@ -137,7 +137,7 @@ class Path<T> {
return new Path(this._segments.slice(), this._allowsChild); return new Path(this._segments.slice(), this._allowsChild);
} }
with(segment: Segment<T>): Path<T> | null { with(segment: Segment<T>): Path<T> | undefined {
let index = this._segments.length - 1; let index = this._segments.length - 1;
do { do {
if (this._allowsChild(this._segments[index], segment)) { if (this._allowsChild(this._segments[index], segment)) {
@ -149,7 +149,7 @@ class Path<T> {
index -= 1; index -= 1;
} while(index >= -1); } while(index >= -1);
// allow -1 as well so we check if the segment is allowed as root // allow -1 as well so we check if the segment is allowed as root
return null; return undefined;
} }
until(type: keyof T): Path<T> { until(type: keyof T): Path<T> {
@ -164,7 +164,7 @@ class Path<T> {
return this._segments.find(s => s.type === type); return this._segments.find(s => s.type === type);
} }
replace(segment: Segment<T>): Path<T> | null { replace(segment: Segment<T>): Path<T> | undefined {
const index = this._segments.findIndex(s => s.type === segment.type); const index = this._segments.findIndex(s => s.type === segment.type);
if (index !== -1) { if (index !== -1) {
const parent = this._segments[index - 1]; const parent = this._segments[index - 1];
@ -177,7 +177,7 @@ class Path<T> {
} }
} }
} }
return null; return undefined;
} }
get segments(): Segment<T>[] { get segments(): Segment<T>[] {

2
src/domain/navigation/URLRouter.ts
View file

@ -106,7 +106,7 @@ export class URLRouter<T extends {session: string}> {
} }
urlForSegments(segments: Segment<T>[]): string | undefined { urlForSegments(segments: Segment<T>[]): string | undefined {
let path: Path<T> | null = this._navigation.path; let path: Path<T> | undefined = this._navigation.path;
for (const segment of segments) { for (const segment of segments) {
path = path.with(segment); path = path.with(segment);
if (!path) { if (!path) {

4
src/domain/navigation/index.ts
View file

@ -63,8 +63,8 @@ function allowsChild(parent: Segment<SegmentType> | undefined, child: Segment<Se
} }
} }
export function removeRoomFromPath(path: Path<SegmentType>, roomId: string): Path<SegmentType> | null { export function removeRoomFromPath(path: Path<SegmentType>, roomId: string): Path<SegmentType> | undefined {
let newPath: Path<SegmentType> | null = path; let newPath: Path<SegmentType> | undefined = path;
const rooms = newPath.get("rooms"); const rooms = newPath.get("rooms");
let roomIdGridIndex = -1; let roomIdGridIndex = -1;
// first delete from rooms segment // first delete from rooms segment