From 4ae3a5bf7a05e8805de85100d8e2fb86fb6ec696 Mon Sep 17 00:00:00 2001
From: RMidhunSuresh <hi@midhun.dev>
Date: Tue, 22 Feb 2022 16:44:27 +0530
Subject: [PATCH] Use undefined instead of null

---
 src/domain/navigation/Navigation.ts | 8 ++++----
 src/domain/navigation/URLRouter.ts  | 2 +-
 src/domain/navigation/index.ts      | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/domain/navigation/Navigation.ts b/src/domain/navigation/Navigation.ts
index 6cde56c2..d6ffa3c5 100644
--- a/src/domain/navigation/Navigation.ts
+++ b/src/domain/navigation/Navigation.ts
@@ -137,7 +137,7 @@ class Path<T> {
         return new Path(this._segments.slice(), this._allowsChild);
     }
 
-    with(segment: Segment<T>): Path<T> | null {
+    with(segment: Segment<T>): Path<T> | undefined {
         let index = this._segments.length - 1;
         do {
             if (this._allowsChild(this._segments[index], segment)) {
@@ -149,7 +149,7 @@ class Path<T> {
             index -= 1;
         } while(index >= -1);
         // allow -1 as well so we check if the segment is allowed as root
-        return null;
+        return undefined;
     }
 
     until(type: keyof T): Path<T> {
@@ -164,7 +164,7 @@ class Path<T> {
         return this._segments.find(s => s.type === type);
     }
 
-    replace(segment: Segment<T>): Path<T> | null {
+    replace(segment: Segment<T>): Path<T> | undefined {
         const index = this._segments.findIndex(s => s.type === segment.type);
         if (index !== -1) {
             const parent = this._segments[index - 1];
@@ -177,7 +177,7 @@ class Path<T> {
                 }
             }
         }
-        return null;
+        return undefined;
     }
 
     get segments(): Segment<T>[] {
diff --git a/src/domain/navigation/URLRouter.ts b/src/domain/navigation/URLRouter.ts
index 2d06ca5f..31dffe58 100644
--- a/src/domain/navigation/URLRouter.ts
+++ b/src/domain/navigation/URLRouter.ts
@@ -106,7 +106,7 @@ export class URLRouter<T extends {session: string}> {
     }
 
     urlForSegments(segments: Segment<T>[]): string | undefined {
-        let path: Path<T> | null = this._navigation.path;
+        let path: Path<T> | undefined = this._navigation.path;
         for (const segment of segments) {
             path = path.with(segment);
             if (!path) {
diff --git a/src/domain/navigation/index.ts b/src/domain/navigation/index.ts
index 06920e61..f6533580 100644
--- a/src/domain/navigation/index.ts
+++ b/src/domain/navigation/index.ts
@@ -63,8 +63,8 @@ function allowsChild(parent: Segment<SegmentType> | undefined, child: Segment<Se
     }
 }
 
-export function removeRoomFromPath(path: Path<SegmentType>, roomId: string): Path<SegmentType> | null {
-    let newPath: Path<SegmentType> | null = path;
+export function removeRoomFromPath(path: Path<SegmentType>, roomId: string): Path<SegmentType> | undefined {
+    let newPath: Path<SegmentType> | undefined = path;
     const rooms = newPath.get("rooms");
     let roomIdGridIndex = -1;
     // first delete from rooms segment