Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Do not break onListChanged

Browse source 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
This commit is contained in:
RMidhunSuresh 2021-08-15 20:48:51 +05:30 committed by Bruno Windels
parent 5d54285640
commit 33ac34b04e
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/platform/web/ui/general/LazyListView.js
View file

@ -162,6 +162,7 @@ export class LazyListView extends ListView {
onAdd(idx, value) { onAdd(idx, value) {
const {topCount, renderCount, bottomCount} = this._renderRange; const {topCount, renderCount, bottomCount} = this._renderRange;
if (this._renderRange.containsIndex(idx)) { if (this._renderRange.containsIndex(idx)) {
this.onBeforeListChanged();
const normalizedIdx = this._renderRange.normalize(idx); const normalizedIdx = this._renderRange.normalize(idx);
if (bottomCount === 0) { if (bottomCount === 0) {
/* /*
@ -179,7 +180,8 @@ export class LazyListView extends ListView {
this._removeChild(this._childInstances.pop()); this._removeChild(this._childInstances.pop());
this._renderRange = new ItemRange(topCount, renderCount, bottomCount + 1); this._renderRange = new ItemRange(topCount, renderCount, bottomCount + 1);
} }
super.onAdd(normalizedIdx, value); super.onAdd(normalizedIdx, value, true);
this.onListChanged();
} }
else { else {
this._renderRange = idx < topCount ? new ItemRange(topCount + 1, renderCount, bottomCount): this._renderRange = idx < topCount ? new ItemRange(topCount + 1, renderCount, bottomCount):
@ -191,8 +193,9 @@ export class LazyListView extends ListView {
onRemove(idx, value) { onRemove(idx, value) {
const {topCount, renderCount, bottomCount} = this._renderRange; const {topCount, renderCount, bottomCount} = this._renderRange;
if (this._renderRange.containsIndex(idx)) { if (this._renderRange.containsIndex(idx)) {
this.onBeforeListChanged();
const normalizedIdx = this._renderRange.normalize(idx); const normalizedIdx = this._renderRange.normalize(idx);
super.onRemove(normalizedIdx, value); super.onRemove(normalizedIdx, value, true);
if (bottomCount === 0) { if (bottomCount === 0) {
// See onAdd for explanation // See onAdd for explanation
this._renderRange = new ItemRange(topCount, renderCount - 1, bottomCount); this._renderRange = new ItemRange(topCount, renderCount - 1, bottomCount);
@ -203,6 +206,7 @@ export class LazyListView extends ListView {
this._root.appendChild(mountView(child, this._mountArgs)); this._root.appendChild(mountView(child, this._mountArgs));
this._renderRange = new ItemRange(topCount, renderCount, bottomCount - 1); this._renderRange = new ItemRange(topCount, renderCount, bottomCount - 1);
} }
this.onListChanged();
} }
else { else {
this._renderRange = idx < topCount ? new ItemRange(topCount - 1, renderCount, bottomCount): this._renderRange = idx < topCount ? new ItemRange(topCount - 1, renderCount, bottomCount):