std::mpsc replaced with oneshot and custom builder for system

examples/simple.rs

@@ -34,8 +34,7 @@ async fn main() -> std::io::Result<()> {
         .master(master)
         .cache(cache)
         .pow(pow.clone())
-        .build()
+        .build();
-        .unwrap();
 
     // configure defense. This is a per site configuration. A site can have several levels
     // of defenses configured

src/lib.rs

@@ -82,8 +82,7 @@
 //!         .master(master)
 //!         .cache(cache)
 //!         .pow(pow.clone())
-//!         .build()
+//!         .build();
-//!         .unwrap();
 //!
 //!     // configure defense. This is a per site configuration. A site can have several levels
 //!     // of defenses configured
@@ -188,7 +187,7 @@ pub mod errors;
 pub mod master;
 
 #[cfg(feature = "full")]
-mod redis;
+pub mod redis;
 
 /// message datatypes to interact with [MCaptcha] actor
 pub mod cache;

src/master/embedded/master.rs

@@ -17,13 +17,13 @@
  */
 //! Embedded [Master] actor module that manages [Counter] actors
 use std::collections::BTreeMap;
-use std::sync::mpsc::channel;
 use std::time::Duration;
 
 //use actix::clock::sleep;
 use actix::clock::delay_for;
 use actix::dev::*;
 use log::info;
+use tokio::sync::oneshot::channel;
 
 use super::counter::Counter;
 use crate::errors::*;
@@ -181,12 +181,15 @@ impl Handler<RemoveSite> for Master {
 }
 
 impl Handler<AddSite> for Master {
-    type Result = ();
+    type Result = MessageResult<AddSite>;
 
     fn handle(&mut self, m: AddSite, _ctx: &mut Self::Context) -> Self::Result {
+        let (tx, rx) = channel();
         let counter: Counter = m.mcaptcha.into();
         let addr = counter.start();
         self.add_site(addr, m.id);
+        tx.send(Ok(())).unwrap();
+        MessageResult(rx)
     }
 }
 

src/master/mod.rs

@@ -62,10 +62,11 @@ impl AddVisitorResult {
 #[cfg(feature = "full")]
 pub mod messages {
     //! Messages that a [super::Master] should respond to
-    use std::sync::mpsc::Receiver;
+    //    use std::sync::mpsc::Receiver;
 
     use actix::dev::*;
     use derive_builder::Builder;
+    use tokio::sync::oneshot::Receiver;
 
     use crate::errors::CaptchaResult;
     use crate::mcaptcha::MCaptcha;
@@ -77,7 +78,7 @@ pub mod messages {
 
     /// Message to add an [Counter] actor to [Master]
     #[derive(Message, Builder)]
-    #[rtype(result = "()")]
+    #[rtype(result = "Receiver<CaptchaResult<()>>")]
     pub struct AddSite {
         pub id: String,
         pub mcaptcha: MCaptcha,

src/master/redis/master.rs

@@ -15,9 +15,8 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-use std::sync::mpsc;
-
 use actix::dev::*;
+use tokio::sync::oneshot;
 
 use crate::errors::*;
 use crate::master::messages::{AddSite, AddVisitor};
@@ -25,6 +24,7 @@ use crate::master::Master as MasterTrait;
 use crate::redis::mcaptcha_redis::MCaptchaRedis;
 use crate::redis::RedisConfig;
 
+#[derive(Clone)]
 pub struct Master {
     pub redis: MCaptchaRedis,
 }
@@ -47,7 +47,7 @@ impl Handler<AddVisitor> for Master {
     type Result = MessageResult<AddVisitor>;
 
     fn handle(&mut self, m: AddVisitor, ctx: &mut Self::Context) -> Self::Result {
-        let (tx, rx) = mpsc::channel();
+        let (tx, rx) = oneshot::channel();
 
         let con = self.redis.get_client();
         let fut = async move {
@@ -61,17 +61,18 @@ impl Handler<AddVisitor> for Master {
 }
 
 impl Handler<AddSite> for Master {
-    type Result = ();
+    type Result = MessageResult<AddSite>;
 
     fn handle(&mut self, m: AddSite, ctx: &mut Self::Context) -> Self::Result {
-        //let (tx, rx) = mpsc::channel();
+        let (tx, rx) = oneshot::channel();
         let con = self.redis.get_client();
         let fut = async move {
-            let _res = con.add_mcaptcha(m).await;
+            let res = con.add_mcaptcha(m).await;
-            //tx.send(res).unwrap();
+            let _ = tx.send(res);
         }
         .into_actor(self);
         ctx.wait(fut);
+        MessageResult(rx)
     }
 }
 

src/redis/mcaptcha_redis.rs

@@ -29,6 +29,7 @@ use crate::redis::RedisConfig;
 use crate::redis::RedisConnection;
 
 /// Redis instance with mCaptcha Redis module loaded
+#[derive(Clone)]
 pub struct MCaptchaRedis(Redis);
 
 /// Connection to Redis instance with mCaptcha Redis module loaded

src/redis/mod.rs

@@ -53,6 +53,7 @@ impl RedisConfig {
 }
 
 /// Redis connection - manages both single and clustered deployments
+#[derive(Clone)]
 pub enum RedisConnection {
     Single(Rc<RefCell<Connection>>),
     Cluster(Rc<RefCell<ClusterConnection>>),
@@ -86,6 +87,7 @@ pub enum RedisClient {
 
 /// A Redis Client Object that encapsulates [RedisClient] and [RedisConnection].
 /// Use this when you need a Redis Client
+#[derive(Clone)]
 pub struct Redis {
     _client: RedisClient,
     connection: RedisConnection,

src/system.rs

@@ -17,7 +17,6 @@
  */
 //! module describing mCaptcha system
 use actix::dev::*;
-use derive_builder::Builder;
 use pow_sha256::Config;
 
 use crate::cache::messages::*;
@@ -27,8 +26,48 @@ use crate::master::messages::*;
 use crate::master::Master;
 use crate::pow::*;
 
+pub struct SystemBuilder<T: Save, X: Master> {
+    pub master: Option<Addr<X>>,
+    cache: Option<Addr<T>>,
+    pow: Option<Config>,
+}
+
+impl<T: Master, S: Save> Default for SystemBuilder<S, T> {
+    fn default() -> Self {
+        Self {
+            pow: None,
+            cache: None,
+            master: None,
+        }
+    }
+}
+
+impl<T: Master, S: Save> SystemBuilder<S, T> {
+    pub fn master(mut self, m: Addr<T>) -> Self {
+        self.master = Some(m);
+        self
+    }
+
+    pub fn cache(mut self, c: Addr<S>) -> Self {
+        self.cache = Some(c);
+        self
+    }
+
+    pub fn pow(mut self, p: Config) -> Self {
+        self.pow = Some(p);
+        self
+    }
+
+    pub fn build(self) -> System<S, T> {
+        System {
+            master: self.master.unwrap(),
+            pow: self.pow.unwrap(),
+            cache: self.cache.unwrap(),
+        }
+    }
+}
+
 /// struct describing various bits of data required for an mCaptcha system
-#[derive(Clone, Builder)]
 pub struct System<T: Save, X: Master> {
     pub master: Addr<X>,
     cache: Addr<T>,
@@ -52,7 +91,7 @@ where
             .send(AddVisitor(id.clone()))
             .await
             .unwrap()
-            .recv()
+            .await
             .unwrap()
         {
             Ok(Some(mcaptcha)) => {
@@ -160,7 +199,6 @@ mod tests {
             .cache(cache)
             .pow(pow)
             .build()
-            .unwrap()
     }
 
     fn get_config() -> Config {