forgejo-federation/services/cron
Earl Warren fab73e4a3a
Actually recover from a panic in cron task (#28409)
- Currently there's code to recover gracefully from panics that happen
within the execution of cron tasks. However this recover code wasn't
being run, because `RunWithShutdownContext` also contains code to
recover from any panic and then gracefully shutdown Forgejo. Because
`RunWithShutdownContext` registers that code as last, that would get run
first which in this case is not behavior that we want.
- Move the recover code to inside the function, so that is run first
before `RunWithShutdownContext`'s recover code (which is now a noop).

Fixes: https://codeberg.org/forgejo/forgejo/issues/1910

Co-authored-by: Gusted <postmaster@gusted.xyz>
2023-12-10 20:15:06 +00:00
..
cron.go Fix data-race bug when accessing task.LastRun (#27584) 2023-10-11 14:51:20 +00:00
setting.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
tasks.go Actually recover from a panic in cron task (#28409) 2023-12-10 20:15:06 +00:00
tasks_actions.go chore(actions): support cron schedule task (#26655) 2023-08-24 03:06:51 +00:00
tasks_basic.go Artifacts retention and auto clean up (#26131) 2023-09-06 07:41:06 +00:00
tasks_extended.go Improve retrying index issues (#27554) 2023-10-15 18:56:57 +00:00
tasks_test.go Replace gogs/cron with go-co-op/gocron (#25977) 2023-07-24 04:13:41 +00:00