ddf7014b9b
The old migration had a few issues: - It left old column names around - It did not give the right access levels for owners and admins Also, this includes a migration that fixes the authorization of owner teams, which was previously ORG_ADMIN (instead of ORG_OWNER)
319 lines
8.2 KiB
Go
319 lines
8.2 KiB
Go
// Copyright 2015 The Gogs Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package migrations
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/Unknwon/com"
|
|
"github.com/go-xorm/xorm"
|
|
|
|
"github.com/gogits/gogs/modules/log"
|
|
"github.com/gogits/gogs/modules/setting"
|
|
)
|
|
|
|
const _MIN_DB_VER = 0
|
|
|
|
type Migration interface {
|
|
Description() string
|
|
Migrate(*xorm.Engine) error
|
|
}
|
|
|
|
type migration struct {
|
|
description string
|
|
migrate func(*xorm.Engine) error
|
|
}
|
|
|
|
func NewMigration(desc string, fn func(*xorm.Engine) error) Migration {
|
|
return &migration{desc, fn}
|
|
}
|
|
|
|
func (m *migration) Description() string {
|
|
return m.description
|
|
}
|
|
|
|
func (m *migration) Migrate(x *xorm.Engine) error {
|
|
return m.migrate(x)
|
|
}
|
|
|
|
// The version table. Should have only one row with id==1
|
|
type Version struct {
|
|
Id int64
|
|
Version int64
|
|
}
|
|
|
|
// This is a sequence of migrations. Add new migrations to the bottom of the list.
|
|
// If you want to "retire" a migration, remove it from the top of the list and
|
|
// update _MIN_VER_DB accordingly
|
|
var migrations = []Migration{
|
|
NewMigration("generate collaboration from access", accessToCollaboration), // V0 -> V1
|
|
NewMigration("make authorize 4 if team is owners", ownerTeamUpdate), // V1 -> V2
|
|
NewMigration("refactor access table to use id's", accessRefactor), // V2 -> V3
|
|
}
|
|
|
|
// Migrate database to current version
|
|
func Migrate(x *xorm.Engine) error {
|
|
if err := x.Sync(new(Version)); err != nil {
|
|
return fmt.Errorf("sync: %v", err)
|
|
}
|
|
|
|
currentVersion := &Version{Id: 1}
|
|
has, err := x.Get(currentVersion)
|
|
if err != nil {
|
|
return fmt.Errorf("get: %v", err)
|
|
} else if !has {
|
|
// If the user table does not exist it is a fresh installation and we
|
|
// can skip all migrations.
|
|
needsMigration, err := x.IsTableExist("user")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if needsMigration {
|
|
isEmpty, err := x.IsTableEmpty("user")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// If the user table is empty it is a fresh installation and we can
|
|
// skip all migrations.
|
|
needsMigration = !isEmpty
|
|
}
|
|
if !needsMigration {
|
|
currentVersion.Version = int64(_MIN_DB_VER + len(migrations))
|
|
}
|
|
|
|
if _, err = x.InsertOne(currentVersion); err != nil {
|
|
return fmt.Errorf("insert: %v", err)
|
|
}
|
|
}
|
|
|
|
v := currentVersion.Version
|
|
for i, m := range migrations[v-_MIN_DB_VER:] {
|
|
log.Info("Migration: %s", m.Description())
|
|
if err = m.Migrate(x); err != nil {
|
|
return fmt.Errorf("do migrate: %v", err)
|
|
}
|
|
currentVersion.Version = v + int64(i) + 1
|
|
if _, err = x.Id(1).Update(currentVersion); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func sessionRelease(sess *xorm.Session) {
|
|
if !sess.IsCommitedOrRollbacked {
|
|
sess.Rollback()
|
|
}
|
|
sess.Close()
|
|
}
|
|
|
|
func accessToCollaboration(x *xorm.Engine) (err error) {
|
|
type Collaboration struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
RepoID int64 `xorm:"UNIQUE(s) INDEX NOT NULL"`
|
|
UserID int64 `xorm:"UNIQUE(s) INDEX NOT NULL"`
|
|
Created time.Time
|
|
}
|
|
|
|
if err = x.Sync(new(Collaboration)); err != nil {
|
|
return fmt.Errorf("sync: %v", err)
|
|
}
|
|
|
|
results, err := x.Query("SELECT u.id AS `uid`, a.repo_name AS `repo`, a.mode AS `mode`, a.created as `created` FROM `access` a JOIN `user` u ON a.user_name=u.lower_name")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
sess := x.NewSession()
|
|
defer sessionRelease(sess)
|
|
if err = sess.Begin(); err != nil {
|
|
return err
|
|
}
|
|
|
|
offset := strings.Split(time.Now().String(), " ")[2]
|
|
for _, result := range results {
|
|
mode := com.StrTo(result["mode"]).MustInt64()
|
|
// Collaborators must have write access.
|
|
if mode < 2 {
|
|
continue
|
|
}
|
|
|
|
userID := com.StrTo(result["uid"]).MustInt64()
|
|
repoRefName := string(result["repo"])
|
|
|
|
var created time.Time
|
|
switch {
|
|
case setting.UseSQLite3:
|
|
created, _ = time.Parse(time.RFC3339, string(result["created"]))
|
|
case setting.UseMySQL:
|
|
created, _ = time.Parse("2006-01-02 15:04:05-0700", string(result["created"])+offset)
|
|
case setting.UsePostgreSQL:
|
|
created, _ = time.Parse("2006-01-02T15:04:05Z-0700", string(result["created"])+offset)
|
|
}
|
|
|
|
// find owner of repository
|
|
parts := strings.SplitN(repoRefName, "/", 2)
|
|
ownerName := parts[0]
|
|
repoName := parts[1]
|
|
|
|
results, err := sess.Query("SELECT u.id as `uid`, ou.uid as `memberid` FROM `user` u LEFT JOIN org_user ou ON ou.org_id=u.id WHERE u.lower_name=?", ownerName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(results) < 1 {
|
|
continue
|
|
}
|
|
|
|
ownerID := com.StrTo(results[0]["uid"]).MustInt64()
|
|
if ownerID == userID {
|
|
continue
|
|
}
|
|
|
|
// test if user is member of owning organization
|
|
isMember := false
|
|
for _, member := range results {
|
|
memberID := com.StrTo(member["memberid"]).MustInt64()
|
|
// We can skip all cases that a user is member of the owning organization
|
|
if memberID == userID {
|
|
isMember = true
|
|
}
|
|
}
|
|
if isMember {
|
|
continue
|
|
}
|
|
|
|
results, err = sess.Query("SELECT id FROM `repository` WHERE owner_id=? AND lower_name=?", ownerID, repoName)
|
|
if err != nil {
|
|
return err
|
|
} else if len(results) < 1 {
|
|
continue
|
|
}
|
|
|
|
collaboration := &Collaboration{
|
|
UserID: userID,
|
|
RepoID: com.StrTo(results[0]["id"]).MustInt64(),
|
|
}
|
|
has, err := sess.Get(collaboration)
|
|
if err != nil {
|
|
return err
|
|
} else if has {
|
|
continue
|
|
}
|
|
|
|
collaboration.Created = created
|
|
if _, err = sess.InsertOne(collaboration); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return sess.Commit()
|
|
}
|
|
|
|
func ownerTeamUpdate(x *xorm.Engine) (err error) {
|
|
if _, err := x.Exec("UPDATE team SET authorize=4 WHERE lower_name=?", "owners"); err != nil {
|
|
return fmt.Errorf("drop table: %v", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func accessRefactor(x *xorm.Engine) (err error) {
|
|
type (
|
|
AccessMode int
|
|
Access struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UserID int64 `xorm:"UNIQUE(s)"`
|
|
RepoID int64 `xorm:"UNIQUE(s)"`
|
|
Mode AccessMode
|
|
}
|
|
UserRepo struct {
|
|
UserID int64
|
|
RepoID int64
|
|
}
|
|
)
|
|
|
|
// We consiously don't start a session yet as we make only reads for now, no writes
|
|
|
|
accessMap := make(map[UserRepo]AccessMode, 50)
|
|
|
|
results, err := x.Query("SELECT r.id as `repo_id`, r.is_private as `is_private`, r.owner_id as `owner_id`, u.type as `owner_type` FROM `repository` r LEFT JOIN user u ON r.owner_id=u.id")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, repo := range results {
|
|
repoID := com.StrTo(repo["repo_id"]).MustInt64()
|
|
isPrivate := com.StrTo(repo["is_private"]).MustInt() > 0
|
|
ownerID := com.StrTo(repo["owner_id"]).MustInt64()
|
|
ownerIsOrganization := com.StrTo(repo["owner_type"]).MustInt() > 0
|
|
|
|
results, err := x.Query("SELECT user_id FROM collaboration WHERE repo_id=?", repoID)
|
|
if err != nil {
|
|
return fmt.Errorf("select repos: %v", err)
|
|
}
|
|
for _, user := range results {
|
|
userID := com.StrTo(user["user_id"]).MustInt64()
|
|
accessMap[UserRepo{userID, repoID}] = 2 // WRITE ACCESS
|
|
}
|
|
|
|
if !ownerIsOrganization {
|
|
continue
|
|
}
|
|
|
|
minAccessLevel := AccessMode(0)
|
|
if !isPrivate {
|
|
minAccessLevel = 1
|
|
}
|
|
|
|
repoString := "$" + string(repo["repo_id"]) + "|"
|
|
|
|
results, err = x.Query("SELECT id, authorize, repo_ids FROM team WHERE org_id=? AND authorize > ? ORDER BY authorize ASC", ownerID, int(minAccessLevel))
|
|
if err != nil {
|
|
return fmt.Errorf("select teams from org: %v", err)
|
|
}
|
|
|
|
for _, team := range results {
|
|
if !strings.Contains(string(team["repo_ids"]), repoString) {
|
|
continue
|
|
}
|
|
teamID := com.StrTo(team["id"]).MustInt64()
|
|
mode := AccessMode(com.StrTo(team["authorize"]).MustInt())
|
|
|
|
results, err := x.Query("SELECT uid FROM team_user WHERE team_id=?", teamID)
|
|
if err != nil {
|
|
return fmt.Errorf("select users from team: %v", err)
|
|
}
|
|
for _, user := range results {
|
|
userID := com.StrTo(user["uid"]).MustInt64()
|
|
accessMap[UserRepo{userID, repoID}] = mode
|
|
}
|
|
}
|
|
}
|
|
|
|
// Drop table can't be in a session (at least not in sqlite)
|
|
if _, err = x.Exec("DROP TABLE access"); err != nil {
|
|
return fmt.Errorf("drop table: %v", err)
|
|
}
|
|
|
|
// Now we start writing so we make a session
|
|
sess := x.NewSession()
|
|
defer sessionRelease(sess)
|
|
if err = sess.Begin(); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err = sess.Sync2(new(Access)); err != nil {
|
|
return fmt.Errorf("sync: %v", err)
|
|
}
|
|
|
|
accesses := make([]*Access, 0, len(accessMap))
|
|
for ur, mode := range accessMap {
|
|
accesses = append(accesses, &Access{UserID: ur.UserID, RepoID: ur.RepoID, Mode: mode})
|
|
}
|
|
|
|
_, err = sess.Insert(accesses)
|
|
|
|
return sess.Commit()
|
|
}
|