forgejo-federation/models/user
Gergely Nagy d4fc0d2c5a
[GITEA] Allow changing the email address before activation
During registration, one may be required to give their email address, to
be verified and activated later. However, if one makes a mistake, a
typo, they may end up with an account that cannot be activated due to
having a wrong email address.

They can still log in, but not change the email address, thus, no way to
activate it without help from an administrator.

To remedy this issue, lets allow changing the email address for logged
in, but not activated users.

This fixes gitea#17785.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit aaaece28e4c6a8980cef932e224e84933d7c9262)
(cherry picked from commit 639dafabec0a5c1f943b44ca02f72c5ba2fc5e10)
(cherry picked from commit d699c12cebea7dbbda950ae257a46d53c39f22ea)

[GITEA] Allow changing the email address before activation (squash) cache is always active

This needs to be revisited because the MailResendLimit is not enforced
and turns out to not be tested.

See e7cb8da2a8 * Always enable caches (#28527)

(cherry picked from commit 43ded8ee30ab5c7a40a456600cdaa8a0fbdccec2)

Rate limit pre-activation email change separately

Changing the email address before any email address is activated should
be subject to a different rate limit than the normal activation email
resending. If there's only one rate limit for both, then if a newly
signed up quickly discovers they gave a wrong email address, they'd have
to wait three minutes to change it.

With the two separate limits, they don't - but they'll have to wait
three minutes before they can change the email address again.

The downside of this setup is that a malicious actor can alternate
between resending and changing the email address (to something like
`user+$idx@domain`, delivered to the same inbox) to effectively halving
the rate limit. I do not think there's a better solution, and this feels
like such a small attack surface that I'd deem it acceptable.

The way the code works after this change is that `ActivatePost` will now
check the `MailChangeLimit_user` key rather than `MailResendLimit_user`,
and if we're within the limit, it will set `MailChangedJustNow_user`. The
`Activate` method - which sends the activation email, whether it is a
normal resend, or one following an email change - will check
`MailChangedJustNow_user`, and if it is set, it will check the rate
limit against `MailChangedLimit_user`, otherwise against
`MailResendLimit_user`, and then will delete the
`MailChangedJustNow_user` key from the cache.

Fixes #2040.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e35d2af2e56f4ecb3a4f6d1109d02c8aa1a6d182)
(cherry picked from commit 03989418a70d3445e0edada7fbe5a4151d7836b1)
(cherry picked from commit f50e0dfe5e90d6a31c5b59e687580e8b2725c22b)
(cherry picked from commit cad9184a3653e6c80de2e006a0d699b816980987)
(cherry picked from commit e2da5d7fe13a685606913a131687a94f9f5fcfeb)
(cherry picked from commit 3a80534d4db523efe56b368489f81dc1cb2c99f7)
2024-02-05 16:09:41 +01:00
..
avatar.go Replace -1 with GhostUserID (#27703) 2023-10-20 14:43:08 +00:00
badge.go Remove most path-based golangci exclusions (#24214) 2023-04-19 22:08:01 -04:00
email_address.go [GITEA] Allow changing the email address before activation 2024-02-05 16:09:41 +01:00
email_address_test.go [GITEA] Allow changing the email address before activation 2024-02-05 16:09:41 +01:00
error.go Unify user update methods (#28733) 2024-02-04 13:29:09 +00:00
external_login_user.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
follow.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
follow_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
list.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
must_change_password.go Add command to bulk set must-change-password (#22823) 2023-02-14 16:12:19 -06:00
openid.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
openid_test.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
redirect.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
redirect_test.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
search.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
setting.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
setting_keys.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
setting_test.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
user.go [GITEA] notifies admins on new user registration 2024-02-05 16:09:28 +01:00
user_system.go Replace -1 with GhostUserID (#27703) 2023-10-20 14:43:08 +00:00
user_test.go [GITEA] notifies admins on new user registration 2024-02-05 16:09:28 +01:00
user_update.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00