forgejo-federation/templates
wxiaoguang d4f35bd681
Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542)
This PR follows #22599 and #23450

The major improvements:

1. The `aria-*.js` are totally transparent now, no need to call
`attachDropdownAria` explicitly anymore.
* It hooks the `$.fn.checkbox` and `$.fn.dropdown`, then our patch
works.
* It makes all dynamically generated checkbox/dropdown work with a11y
without any change
* eg: the `conversation.find('.dropdown').dropdown();` in `repo-diff.js`
2. Since it's totally transparent now, it could be easier to modify or
remove in the future.
3. It handles all selection labels as well (by onLabelCreate), so it
supports "multiple selection dropdown" now.
* It partially completes one of my TODOs: `TODO: multiple selection is
not supported yet.`
4. The code structure is clearer, code blocks are splitted into
different functions.
* The old `attachOneDropdownAria` was splitted into separate functions.
* It makes it easier to add more fine tunes in the future, and co-work
with contributors.
6. The code logic is similar as before, only two new parts: 
    1. the `ariaCheckboxFn` and `ariaDropdownFn` functions
    2. the `onLabelCreate` and `updateSelectionLabel` functions

In `aria-dropdown.js` I had to mix jQuery and Vanilla JS somewhat, I
think the code is still understandable, otherwise the code would be much
more complex to read.

Thanks to fsologureng for the idea about "improving the 'delete icon'
with aria attributes".

If there is anything unclear or incorrect, feel free to ask and discuss,
or propose new PRs for it.
2023-03-22 10:52:01 +08:00
..
admin Fix .locale.Tr function not found in delete modal (#23468) 2023-03-20 20:41:57 -04:00
api/packages/pypi Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
base Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542) 2023-03-22 10:52:01 +08:00
code Fix 'View File' button in code search (#23478) 2023-03-14 22:19:27 -04:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
explore Fix long name ui issues and label ui issue (#23541) 2023-03-18 17:07:59 +01:00
mail Revert relative links to absolute links in mail templates (#23267) 2023-03-03 22:43:30 +08:00
org Replace a few fontawesome icons with svg (#23602) 2023-03-20 21:42:02 -04:00
package Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
projects Use project.IconName instead of repeated unreadable if-else chains (#23538) 2023-03-19 14:44:48 +02:00
repo Decouple the issue-template code from comment_tab.tmpl (#23556) 2023-03-21 17:04:17 -04:00
shared Display the version of runner in the runner list (#23490) 2023-03-19 22:19:40 -04:00
status Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
swagger Add absent repounits to create/edit repo API (#23500) 2023-03-16 12:30:42 -05:00
user Remove conflicting CSS rules on notifications, improve notifications table (#23565) 2023-03-21 15:11:25 -04:00
home.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
install.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
post-install.tmpl Fix various bugs for "install" page (#23194) 2023-03-04 10:12:02 +08:00