forgejo-federation/modules
mrsdizzie ca46385637 Clean up various use of escape/unescape functions for URL generation (#6334)
* Use PathUnescape instead of QueryUnescape when working with branch names

Currently branch names with a '+' fail in certain situations because
QueryUnescape replaces the + character with a blank space.

Using PathUnescape should be better since it is defined as:

// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).

Fixes #6333

* Change error to match new function name

* Add new util function PathEscapeSegments

This function simply runs PathEscape on each segment of a path without
touching the forward slash itself. We want to use this instead of
PathEscape/QueryEscape in most cases because a forward slash is a valid name for a
branch etc... and we don't want that escaped in a URL.

Putting this in new file url.go and also moving a couple similar
functions into that file as well.

* Use EscapePathSegments where appropriate

Replace various uses of EscapePath/EscapeQuery with new
EscapePathSegments. Also remove uncessary uses of various
escape/unescape functions when the text had already been escaped or was
not escaped.

* Reformat comment to make drone build happy

* Remove no longer used url library

* Requested code changes
2019-03-18 10:00:23 -04:00
..
auth Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
avatar Use assert in legacy unit tests (#867) 2017-02-08 14:29:07 +08:00
base Serve audio files using HTML5 audio tag (#5221) 2018-10-30 10:17:26 +08:00
cache Fix memcache support when value is returned as string always (#2924) 2017-11-16 15:06:34 +08:00
context Clean up various use of escape/unescape functions for URL generation (#6334) 2019-03-18 10:00:23 -04:00
cron Add branch overiew page (#2108) 2017-10-26 08:49:16 +08:00
generate Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
gzip Pooled and buffered gzip implementation (#5722) 2019-01-23 10:56:51 +02:00
highlight No highlighting for .txt files (#1922) 2017-06-09 19:39:16 -05:00
httplib Add sensitive headers (#3429) 2018-01-31 00:09:16 +02:00
indexer fix bug when set indexer as db and add tests (#6173) 2019-02-24 11:16:20 -05:00
lfs Allow markdown files to read from the LFS (#5787) 2019-02-12 15:09:43 +00:00
log Allow Macaron to be set to log through to gitea.log (#5667) 2019-02-05 22:06:41 -05:00
mailer Make log mailer for testing (#5893) 2019-02-02 21:06:52 -05:00
markup Fix reported issue in repo description (#6306) 2019-03-11 22:23:34 -04:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
minwinsvc Fix Git hooks not being executed on Windows when running as a service (#1149) 2017-03-09 09:27:43 +08:00
notification refactor issue indexer, add some testing and fix a bug (#6131) 2019-02-21 08:54:05 +08:00
options Fix typos in models/ and modules/ (#1248) 2017-03-15 08:52:01 +08:00
pprof cmd/serve: pprof cpu and memory profile dumps to disk (#4560) 2018-08-07 14:49:18 -04:00
private Clean up various use of escape/unescape functions for URL generation (#6334) 2019-03-18 10:00:23 -04:00
process Fix run command race (#1470) 2017-11-13 22:51:45 +08:00
public When redirecting clean the path to avoid redirecting to //www.othersite.com (#5669) 2019-01-09 13:39:01 -05:00
recaptcha Add Recaptcha functionality to Gitea (#4044) 2018-07-05 00:13:05 -04:00
search Global code search support (#3664) 2018-03-16 22:04:33 +08:00
secret Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
setting split setting.go to multiple files (#6154) 2019-03-16 11:12:44 +08:00
ssh use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines (#5976) 2019-02-07 02:13:12 -05:00
structs Allow to set organization visibility (public, internal, private) (#1763) 2019-02-18 18:00:27 +02:00
sync Fix status table race condition (#1835) 2017-05-31 16:57:17 +08:00
templates Create Progressive Web App (#4730) 2018-11-27 10:18:26 -05:00
test Restrict permission check on repositories and fix some problems (#5314) 2018-11-28 19:26:14 +08:00
uploader Refactor editor upload, update and delete to use git plumbing and add LFS support (#5702) 2019-02-12 15:07:31 +02:00
user Remove check for negative length (#5120) 2018-10-20 17:25:14 -04:00
util Clean up various use of escape/unescape functions for URL generation (#6334) 2019-03-18 10:00:23 -04:00
validation Improve URL validation for external wiki and external issues (#4710) 2018-08-15 09:29:37 +03:00