f8b471ace1
Fixes #28660 Fixes an admin api bug related to `user.LoginSource` Fixed `/user/emails` response not identical to GitHub api This PR unifies the user update methods. The goal is to keep the logic only at one place (having audit logs in mind). For example, do the password checks only in one method not everywhere a password is updated. After that PR is merged, the user creation should be next.
120 lines
3.6 KiB
Go
120 lines
3.6 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
|
|
system_model "code.gitea.io/gitea/models/system"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/optional"
|
|
user_service "code.gitea.io/gitea/services/user"
|
|
)
|
|
|
|
// SetEditorconfigIfExists set editor config as render variable
|
|
func SetEditorconfigIfExists(ctx *context.Context) {
|
|
if ctx.Repo.Repository.IsEmpty {
|
|
return
|
|
}
|
|
|
|
ec, _, err := ctx.Repo.GetEditorconfig()
|
|
|
|
if err != nil && !git.IsErrNotExist(err) {
|
|
description := fmt.Sprintf("Error while getting .editorconfig file: %v", err)
|
|
if err := system_model.CreateRepositoryNotice(description); err != nil {
|
|
ctx.ServerError("ErrCreatingReporitoryNotice", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
ctx.Data["Editorconfig"] = ec
|
|
}
|
|
|
|
// SetDiffViewStyle set diff style as render variable
|
|
func SetDiffViewStyle(ctx *context.Context) {
|
|
queryStyle := ctx.FormString("style")
|
|
|
|
if !ctx.IsSigned {
|
|
ctx.Data["IsSplitStyle"] = queryStyle == "split"
|
|
return
|
|
}
|
|
|
|
var (
|
|
userStyle = ctx.Doer.DiffViewStyle
|
|
style string
|
|
)
|
|
|
|
if queryStyle == "unified" || queryStyle == "split" {
|
|
style = queryStyle
|
|
} else if userStyle == "unified" || userStyle == "split" {
|
|
style = userStyle
|
|
} else {
|
|
style = "unified"
|
|
}
|
|
|
|
ctx.Data["IsSplitStyle"] = style == "split"
|
|
|
|
opts := &user_service.UpdateOptions{
|
|
DiffViewStyle: optional.Some(style),
|
|
}
|
|
if err := user_service.UpdateUser(ctx, ctx.Doer, opts); err != nil {
|
|
ctx.ServerError("UpdateUser", err)
|
|
}
|
|
}
|
|
|
|
// SetWhitespaceBehavior set whitespace behavior as render variable
|
|
func SetWhitespaceBehavior(ctx *context.Context) {
|
|
const defaultWhitespaceBehavior = "show-all"
|
|
whitespaceBehavior := ctx.FormString("whitespace")
|
|
switch whitespaceBehavior {
|
|
case "", "ignore-all", "ignore-eol", "ignore-change":
|
|
break
|
|
default:
|
|
whitespaceBehavior = defaultWhitespaceBehavior
|
|
}
|
|
if ctx.IsSigned {
|
|
userWhitespaceBehavior, err := user_model.GetUserSetting(ctx, ctx.Doer.ID, user_model.SettingsKeyDiffWhitespaceBehavior, defaultWhitespaceBehavior)
|
|
if err == nil {
|
|
if whitespaceBehavior == "" {
|
|
whitespaceBehavior = userWhitespaceBehavior
|
|
} else if whitespaceBehavior != userWhitespaceBehavior {
|
|
_ = user_model.SetUserSetting(ctx, ctx.Doer.ID, user_model.SettingsKeyDiffWhitespaceBehavior, whitespaceBehavior)
|
|
}
|
|
} // else: we can ignore the error safely
|
|
}
|
|
|
|
// these behaviors are for gitdiff.GetWhitespaceFlag
|
|
if whitespaceBehavior == "" {
|
|
ctx.Data["WhitespaceBehavior"] = defaultWhitespaceBehavior
|
|
} else {
|
|
ctx.Data["WhitespaceBehavior"] = whitespaceBehavior
|
|
}
|
|
}
|
|
|
|
// SetShowOutdatedComments set the show outdated comments option as context variable
|
|
func SetShowOutdatedComments(ctx *context.Context) {
|
|
showOutdatedCommentsValue := ctx.FormString("show-outdated")
|
|
// var showOutdatedCommentsValue string
|
|
|
|
if showOutdatedCommentsValue != "true" && showOutdatedCommentsValue != "false" {
|
|
// invalid or no value for this form string -> use default or stored user setting
|
|
if ctx.IsSigned {
|
|
showOutdatedCommentsValue, _ = user_model.GetUserSetting(ctx, ctx.Doer.ID, user_model.SettingsKeyShowOutdatedComments, "false")
|
|
} else {
|
|
// not logged in user -> use the default value
|
|
showOutdatedCommentsValue = "false"
|
|
}
|
|
} else {
|
|
// valid value -> update user setting if user is logged in
|
|
if ctx.IsSigned {
|
|
_ = user_model.SetUserSetting(ctx, ctx.Doer.ID, user_model.SettingsKeyShowOutdatedComments, showOutdatedCommentsValue)
|
|
}
|
|
}
|
|
|
|
showOutdatedComments, _ := strconv.ParseBool(showOutdatedCommentsValue)
|
|
ctx.Data["ShowOutdatedComments"] = showOutdatedComments
|
|
}
|