forgejo-federation/templates/repo/issue
sillyguodong bfecf3bd89
Fix internal sever error when visiting a PR that bound to the deleted team (#24127)
Close: #23738

The actual cause of `500 Internal Server Error` in the issue is not what
is descirbed in the issue.

The actual cause is that after deleting team, if there is a PR which has
requested reivew from the deleted team, the comment could not match with
the deleted team by `assgin_team_id`. So the value of `.AssigneeTeam`
(see below code block) is `nil` which cause `500 error`.


1c8bc4081a/templates/repo/issue/view_content/comments.tmpl (L691-L695)

To fix this bug, there are the following problems to be resolved:

- [x] 1. ~~Stroe the name of the team in `content` column when inserting
`comment` into DB in case that we cannot get the name of team after it
is deleted. But for comments that already exist, just display "Unknown
Team"~~ Just display "Ghost Team" in the comment if the assgined team is
deleted.
- [x] 2. Delete the PR&team binding (the row of which `review_team_id =
${team_id} ` in table `review`) when deleting team.
- [x] 3.For already exist and undeleted binding rows in in table
`review`, ~~we can delete these rows when executing migrations.~~ they
do not affect the function, so won't delete them.
2023-04-19 19:50:00 -04:00
..
fields Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) 2023-04-03 18:06:57 +08:00
labels Remove "inverted" class on creating new label and cancel buttons (#24030) 2023-04-10 20:00:30 +08:00
view_content Fix internal sever error when visiting a PR that bound to the deleted team (#24127) 2023-04-19 19:50:00 -04:00
branch_selector_field.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
choose.tmpl Implement Issue Config (#20956) 2023-03-28 14:22:07 -04:00
comment_tab.tmpl Improve markdown editor: width, height, preferred (#23895) 2023-04-07 13:03:29 -04:00
label_precolors.tmpl Fix purple color in suggested label colors (#18241) 2022-01-11 12:11:40 -06:00
labels.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
list.tmpl Merge template functions "dict/Dict/mergeinto" (#23932) 2023-04-07 09:39:08 -05:00
milestone_issues.tmpl Localize milestone related time strings (#24051) 2023-04-12 02:29:49 -04:00
milestone_new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
milestones.tmpl Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
navbar.tmpl Add some headings to repo views (#22869) 2023-02-12 20:20:12 +08:00
new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
new_form.tmpl Merge template functions "dict/Dict/mergeinto" (#23932) 2023-04-07 09:39:08 -05:00
openclose.tmpl Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
search.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
view.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
view_content.tmpl Group template helper functions, remove Printf, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
view_title.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00