forgejo-federation/options/locale
oliverpool b6e81357bd
Add Webhook authorization header (#20926)
_This is a different approach to #20267, I took the liberty of adapting
some parts, see below_

## Context

In some cases, a weebhook endpoint requires some kind of authentication.
The usual way is by sending a static `Authorization` header, with a
given token. For instance:

- Matrix expects a `Bearer <token>` (already implemented, by storing the
header cleartext in the metadata - which is buggy on retry #19872)
- TeamCity #18667
- Gitea instances #20267
- SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this
is my actual personal need :)

## Proposed solution

Add a dedicated encrypt column to the webhook table (instead of storing
it as meta as proposed in #20267), so that it gets available for all
present and future hook types (especially the custom ones #19307).

This would also solve the buggy matrix retry #19872.

As a first step, I would recommend focusing on the backend logic and
improve the frontend at a later stage. For now the UI is a simple
`Authorization` field (which could be later customized with `Bearer` and
`Basic` switches):


![2022-08-23-142911](https://user-images.githubusercontent.com/3864879/186162483-5b721504-eef5-4932-812e-eb96a68494cc.png)

The header name is hard-coded, since I couldn't fine any usecase
justifying otherwise.

## Questions

- What do you think of this approach? @justusbunsi @Gusted @silverwind 
- ~~How are the migrations generated? Do I have to manually create a new
file, or is there a command for that?~~
- ~~I started adding it to the API: should I complete it or should I
drop it? (I don't know how much the API is actually used)~~

## Done as well:

- add a migration for the existing matrix webhooks and remove the
`Authorization` logic there


_Closes #19872_

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: delvh <dev.lh@web.de>
2022-11-03 20:23:20 +02:00
..
locale_bg-BG.ini [skip ci] Updated translations via Crowdin 2022-10-25 00:20:58 +00:00
locale_cs-CZ.ini [skip ci] Updated translations via Crowdin 2022-11-03 00:19:50 +00:00
locale_de-DE.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_el-GR.ini [skip ci] Updated translations via Crowdin 2022-10-28 00:19:53 +00:00
locale_en-US.ini Add Webhook authorization header (#20926) 2022-11-03 20:23:20 +02:00
locale_es-ES.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_fa-IR.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_fi-FI.ini [skip ci] Updated translations via Crowdin 2022-10-25 00:20:58 +00:00
locale_fr-FR.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_hu-HU.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_id-ID.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_is-IS.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_it-IT.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_ja-JP.ini [skip ci] Updated translations via Crowdin 2022-10-31 00:19:34 +00:00
locale_ko-KR.ini [skip ci] Updated translations via Crowdin 2022-10-25 00:20:58 +00:00
locale_lv-LV.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_ml-IN.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_nl-NL.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_pl-PL.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_pt-BR.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_pt-PT.ini [skip ci] Updated translations via Crowdin 2022-11-03 00:19:50 +00:00
locale_ru-RU.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_si-LK.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_sk-SK.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_sv-SE.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_tr-TR.ini [skip ci] Updated translations via Crowdin 2022-10-27 00:21:00 +00:00
locale_uk-UA.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
locale_zh-CN.ini [skip ci] Updated translations via Crowdin 2022-11-03 00:19:50 +00:00
locale_zh-HK.ini [skip ci] Updated translations via Crowdin 2022-10-25 00:20:58 +00:00
locale_zh-TW.ini [skip ci] Updated translations via Crowdin 2022-10-26 00:20:58 +00:00
TRANSLATORS Fix missing left and right carets in TRANSLATORS (#21397) 2022-10-10 10:36:37 -04:00