forgejo-federation/services
qwerty287 9d943bf374
Add missing X-Total-Count and fix some related bugs (#17968)
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
agit Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
asymkey Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
attachment Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
auth Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 2021-12-14 16:37:11 +08:00
comments Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
cron Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
externalaccount Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 2021-12-14 16:37:11 +08:00
forms Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 2021-12-14 16:37:11 +08:00
gitdiff Make Requests Processes and create process hierarchy. Associate OpenRepository with context. (#17125) 2021-11-30 20:06:32 +00:00
issue Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
lfs Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
mailer Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
migrations Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
mirror Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
org Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
pull Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
release Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
repository Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
task Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
user Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
webhook Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
wiki Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00