realaravinth/forgejo-federation
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity
forgejo-federation/models/migrations/v1_22
History
Lunny Xiao 97c8dbf332
Fix bug hidden on CI and make ci failed if tests failure (#29254) 
The tests on migration tests failed but CI reports successfully

https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migration v283 and also the CI hidden
behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

This also fix #29602

(cherry picked from commit 45277486c2c6213b7766b1da708a991cdb1f3565)

Conflicts:
	.github/workflows/pull-db-tests.yml
	Makefile
	models/migrations/v1_22/v283.go
	models/migrations/v1_22/v286_test.go
	models/migrations/v1_22/v287_test.go
	already in Forgejo for the Makefile & CI logic but Gitea changes
	otherwise rule
2024-03-11 23:36:59 +07:00
..
main_test.go Add combined index for issue_user.uid and issue_id (#28080) 2023-12-14 09:26:59 +00:00
v280.go Rename the default themes to gitea-light, gitea-dark, gitea-auto (#27419) 2023-10-06 09:46:36 +02:00
v281.go Enhanced auth token / remember me (#27606) 2023-10-14 00:56:41 +00:00
v282.go Add Index to pull_auto_merge.doer_id (#27811) 2023-10-30 08:39:29 +00:00
v283.go Fix bug hidden on CI and make ci failed if tests failure (#29254) 2024-03-11 23:36:59 +07:00
v283_test.go Fix migration test (#28659) 2023-12-30 21:54:48 +08:00
v284.go Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
v285.go Fix incorrect action duration time when rerun the job before executed once (#28364) 2024-01-19 14:05:49 +00:00
v286.go Fix bug hidden on CI and make ci failed if tests failure (#29254) 2024-03-11 23:36:59 +07:00
v286_test.go Fix bug hidden on CI and make ci failed if tests failure (#29254) 2024-03-11 23:36:59 +07:00
v287.go Add admin API route for managing user's badges (#23106) (database migration ony) 2024-03-11 23:36:59 +07:00