forgejo-federation/templates/org
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
member Hide 2FA status from other members in organization members list (#22999) 2023-02-20 17:16:29 -06:00
projects Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
settings Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
team Add all units to the units permission list in org team members sidebar (#22971) 2023-02-20 15:08:33 +08:00
create.tmpl Remove Fomantic-UI's .hidden CSS class for checkbox elements (#22851) 2023-02-13 11:16:59 +08:00
header.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
home.tmpl Rename "People" to "Members" in organization page and use a better icon (#22960) 2023-02-18 21:41:31 +08:00
menu.tmpl Add missing tabs to org projects page (#22705) 2023-03-10 09:18:20 -06:00