- The RSS Feed icons were placed in a proper button, so that it does not look "inconsistent". This also makes the problem of the button being improperly aligned go away. - The icon that shows on user profiles has not been modified because of a lack of better implementation ideas. - Where applicable, the RSS Feed icon was put directly next to the Follow button (right menu), as both functionalities effectively share the same purpose. - Despite the attempt at achieving less inconsistency, a conscious decision to not add any text to those buttons was made, opting for tooltips instead. "Make it present, but not too annoying." - A special exception was made for the Releases pages (which contains text, not a tooltip), where an RSS feed would be particularly beneficial to users. The fact that the RSS functionality is explicitly optional was taken into account, and these improvements were made with public-facing instances (where the feature works best) in mind.
29 lines
1.3 KiB
Handlebars
29 lines
1.3 KiB
Handlebars
{{$canReadReleases := $.Permission.CanRead $.UnitTypeReleases}}
|
|
{{$canReadCode := $.Permission.CanRead $.UnitTypeCode}}
|
|
|
|
{{if $canReadReleases}}
|
|
<div class="gt-df">
|
|
<div class="gt-f1 gt-df gt-ac">
|
|
<h2 class="ui compact small menu header small-menu-items">
|
|
<a class="{{if .PageIsReleaseList}}active {{end}}item" href="{{.RepoLink}}/releases">{{ctx.Locale.PrettyNumber .NumReleases}} {{ctx.Locale.TrN .NumReleases "repo.release" "repo.releases"}}</a>
|
|
{{if $canReadCode}}
|
|
<a class="{{if .PageIsTagList}}active {{end}}item" href="{{.RepoLink}}/tags">{{ctx.Locale.PrettyNumber .NumTags}} {{ctx.Locale.TrN .NumTags "repo.tag" "repo.tags"}}</a>
|
|
{{end}}
|
|
</h2>
|
|
</div>
|
|
{{if .EnableFeed}}
|
|
<a class="ui small button" href="{{.RepoLink}}/{{if .PageIsTagList}}tags{{else}}releases{{end}}.rss">
|
|
{{svg "octicon-rss" 18}} {{ctx.Locale.Tr "rss_feed"}}
|
|
</a>
|
|
{{end}}
|
|
{{if and (not .PageIsTagList) .CanCreateRelease}}
|
|
<a class="ui small primary button" href="{{$.RepoLink}}/releases/new">
|
|
{{ctx.Locale.Tr "repo.release.new_release"}}
|
|
</a>
|
|
{{end}}
|
|
</div>
|
|
<div class="divider"></div>
|
|
{{else if $canReadCode}}
|
|
{{/* if the "repo.releases" unit is disabled, only show the "commits / branches / tags" sub menu */}}
|
|
{{template "repo/sub_menu" .}}
|
|
{{end}}
|