forgejo-federation/templates/base
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
alert.tmpl Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
alert_details.tmpl Enforce tab indentation in templates (#15289) 2021-04-10 23:46:37 -04:00
delete_modal_actions.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
disable_form_autofill.tmpl Disable form autofill (#17291) 2021-10-19 01:08:41 +03:00
footer.tmpl Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
footer_content.tmpl Improve accessibility of navigation bar and footer (#22635) 2023-01-29 09:29:10 +08:00
head.tmpl Fix various bugs for "install" page (#23194) 2023-03-04 10:12:02 +08:00
head_navbar.tmpl Add accessibility to the menu on the navbar (#23059) 2023-02-22 15:58:07 -06:00
head_script.tmpl Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 2023-02-17 22:02:20 +08:00
paginate.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00