ebe569a268
* Set correct PR status on 3way on conflict checking - When 3-way merge is enabled for conflict checking, it has a new interesting behavior that it doesn't return any error when it found a conflict, so we change the condition to not check for the error, but instead check if conflictedfiles is populated, this fixes a issue whereby PR status wasn't correctly on conflicted PR's. - Refactor the mergeable property(which was incorrectly set and lead me this bug) to be more maintainable. - Add a dedicated test for conflicting checking, so it should prevent future issues with this. * Fix linter |
||
---|---|---|
.. | ||
convert.go | ||
git_commit.go | ||
git_commit_test.go | ||
issue.go | ||
issue_comment.go | ||
issue_test.go | ||
main_test.go | ||
notification.go | ||
package.go | ||
pull.go | ||
pull_review.go | ||
pull_test.go | ||
release.go | ||
repository.go | ||
status.go | ||
user.go | ||
user_test.go | ||
utils.go | ||
utils_test.go | ||
wiki.go |