forgejo-federation/templates
Earl Warren 603a44edf0
[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
Refs: https://codeberg.org/forgejo/forgejo/issues/2109
(cherry picked from commit 8b4ba3dce7fc99fa328444ef27383dccca49c237)
(cherry picked from commit 196edea0f972a9a027c4cacb9df36330cf676d2f)

[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review

If a comment already exists in a review, the comment is added. If it
is the first comment added to a review, it will implicitly create a
new review instead of adding to the existing one.

The pull_service.CreateCodeComment function is responsibe for this
behavior and it will defer to createCodeComment once the review is
determined, either because it was found or because it was created.

Rename createCodeComment into CreateCodeCommentKnownReviewID to expose
it and change the API endpoint to use it instead. Since the review is
provided by the user and verified to exist already, there is no need
for the logic implemented by CreateCodeComment.

The tests are modified to remove the initial comment from the fixture
because it was creating the false positive. I was verified to fail
without this fix.

(cherry picked from commit 6a555996dca6ba71c65818e14ab0eeafa1af6dc2)
(cherry picked from commit b173a0ccee6cc0dadf40ec55e5d88987314c1cc4)
(cherry picked from commit 838ab9740a6b022676103bcb3a7d168b501006e1)
2024-02-05 16:09:42 +01:00
..
admin [GITEA] add option for banning dots in usernames 2024-02-05 16:05:50 +01:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base [GITEA] Improve HTML title on repositories 2024-02-05 16:05:50 +01:00
code Fix 500 error of searching commits (#28576) 2023-12-21 23:09:14 +00:00
custom [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
devtest Improve CSS helper naming (#28769) 2024-01-12 20:28:01 +08:00
explore Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
mail [GITEA] notifies admins on new user registration 2024-02-05 16:09:28 +01:00
org Fix button size in "attached header right" (#28770) 2024-01-12 14:43:40 +00:00
package [GITEA] fix indentation in Maven package install instructions 2024-02-05 16:09:40 +01:00
projects Use full width for project boards (#28225) 2023-11-27 17:43:52 +00:00
repo [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
shared Introduce htmx and use it to avoid full page load on Subscribe and Follow (#28908) 2024-01-30 15:45:54 +01:00
status [GITEA] Improve 404 screen on mobile 2024-02-05 16:09:42 +01:00
swagger [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments 2024-02-05 16:09:42 +01:00
user [GITEA] Allow changing the email address before activation 2024-02-05 16:09:41 +01:00
webhook Extract common code to new template (#26933) 2023-09-06 10:11:06 +00:00
home.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
install.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
post-install.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00