Nanguan Lin
9b59af37e7
Fix issue dependencies ( #27736 )
...
Fix #27722
Fix #27357
Fix #25837
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.
2024-01-12 16:49:02 +00:00
Denys Konovalov
4f8f5f6e25
Assign pull request to project during creation ( #28227 )
...
When creating a pull request, allow directly assigning it to a project,
as it is already possible for issues.
After:
2024-01-12 15:25:15 +00:00
wxiaoguang
ad0b637d46
Fix button size in "attached header right" ( #28770 )
...
Before:
<details>
</details>
After:
2024-01-12 14:43:40 +00:00
wxiaoguang
34a0684397
Improve CSS helper naming ( #28769 )
...
* `gt-w-100` => `gt-w-full` to match tailwind
* clarify `gt-hidden` priority
2024-01-12 20:28:01 +08:00
Denys Konovalov
7d62615513
Revamp repo header ( #27760 )
...
Redesign repo header with following new aspects:
- responsive & better-looking repo title
- hide repo button text instead of icons in mobile view
- use same tab style as on explore and org page
<details>
<summary>Before:</summary>
</details>
<details>
<summary>After:</summary>
2024-01-12 03:44:06 +00:00
Exploding Dragon
ba4d0b8ffb
Support for grouping RPMs using paths ( #26984 )
...
The current rpm repository places all packages in the same repository,
and different systems (el7,f34) may hit packages that do not belong to
this distribution ( #25304 ) , which now supports grouping of rpm.
Fixes #25304 .
Fixes #27056 .
Refactor: [#25866 ](https://github.com/go-gitea/gitea/pull/25866 )
2024-01-12 03:16:05 +00:00
Jack Hay
7c2f093e85
Require token for GET subscription endpoint ( #28765 )
...
Fixes #28756
## Changes
- Require and check API token for `GET
/repos/{owner}/{repo}/subscription` in order to populate `ctx.Doer`.
2024-01-12 01:57:58 +00:00
KN4CK3R
595a9291b6
Fix convert.ToTeams on empty input ( #28426 )
...
Fixes #28420
Don't return `nil` if the input was empty.
2024-01-11 22:12:08 +00:00
delvh
abfdaef5bd
Show description as tooltip instead of title for labels ( #28754 )
...
Follow GitHubs behavior of showing the label description as a tooltip
instead of the browser native title.
## Before
## After
2024-01-12 00:21:52 +08:00
Mihir Joshi
669bbbaf24
Integration Test for Commit Search containing Square Brackets ( #28751 )
...
Integration test for #28744
Change keywords commit search flag from `-F` to `--fixed-strings` for
readability
2024-01-11 11:04:45 +08:00
Lunny Xiao
c65f8623e6
Hide code related setting options in repository when code unit is disabled ( #28631 )
...
Since #20805 , code can be hidden.
However, the related settings are still shown even though they don't
have any meaning then.
https://github.com/go-gitea/gitea/assets/81045/5fdee54d-ac81-418a-82f7-eadff048cedd
2024-01-10 11:55:59 +00:00
Mihir Joshi
839cd26b1a
Add -F to commit search to treat keywords as strings ( #28744 )
...
Fixes #28269
The [default
behavior](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp )
of --grep in git log is to interpret the keyword as a regular
expression. This causes the search to fail in the cases where the search
keyword contains a `[`, since `[` is a special character used in grep.
If we want our keywords to be interpreted as 'strings', we should use
[-F
flag](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp ).
2024-01-10 11:28:20 +00:00
wxiaoguang
2df7563f31
Recommend/convert to use case-sensitive collation for MySQL/MSSQL ( #28662 )
...
Mainly for MySQL/MSSQL.
It is important for Gitea to use case-sensitive database charset
collation. If the database is using a case-insensitive collation, Gitea
will show startup error/warning messages, and show the errors/warnings
on the admin panel's Self-Check page.
Make `gitea doctor convert` work for MySQL to convert the collations of
database & tables & columns.
* Fix #28131
## ⚠️ BREAKING ⚠️
It is not quite breaking, but it's highly recommended to convert the
database&table&column to a consistent and case-sensitive collation.
2024-01-10 11:03:23 +00:00
JakobDev
a80debc208
Add download attribute to release attachments ( #28739 )
...
Fixes #28736
2024-01-09 16:51:20 +08:00
Earl Warren
aa4d78431f
Concatenate error in checkIfPRContentChanged ( #28731 )
...
- If there's a error with the Git command in `checkIfPRContentChanged`
the stderr wasn't concatendated to the error, which results in still not
knowing why an error happend.
- Adds concatenation for stderr to the returned error.
- Ref: https://codeberg.org/forgejo/forgejo/issues/2077
Co-authored-by: Gusted <postmaster@gusted.xyz>
2024-01-09 10:32:14 +08:00
GiteaBot
f4ea8d9a6c
[skip ci] Updated licenses and gitignores
2024-01-08 00:26:06 +00:00
wxiaoguang
a04f8c0f81
Move the captcha script loader to the template which really needs it ( #28718 )
...
It improves the maintainability for the templates.
Now `base/footer.tmpl` doesn't need to depend on "captcha" feature.
2024-01-07 15:41:46 +00:00
wxiaoguang
79da4bbc56
Suggest to use Type=simple for systemd service ( #28717 )
...
Although the systemd notify support was added, it seems that there are
some problems (#28553 , for the "non-installed" instance)
2024-01-07 15:18:04 +00:00
wxiaoguang
9296c31ff7
Fix incorrect URL for "Reference in New Issue" ( #28716 )
...
Gitea prefers to use relative URLs in code (to make multiple domain work
for some users)
So it needs to use `toAbsoluteUrl` to generate a full URL when click
"Reference in New Issues"
And add some comments in the test code
2024-01-07 10:50:03 +00:00
wxiaoguang
c5901b622d
Avoid unnecessary 500 panic when a commit doesn't exist ( #28719 )
...
In #26851 , it assumed that `Commit` always exists when
`PageIsDiff==true`.
But for a 404 page, the `Commit` doesn't exist, so the following code
would cause panic because nil value can't be passed as string parameter
to `IsMultilineCommitMessage(string)` (or the StringUtils.Cut in later
PRs)
2024-01-07 18:20:22 +08:00
GiteaBot
a43c7b81af
[skip ci] Updated translations via Crowdin
2024-01-07 00:27:22 +00:00
wxiaoguang
7215224112
Improve frontend guideline ( #28711 )
...
It has been a consensus for long time during reviewing: "avoiding inline
styles as much as possible".
2024-01-07 01:14:10 +08:00
wxiaoguang
e75e9a0e7e
Fix panic when parsing empty pgsql host ( #28708 )
...
Regression of #27723
Fix #28705
2024-01-06 17:30:03 +08:00
Kyle D
e522e774ca
Add merge arrow direction and update styling ( #28523 )
...
Close https://github.com/go-gitea/gitea/issues/28522
~Adds some [negative
margin](https://tailwindcss.com/docs/margin#using-negative-values )
helper css classes using tailwind's [prefix
syntax](https://tailwindcss.com/docs/configuration#prefix )~
### Before
### After
2024-01-05 17:38:56 +00:00
yp05327
dd5693387e
Add links to owner home page in explore ( #28341 )
...
User can select access repo or owner's home page.
Before:
After:
2024-01-05 03:34:35 +00:00
Earl Warren
92711b001e
Apply min-height in wiki only on preview pane ( #28687 )
...
In the commit 5a56f9699chttps://codeberg.org/forgejo/forgejo/pulls/2080
(cherry picked from commit 8f0baefe5dadc929fe7456c36c8b205e96f228f0)
Co-authored-by: Fl1tzi <git@fl1tzi.com>
2024-01-04 02:48:55 +00:00
Kyle D
54acf7b0d4
Normalize oauth email username ( #28561 )
2024-01-03 18:48:20 -06:00
Denys Konovalov
657b23d635
Fix wrapping of label list ( #28684 )
...
The label list needs to wrap the items to avoid unnecessary overflow / incorrect text wrapping.
2024-01-03 20:33:55 +08:00
wackbyte
9b418158b9
Fix grammar in actions.variables.id_not_exist (en-US) ( #28680 )
...
Fixes the capitalization and grammar of the key.
2024-01-03 10:43:38 +00:00
wackbyte
3ba1216b9d
Fix grammar issues on the repository Actions page (en-US) ( #28679 )
...
Fixes a few grammar issues in the en-US localization of the repository
Actions page.
2024-01-03 10:42:56 +00:00
wackbyte
361839fb1c
Fix tooltip of variable edit button ( #28681 )
...
The `variables.edit` key does not exist.
2024-01-03 06:25:19 +00:00
Brecht Van Lommel
12c0487e01
Make cross-reference issue links work in markdown documents again ( #28682 )
...
In #26365 issue references were disabled entirely for documents,
intending to match GitHub behavior. However cross-references do appear
to work in documents on GitHub.
This is useful for example to write release notes in a markdown document
and reference issues. While the simpler syntax may create links when not
intended, hopefully the cross-reference syntax is unique enough to avoid
it.
2024-01-03 14:01:12 +08:00
wxiaoguang
91aa263225
Make template DateTime show proper tooltip ( #28677 )
...
There was a question about "how to improve the datetime display for
SSH/PGP/WebAuthn"
https://github.com/go-gitea/gitea/pull/28262#issuecomment-1831141611
The root problem is that `DateTime` misses the "data-tooltip-content"
attribute, which should be used to make the tooltip popup smoothly.
Now the UI is consistent and the end users could see the detailed
hour/minute/second easily by hovering the element.
2024-01-02 20:09:18 +01:00
Yarden Shoham
cdc33b29a0
Add global setting how timestamps should be rendered ( #28657 )
...
- Resolves https://github.com/go-gitea/gitea/issues/22493
- Related to https://github.com/go-gitea/gitea/issues/4520
Some admins prefer all timestamps to display the full date instead of
relative time. They can do that now by setting
```ini
[ui]
PREFERRED_TIMESTAMP_TENSE = absolute
```
This setting is set to `mixed` by default, allowing dates to render as
"5 hours ago". Here are some screenshots of the UI with this setting set
to `absolute`:
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: delvh <dev.lh@web.de>
2024-01-02 09:25:30 +08:00
GiteaBot
f8f394cb0e
[skip ci] Updated translations via Crowdin
2024-01-01 00:27:55 +00:00
Lunny Xiao
da58bb85fa
Upgrade xorm to new version which supported update join for all supported databases ( #28590 )
...
Fix https://github.com/go-gitea/gitea/pull/28547#issuecomment-1867740842
Since https://gitea.com/xorm/xorm/pulls/2383 merged, xorm now supports
UPDATE JOIN.
To keep consistent from different databases, xorm use
`engine.Join().Update`, but the actural generated SQL are different
between different databases.
For MySQL, it's `UPDATE talbe1 JOIN table2 ON join_conditions SET xxx
Where xxx`.
For MSSQL, it's `UPDATE table1 SET xxx FROM TABLE1, TABLE2 WHERE
join_conditions`.
For SQLITE per https://www.sqlite.org/lang_update.html , sqlite support
`UPDATE table1 SET xxx FROM table2 WHERE join conditions` from
3.33.0(2020-8-14).
POSTGRES is the same as SQLITE.
2023-12-31 05:00:35 +00:00
vincent
f8a1bad883
Fix: system webhooks API bug ( #28531 )
...
- Fix the bug about admin/hooks API that `GET /admin/hooks` can only
fetch system_hooks, `POST /admin/hooks` can only create default_hooks.
2023-12-31 04:31:50 +00:00
Nanguan Lin
b6e0957b9c
Fix alpine package files are not rebuilt ( #28638 )
...
I noticed the `BuildAllRepositoryFiles` function under the Alpine folder
is unused and I thought it was a bug.
But I'm not sure about this. Was it on purpose?
2023-12-31 12:08:46 +08:00
Lunny Xiao
cb10f2767c
Fix migration test ( #28659 )
2023-12-30 21:54:48 +08:00
wxiaoguang
e5d8c4b8d4
Avoid cycle-redirecting user/login page ( #28636 )
...
Fix #28231 , and remove some unused code. The `db.HasEngine` doesn't seem
useful because the db engine is always initialized before web route.
2023-12-30 08:48:34 +00:00
Mihir Joshi
3d474110c1
Fix long package version names overflowing ( #28619 )
...
Fixes #28534
---
Before:
After:
<img width="304" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/53d04ad0-6d5c-47e2-8a7d-30a4d5dd9959 ">
Should we also apply this for long filenames in Assets?
It looks like this currently:
<img width="285" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/e2dcbb2e-30d5-4e35-b304-6274ef60bda7 ">
---------
Co-authored-by: Mihir <mihir.joshi@senpiper.com>
2023-12-30 07:42:16 +00:00
silverwind
ce55a74374
Update JS dependencies ( #28537 )
...
- Update all JS dependencies excluding mcaptcha (breaking changes) and
stylelint (plugin not compatible with v16)
- Regenerate SVGs
- Update markdownlint rule names
- Fix one issue of heading in markdown discovered during lint
- Update for monaco options renames
- Fix stylelint rule length-zero-no-unit for custom properties
- Tested editor, swagger, sorting, vue, lint
2023-12-30 05:29:03 +00:00
wxiaoguang
19b1b698c9
Improve document for ARTIFACT_RETENTION_DAYS ( #28646 )
...
Follow #28626
2023-12-29 06:44:58 +00:00
Denys Konovalov
f10d716ff4
fix empty ref for cron workflow runs ( #28640 )
...
Fix #27678
Please see
https://github.com/go-gitea/gitea/issues/27678#issuecomment-1871445853
for details.
2023-12-29 06:18:57 +00:00
wxiaoguang
19c45dd479
Improve 1.22 document for Database Preparation ( #28643 )
...
Fix #28247
2023-12-29 05:42:22 +00:00
GiteaBot
4995b4a057
[skip ci] Updated translations via Crowdin
2023-12-29 00:20:25 +00:00
Denys Konovalov
6c133b9fe0
switch destination directory for apt signing keys ( #28639 )
...
According to [Debian
docs](https://wiki.debian.org/DebianRepository/UseThirdParty ):
> The certificate MUST NOT be placed in /etc/apt/trusted.gpg.d or loaded
by apt-key add.
> ...
> If future updates to the certificate will be managed by an apt/dpkg
package as recommended below, then it SHOULD be downloaded into
/usr/share/keyrings using the same filename that will be provided by the
package. If it will be managed locally , it SHOULD be downloaded into
/etc/apt/keyrings instead.
> ...
> A sources.list entry SHOULD have the signed-by option set.
2023-12-28 22:08:59 +01:00
Gerd Katzenbeisser
4d1277c0cb
Extend description for ARTIFACT_RETENTION_DAYS ( #28626 )
...
Make it clear that this value is just a default value and that every
artifact can have it's own value.
2023-12-28 10:11:44 +00:00
wxiaoguang
e743570f65
Refactor timeutil package ( #28623 )
...
1. make names more readable
2. remove unused FormatLong/FormatShort
3. use `FormatDate` instead of `Format "2006-01-02"`
2023-12-28 10:09:57 +00:00
wxiaoguang
f3999888c0
Refactor some legacy code and remove unused code ( #28622 )
...
1. use slices.Contains, remove Int64sContains
2. use HashEmail, remove base.EncodeMD5
3. remove BasicAuthEncode, IsLetter
2023-12-28 09:38:59 +00:00
