diff --git a/templates/repo/issue/view_content/comments.tmpl b/templates/repo/issue/view_content/comments.tmpl
index 9e50ee4d9..a4fd97297 100644
--- a/templates/repo/issue/view_content/comments.tmpl
+++ b/templates/repo/issue/view_content/comments.tmpl
@@ -619,7 +619,7 @@
{{else}}
{{$reviewerName = .Review.OriginalAuthor}}
{{end}}
- {{ctx.Locale.Tr "repo.issues.review.dismissed" $reviewerName $createdStr | Safe}}
+ {{ctx.Locale.Tr "repo.issues.review.dismissed" $reviewerName $createdStr | Safe}}
{{if .Content}}
diff --git a/tests/integration/fixtures/TestXSSReviewDismissed/comment.yml b/tests/integration/fixtures/TestXSSReviewDismissed/comment.yml
new file mode 100644
index 000000000..50162a4e7
--- /dev/null
+++ b/tests/integration/fixtures/TestXSSReviewDismissed/comment.yml
@@ -0,0 +1,9 @@
+-
+ id: 1000
+ type: 32 # dismiss review
+ poster_id: 2
+ issue_id: 2 # in repo_id 1
+ content: "XSS time!"
+ review_id: 1000
+ created_unix: 1700000000
+ updated_unix: 1700000000
diff --git a/tests/integration/fixtures/TestXSSReviewDismissed/review.yml b/tests/integration/fixtures/TestXSSReviewDismissed/review.yml
new file mode 100644
index 000000000..56bc08d35
--- /dev/null
+++ b/tests/integration/fixtures/TestXSSReviewDismissed/review.yml
@@ -0,0 +1,8 @@
+-
+ id: 1000
+ type: 1
+ issue_id: 2
+ original_author: "Otto "
+ content: "XSS time!"
+ updated_unix: 1700000000
+ created_unix: 1700000000
diff --git a/tests/integration/xss_test.go b/tests/integration/xss_test.go
index e575ed399..acd716c7c 100644
--- a/tests/integration/xss_test.go
+++ b/tests/integration/xss_test.go
@@ -4,14 +4,25 @@
package integration
import (
+ "context"
+ "fmt"
"net/http"
+ "net/url"
+ "os"
+ "path/filepath"
"testing"
+ "time"
+ issues_model "code.gitea.io/gitea/models/issues"
"code.gitea.io/gitea/models/unittest"
user_model "code.gitea.io/gitea/models/user"
+ "code.gitea.io/gitea/modules/git"
"code.gitea.io/gitea/tests"
+ gogit "github.com/go-git/go-git/v5"
+ "github.com/go-git/go-git/v5/plumbing/object"
"github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
)
func TestXSSUserFullName(t *testing.T) {
@@ -37,3 +48,82 @@ func TestXSSUserFullName(t *testing.T) {
htmlDoc.doc.Find("div.content").Find(".header.text.center").Text(),
)
}
+
+func TestXSSWikiLastCommitInfo(t *testing.T) {
+ onGiteaRun(t, func(t *testing.T, u *url.URL) {
+ // Prepare the environment.
+ dstPath := t.TempDir()
+ r := fmt.Sprintf("%suser2/repo1.wiki.git", u.String())
+ u, err := url.Parse(r)
+ assert.NoError(t, err)
+ u.User = url.UserPassword("user2", userPassword)
+ assert.NoError(t, git.CloneWithArgs(context.Background(), git.AllowLFSFiltersArgs(), u.String(), dstPath, git.CloneRepoOptions{}))
+
+ // Use go-git here, because using git wouldn't work, it has code to remove
+ // `<`, `>` and `\n` in user names. Even though this is permitted and
+ // wouldn't result in a error by a Git server.
+ gitRepo, err := gogit.PlainOpen(dstPath)
+ require.NoError(t, err)
+
+ w, err := gitRepo.Worktree()
+ require.NoError(t, err)
+
+ filename := filepath.Join(dstPath, "Home.md")
+ err = os.WriteFile(filename, []byte("Oh, a XSS attack?"), 0o644)
+ require.NoError(t, err)
+
+ _, err = w.Add("Home.md")
+ require.NoError(t, err)
+
+ _, err = w.Commit("Yay XSS", &gogit.CommitOptions{
+ Author: &object.Signature{
+ Name: `Gusted`,
+ Email: "valid@example.org",
+ When: time.Date(2024, time.January, 31, 0, 0, 0, 0, time.UTC),
+ },
+ })
+ require.NoError(t, err)
+
+ // Push.
+ _, _, err = git.NewCommand(git.DefaultContext, "push").AddArguments(git.ToTrustedCmdArgs([]string{"origin", "master"})...).RunStdString(&git.RunOpts{Dir: dstPath})
+ require.NoError(t, err)
+
+ // Check on page view.
+ t.Run("Page view", func(t *testing.T) {
+ defer tests.PrintCurrentTest(t)()
+
+ req := NewRequest(t, http.MethodGet, "/user2/repo1/wiki/Home")
+ resp := MakeRequest(t, req, http.StatusOK)
+ htmlDoc := NewHTMLParser(t, resp.Body)
+
+ htmlDoc.AssertElement(t, "script.evil", false)
+ assert.Contains(t, htmlDoc.Find(".ui.sub.header").Text(), `Gusted edited this page 2024-01-31`)
+ })
+
+ // Check on revisions page.
+ t.Run("Revision page", func(t *testing.T) {
+ defer tests.PrintCurrentTest(t)()
+
+ req := NewRequest(t, http.MethodGet, "/user2/repo1/wiki/Home?action=_revision")
+ resp := MakeRequest(t, req, http.StatusOK)
+ htmlDoc := NewHTMLParser(t, resp.Body)
+
+ htmlDoc.AssertElement(t, "script.evil", false)
+ assert.Contains(t, htmlDoc.Find(".ui.sub.header").Text(), `Gusted edited this page 2024-01-31`)
+ })
+ })
+}
+
+func TestXSSReviewDismissed(t *testing.T) {
+ defer tests.AddFixtures("tests/integration/fixtures/TestXSSReviewDismissed/")()
+ defer tests.PrepareTestEnv(t)()
+
+ review := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 1000})
+
+ req := NewRequest(t, http.MethodGet, fmt.Sprintf("/user2/repo1/pulls/%d", +review.IssueID))
+ resp := MakeRequest(t, req, http.StatusOK)
+ htmlDoc := NewHTMLParser(t, resp.Body)
+
+ htmlDoc.AssertElement(t, "script.evil", false)
+ assert.Contains(t, htmlDoc.Find("#issuecomment-1000 .dismissed-message").Text(), `dismissed Otto ’s review`)
+}