realaravinth/forgejo-federation
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity

fix: {show,link to} proper PR on kanban board ref (#15004)

Browse source 
the issue was that PR references in kanban boards were being generated
using `.ID` instead of `.Index`, which led to constructing incorrect
links to possibly non-existent {PR,issue}s and following that to showing
nonsensical values in the boards.

kudos also go to @zeripath for pointing at the file to fix.

Signed-off-by: wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf <a_mirre@utb.cz>
Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf 2021-03-16 16:42:25 +01:00 committed by GitHub
parent ab70b2f4e4
commit d2dc182dcd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
templates/repo/projects/view.tmpl
View file

@ -175,9 +175,9 @@
{{- end }} {{- end }}
{{- range index $.LinkedPRs .ID }} {{- range index $.LinkedPRs .ID }}
<div class="meta"> <div class="meta">
<a href="{{$.RepoLink}}/pulls/{{ .ID }}"> <a href="{{$.RepoLink}}/pulls/{{ .Index }}">
<span class="{{if .PullRequest.HasMerged}}purple{{else if .IsClosed}}red{{else}}green{{end}}">{{svg "octicon-git-merge"}}</span> <span class="{{if .PullRequest.HasMerged}}purple{{else if .IsClosed}}red{{else}}green{{end}}">{{svg "octicon-git-merge"}}</span>
{{ .Title}} (#{{ .ID }}) {{ .Title}} (#{{ .Index }})
</a> </a>
</div> </div>
{{- end }} {{- end }}