From c86be819bb0d407c3e530bafd31b18cdd0be1116 Mon Sep 17 00:00:00 2001 From: Jason Song Date: Thu, 12 Jan 2023 23:35:53 +0800 Subject: [PATCH] Add more packages to denylist (#22412) After this, we can remove [`denylist_imports`](https://gitea.com/gitea/gitea-vet/src/branch/master/checks/denylisted-imports.go#L13) in gitea-vet ([gitea-vet/pulls/23](https://gitea.com/gitea/gitea-vet/pulls/23)). ```go deniedImports = []string{"io/ioutil", "encoding/json", "gitea.com/gitea/go-crypto"} ``` However, we needn't keep `gitea.com/gitea/go-crypto` any longer, it's gone and can't be imported again. Co-authored-by: John Olheiser --- .golangci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 130ad286b..7635e83a3 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -76,13 +76,14 @@ linters-settings: extra-rules: true lang-version: "1.19" depguard: - # TODO: use depguard to replace import checks in gitea-vet list-type: denylist # Check the list against standard lib. include-go-root: true packages-with-error-message: - encoding/json: "use gitea's modules/json instead of encoding/json" - github.com/unknwon/com: "use gitea's util and replacements" + - io/ioutil: "use os or io instead" + - golang.org/x/exp: "it's experimental and unreliable." issues: max-issues-per-linter: 0