From bfab129fb97479e2efaaa0ece7071e13d79629ed Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Mon, 19 Jun 2023 01:33:12 +0800 Subject: [PATCH] Fix label list divider (#25312) We only needs 2 lines to hide the dividers. ``` $dropdownLabelFilter.dropdown('setting', {'hideDividers': 'empty'}); $dropdownLabelFilter.dropdown('refreshItems'); ``` Other code blocks are refactored by the way. ![image](https://github.com/go-gitea/gitea/assets/2114189/74989996-fcea-4df4-b534-b06f7957939a) ![image](https://github.com/go-gitea/gitea/assets/2114189/ee3b3761-b96e-4fb5-b646-e9d3117e5f40) --- templates/repo/issue/list.tmpl | 3 ++- web_src/css/repo.css | 1 - web_src/js/features/repo-issue.js | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl index 313f7d6e9..5c9a5937a 100644 --- a/templates/repo/issue/list.tmpl +++ b/templates/repo/issue/list.tmpl @@ -102,12 +102,13 @@ {{.locale.Tr "repo.issues.filter_label_exclude" | Safe}} +
{{.locale.Tr "repo.issues.filter_label_select_no_label"}} {{.locale.Tr "repo.issues.filter_label_no_select"}} {{$previousExclusiveScope := "_no_scope"}} {{range .Labels}} {{$exclusiveScope := .ExclusiveScope}} - {{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}} + {{if and (ne $previousExclusiveScope $exclusiveScope)}}
{{end}} {{$previousExclusiveScope = $exclusiveScope}} diff --git a/web_src/css/repo.css b/web_src/css/repo.css index 3896265dd..c476fab1b 100644 --- a/web_src/css/repo.css +++ b/web_src/css/repo.css @@ -149,7 +149,6 @@ .repository .filter.menu.labels .label-filter .menu .info { display: inline-block; padding: 0.5rem 0.25rem; - border-bottom: 1px solid var(--color-secondary); font-size: 12px; width: 100%; white-space: nowrap; diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js index d271d2b84..979ee8972 100644 --- a/web_src/js/features/repo-issue.js +++ b/web_src/js/features/repo-issue.js @@ -149,6 +149,7 @@ export function initRepoIssueSidebarList() { } } }); + $('.ui.dropdown.label-filter').dropdown('setting', {'hideDividers': 'empty'}).dropdown('refreshItems'); } export function initRepoIssueCommentDelete() {