From 920ae2367fdb5350778a0f91889acc35fe67b6ba Mon Sep 17 00:00:00 2001 From: Francesco Siddi Date: Sun, 22 Jan 2023 05:14:43 +0100 Subject: [PATCH] Address feedback from #22517 (#22563) - use octicons for icon - use fomantic for centering the link --- web_src/js/features/common-global.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js index ab45267b8..442a83980 100644 --- a/web_src/js/features/common-global.js +++ b/web_src/js/features/common-global.js @@ -7,6 +7,7 @@ import {showGlobalErrorMessage} from '../bootstrap.js'; import {attachDropdownAria} from './aria.js'; import {handleGlobalEnterQuickSubmit} from './comp/QuickSubmit.js'; import {initTooltip} from '../modules/tippy.js'; +import {svg} from '../svg.js'; const {appUrl, csrfToken} = window.config; @@ -169,10 +170,10 @@ export function initGlobalDropzone() { $dropzone.find('.files').append(input); // Create a "Copy Link" element, to conveniently copy the image // or file link as Markdown to the clipboard - const copyLinkElement = document.createElement('a'); - copyLinkElement.className = 'dz-remove'; - copyLinkElement.href = '#'; - copyLinkElement.innerHTML = ' Copy link'; + const copyLinkElement = document.createElement('div'); + copyLinkElement.className = 'tc'; + // The a element has a hardcoded cursor: pointer because the default is overridden by .dropzone + copyLinkElement.innerHTML = `${svg('octicon-copy', 14, 'copy link')} Copy link`; copyLinkElement.addEventListener('click', (e) => { e.preventDefault(); let fileMarkdown = `[${file.name}](/attachments/${file.uuid})`;