realaravinth/forgejo-federation
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity

Fix API status code for hook creation (#2814)

Browse source 
* Fix API status code for hook creation

* Named constants for response statuses
This commit is contained in:
Ethan Koenig 2017-11-19 23:00:53 -08:00 committed by Lunny Xiao
parent 061f65ff29
commit 876bafb7ef
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
public/swagger.v1.json vendored
View file

@ -1527,7 +1527,7 @@
} }
], ],
"responses": { "responses": {
"200": { "201": {
"$ref": "#/responses/Hook" "$ref": "#/responses/Hook"
} }
} }

2
routers/api/v1/repo/hook.go
View file

@ -107,7 +107,7 @@ func CreateHook(ctx *context.APIContext, form api.CreateHookOption) {
// schema: // schema:
// "$ref": "#/definitions/CreateHookOption" // "$ref": "#/definitions/CreateHookOption"
// responses: // responses:
// "200": // "201":
// "$ref": "#/responses/Hook" // "$ref": "#/responses/Hook"
if !utils.CheckCreateHookOption(ctx, &form) { if !utils.CheckCreateHookOption(ctx, &form) {
return return

5
routers/api/v1/utils/hook.go
View file

@ -12,6 +12,7 @@ import (
"code.gitea.io/gitea/routers/api/v1/convert" "code.gitea.io/gitea/routers/api/v1/convert"
"encoding/json" "encoding/json"
"github.com/Unknwon/com" "github.com/Unknwon/com"
"net/http"
) )
// GetOrgHook get an organization's webhook. If there is an error, write to // GetOrgHook get an organization's webhook. If there is an error, write to
@ -69,7 +70,7 @@ func AddOrgHook(ctx *context.APIContext, form *api.CreateHookOption) {
org := ctx.Org.Organization org := ctx.Org.Organization
hook, ok := addHook(ctx, form, org.ID, 0) hook, ok := addHook(ctx, form, org.ID, 0)
if ok { if ok {
ctx.JSON(200, convert.ToHook(org.HomeLink(), hook)) ctx.JSON(http.StatusCreated, convert.ToHook(org.HomeLink(), hook))
} }
} }
@ -78,7 +79,7 @@ func AddRepoHook(ctx *context.APIContext, form *api.CreateHookOption) {
repo := ctx.Repo repo := ctx.Repo
hook, ok := addHook(ctx, form, 0, repo.Repository.ID) hook, ok := addHook(ctx, form, 0, repo.Repository.ID)
if ok { if ok {
ctx.JSON(200, convert.ToHook(repo.RepoLink, hook)) ctx.JSON(http.StatusCreated, convert.ToHook(repo.RepoLink, hook))
} }
} }