realaravinth/forgejo-federation
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity

Only update poster in issue/comment list if it has been loaded (#31216)

Browse source 
Previously, all posters were updated, even if they were not part of
posterMaps. In that case, a ghost user was erroneously inserted.

Fixes #31213.

(cherry picked from commit 3cc7f763c3c22ae4c3b5331f8b72b7009c5b11ea)
This commit is contained in:
Max Wipfli 2024-06-02 04:32:20 +02:00 committed by Earl Warren
parent 47a2102694
commit 737c3e90eb
WARNING! Although there is a key with this ID in the database it does not verify this commit! This commit is SUSPICIOUS.
GPG key ID: 0579CB2928A78A00
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
models/issues/comment_list.go
View file

@ -32,8 +32,10 @@ func (comments CommentList) LoadPosters(ctx context.Context) error {
} }
for _, comment := range comments { for _, comment := range comments {
if comment.Poster == nil {
comment.Poster = getPoster(comment.PosterID, posterMaps) comment.Poster = getPoster(comment.PosterID, posterMaps)
} }
}
return nil return nil
} }

2
models/issues/issue_list.go
View file

@ -88,8 +88,10 @@ func (issues IssueList) LoadPosters(ctx context.Context) error {
} }
for _, issue := range issues { for _, issue := range issues {
if issue.Poster == nil {
issue.Poster = getPoster(issue.PosterID, posterMaps) issue.Poster = getPoster(issue.PosterID, posterMaps)
} }
}
return nil return nil
} }