From 695f5d170bc60909a50d8a16047b1df3e3c1016d Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sun, 18 Jun 2023 23:23:18 +0800 Subject: [PATCH] Fix incorrect link-action event target (#25306) A regression of #25210 The `e.target` is not "this", eg: ``, then `this` should be `button` but `e.target` is `svg`. I will propose a clearer and complete solution for these "link-action" "show-modal" elements after #24724 Co-authored-by: Giteabot --- web_src/js/features/common-global.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js index c5f973f31..b6e1790a9 100644 --- a/web_src/js/features/common-global.js +++ b/web_src/js/features/common-global.js @@ -268,10 +268,10 @@ function linkAction(e) { e.preventDefault(); // A "link-action" can post AJAX request to its "data-url" - // Then the browser is redirect to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading. - // If the "link-action" has "data-modal-confirm(-html)" attribute, a confirm modal dialog will be shown before taking action. + // Then the browser is redirected to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading. + // If the "link-action" has "data-modal-confirm" attribute, a confirm modal dialog will be shown before taking action. - const $this = $(e.target); + const $this = $(this); const redirect = $this.attr('data-redirect'); const doRequest = () => {