2019-04-03 01:24:29 +05:30
|
|
|
// Copyright 2019 The Gitea Authors. All rights reserved.
|
2022-11-27 23:50:29 +05:30
|
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
|
2022-09-03 00:48:23 +05:30
|
|
|
package integration
|
2019-04-03 01:24:29 +05:30
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"net/http"
|
2019-05-11 20:59:17 +05:30
|
|
|
"net/url"
|
2019-04-03 01:24:29 +05:30
|
|
|
"path"
|
2019-08-20 23:13:00 +05:30
|
|
|
"strings"
|
2019-04-03 01:24:29 +05:30
|
|
|
"testing"
|
|
|
|
|
2023-01-18 03:16:03 +05:30
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
2019-05-11 15:51:34 +05:30
|
|
|
api "code.gitea.io/gitea/modules/structs"
|
2019-04-03 01:24:29 +05:30
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestPullCreate_CommitStatus(t *testing.T) {
|
2019-05-11 20:59:17 +05:30
|
|
|
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
|
|
|
session := loginUser(t, "user1")
|
|
|
|
testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
|
|
|
|
testEditFileToNewBranch(t, session, "user1", "repo1", "master", "status1", "README.md", "status1")
|
|
|
|
|
|
|
|
url := path.Join("user1", "repo1", "compare", "master...status1")
|
|
|
|
req := NewRequestWithValues(t, "POST", url,
|
|
|
|
map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, url),
|
|
|
|
"title": "pull request from status1",
|
2019-04-03 01:24:29 +05:30
|
|
|
},
|
|
|
|
)
|
2023-06-19 13:55:36 +05:30
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
2019-04-03 01:24:29 +05:30
|
|
|
|
2019-05-11 20:59:17 +05:30
|
|
|
req = NewRequest(t, "GET", "/user1/repo1/pulls")
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
2021-11-18 07:03:06 +05:30
|
|
|
NewHTMLParser(t, resp.Body)
|
2019-05-11 20:59:17 +05:30
|
|
|
|
|
|
|
// Request repository commits page
|
|
|
|
req = NewRequest(t, "GET", "/user1/repo1/pulls/1/commits")
|
2019-04-03 01:24:29 +05:30
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2021-11-18 07:03:06 +05:30
|
|
|
doc := NewHTMLParser(t, resp.Body)
|
2019-04-03 01:24:29 +05:30
|
|
|
|
2019-05-11 20:59:17 +05:30
|
|
|
// Get first commit URL
|
|
|
|
commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
|
2019-04-03 01:24:29 +05:30
|
|
|
assert.True(t, exists)
|
|
|
|
assert.NotEmpty(t, commitURL)
|
|
|
|
|
2019-05-11 20:59:17 +05:30
|
|
|
commitID := path.Base(commitURL)
|
|
|
|
|
2020-01-22 09:16:04 +05:30
|
|
|
statusList := []api.CommitStatusState{
|
|
|
|
api.CommitStatusPending,
|
|
|
|
api.CommitStatusError,
|
|
|
|
api.CommitStatusFailure,
|
|
|
|
api.CommitStatusSuccess,
|
2019-05-11 20:59:17 +05:30
|
|
|
}
|
|
|
|
|
2020-01-22 09:16:04 +05:30
|
|
|
statesIcons := map[api.CommitStatusState]string{
|
2022-08-10 03:25:29 +05:30
|
|
|
api.CommitStatusPending: "octicon-dot-fill",
|
|
|
|
api.CommitStatusSuccess: "octicon-check",
|
|
|
|
api.CommitStatusError: "gitea-exclamation",
|
|
|
|
api.CommitStatusFailure: "octicon-x",
|
2019-05-11 20:59:17 +05:30
|
|
|
}
|
|
|
|
|
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-05 00:27:16 +05:30
|
|
|
testCtx := NewAPITestContext(t, "user1", "repo1", auth_model.AccessTokenScopeWriteRepository)
|
2022-05-07 22:35:52 +05:30
|
|
|
|
2019-05-11 20:59:17 +05:30
|
|
|
// Update commit status, and check if icon is updated as well
|
|
|
|
for _, status := range statusList {
|
|
|
|
|
|
|
|
// Call API to add status for commit
|
2023-02-20 14:13:04 +05:30
|
|
|
t.Run("CreateStatus", doAPICreateCommitStatus(testCtx, commitID, api.CreateStatusOption{
|
|
|
|
State: status,
|
|
|
|
TargetURL: "http://test.ci/",
|
|
|
|
Description: "",
|
|
|
|
Context: "testci",
|
|
|
|
}))
|
2019-05-11 20:59:17 +05:30
|
|
|
|
|
|
|
req = NewRequestf(t, "GET", "/user1/repo1/pulls/1/commits")
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
doc = NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
commitURL, exists = doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
|
|
|
|
assert.True(t, exists)
|
|
|
|
assert.NotEmpty(t, commitURL)
|
|
|
|
assert.EqualValues(t, commitID, path.Base(commitURL))
|
|
|
|
|
2022-08-10 03:25:29 +05:30
|
|
|
cls, ok := doc.doc.Find("#commits-table tbody tr td.message .commit-status").Last().Attr("class")
|
2019-05-11 20:59:17 +05:30
|
|
|
assert.True(t, ok)
|
2022-08-10 03:25:29 +05:30
|
|
|
assert.Contains(t, cls, statesIcons[status])
|
2019-05-11 20:59:17 +05:30
|
|
|
}
|
|
|
|
})
|
2019-04-03 01:24:29 +05:30
|
|
|
}
|
2019-08-20 23:13:00 +05:30
|
|
|
|
2023-02-20 14:13:04 +05:30
|
|
|
func doAPICreateCommitStatus(ctx APITestContext, commitID string, data api.CreateStatusOption) func(*testing.T) {
|
2022-05-07 22:35:52 +05:30
|
|
|
return func(t *testing.T) {
|
2023-02-20 14:13:04 +05:30
|
|
|
req := NewRequestWithJSON(
|
|
|
|
t,
|
|
|
|
http.MethodPost,
|
|
|
|
fmt.Sprintf("/api/v1/repos/%s/%s/statuses/%s?token=%s", ctx.Username, ctx.Reponame, commitID, ctx.Token),
|
|
|
|
data,
|
2022-05-07 22:35:52 +05:30
|
|
|
)
|
|
|
|
if ctx.ExpectedCode != 0 {
|
|
|
|
ctx.Session.MakeRequest(t, req, ctx.ExpectedCode)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
ctx.Session.MakeRequest(t, req, http.StatusCreated)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-07-13 13:52:51 +05:30
|
|
|
func TestPullCreate_EmptyChangesWithDifferentCommits(t *testing.T) {
|
|
|
|
// Merge must continue if commits SHA are different, even if content is same
|
Fix various typos (#21103)
Found via `codespell -q 3 -S
./options/locale,./options/license,./public/vendor,./web_src/fomantic -L
actived,allways,attachements,ba,befores,commiter,pullrequest,pullrequests,readby,splitted,te,unknwon`
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2022-09-08 00:10:36 +05:30
|
|
|
// Reason: gitflow and merging master back into develop, where is high possibility, there are no changes
|
2022-07-13 13:52:51 +05:30
|
|
|
// but just commit saying "Merge branch". And this meta commit can be also tagged,
|
|
|
|
// so we need to have this meta commit also in develop branch.
|
2019-08-20 23:13:00 +05:30
|
|
|
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
|
|
|
session := loginUser(t, "user1")
|
|
|
|
testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
|
|
|
|
testEditFileToNewBranch(t, session, "user1", "repo1", "master", "status1", "README.md", "status1")
|
|
|
|
testEditFileToNewBranch(t, session, "user1", "repo1", "status1", "status1", "README.md", "# repo1\n\nDescription for repo1")
|
|
|
|
|
|
|
|
url := path.Join("user1", "repo1", "compare", "master...status1")
|
|
|
|
req := NewRequestWithValues(t, "POST", url,
|
|
|
|
map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, url),
|
|
|
|
"title": "pull request from status1",
|
|
|
|
},
|
|
|
|
)
|
2023-06-19 13:55:36 +05:30
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
2019-08-20 23:13:00 +05:30
|
|
|
|
|
|
|
req = NewRequest(t, "GET", "/user1/repo1/pulls/1")
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
doc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
2020-11-16 02:28:16 +05:30
|
|
|
text := strings.TrimSpace(doc.doc.Find(".merge-section").Text())
|
2022-07-13 13:52:51 +05:30
|
|
|
assert.Contains(t, text, "This pull request can be merged automatically.")
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPullCreate_EmptyChangesWithSameCommits(t *testing.T) {
|
|
|
|
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
|
|
|
session := loginUser(t, "user1")
|
|
|
|
testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
|
|
|
|
testCreateBranch(t, session, "user1", "repo1", "branch/master", "status1", http.StatusSeeOther)
|
|
|
|
url := path.Join("user1", "repo1", "compare", "master...status1")
|
|
|
|
req := NewRequestWithValues(t, "POST", url,
|
|
|
|
map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, url),
|
|
|
|
"title": "pull request from status1",
|
|
|
|
},
|
|
|
|
)
|
2023-06-19 13:55:36 +05:30
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
2022-07-13 13:52:51 +05:30
|
|
|
req = NewRequest(t, "GET", "/user1/repo1/pulls/1")
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
doc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
text := strings.TrimSpace(doc.doc.Find(".merge-section").Text())
|
|
|
|
assert.Contains(t, text, "This branch is already included in the target branch. There is nothing to merge.")
|
2019-08-20 23:13:00 +05:30
|
|
|
})
|
|
|
|
}
|