realaravinth/forgejo-federation
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity
forgejo-federation/models/migrations/v1_23/main_test.go

15 lines
262 B
Go
Raw Normal View History

[PORT] gitea#30190: Add unique index for project_issue to prevent duplicate data Fix #27639 --- Remove MSSQL specific code per https://codeberg.org/forgejo/discussions/issues/122 (cherry picked from commit b4825670596fe745cebdcc63a8ead4388602d42c)
2024-04-02 13:32:05 +05:30
// Copyright 2024 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package v1_23 //nolint
import (
"testing"
[CHORE] Move test related function to own package - Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
2024-07-14 19:04:42 +05:30
migration_tests "code.gitea.io/gitea/models/migrations/test"
[PORT] gitea#30190: Add unique index for project_issue to prevent duplicate data Fix #27639 --- Remove MSSQL specific code per https://codeberg.org/forgejo/discussions/issues/122 (cherry picked from commit b4825670596fe745cebdcc63a8ead4388602d42c)
2024-04-02 13:32:05 +05:30
)
func TestMain(m *testing.M) {
[CHORE] Move test related function to own package - Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
2024-07-14 19:04:42 +05:30
migration_tests.MainTest(m)
[PORT] gitea#30190: Add unique index for project_issue to prevent duplicate data Fix #27639 --- Remove MSSQL specific code per https://codeberg.org/forgejo/discussions/issues/122 (cherry picked from commit b4825670596fe745cebdcc63a8ead4388602d42c)
2024-04-02 13:32:05 +05:30
}
Copy permalink