2016-11-04 03:46:01 +05:30
// Copyright 2015 The Gogs Authors. All rights reserved.
2020-09-06 01:42:14 +05:30
// Copyright 2016 The Gitea Authors. All rights reserved.
2016-11-04 03:46:01 +05:30
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package git
import (
"bytes"
2017-04-08 07:53:39 +05:30
"context"
2022-06-10 07:27:49 +05:30
"errors"
2016-11-04 03:46:01 +05:30
"fmt"
"io"
2019-11-10 14:12:51 +05:30
"os"
2016-11-04 03:46:01 +05:30
"os/exec"
"strings"
"time"
2022-03-31 17:26:22 +05:30
"unsafe"
2019-06-26 23:45:26 +05:30
2021-06-25 22:24:08 +05:30
"code.gitea.io/gitea/modules/log"
2019-06-26 23:45:26 +05:30
"code.gitea.io/gitea/modules/process"
2022-03-27 17:24:09 +05:30
"code.gitea.io/gitea/modules/util"
2016-11-04 03:46:01 +05:30
)
2016-12-22 15:00:52 +05:30
var (
2022-01-25 23:45:58 +05:30
// globalCommandArgs global command args for external package setting
2022-10-23 20:14:45 +05:30
globalCommandArgs [ ] CmdArg
2018-01-07 18:40:20 +05:30
2021-06-26 16:58:55 +05:30
// defaultCommandExecutionTimeout default command execution timeout duration
defaultCommandExecutionTimeout = 360 * time . Second
2016-12-22 15:00:52 +05:30
)
2019-11-10 14:12:51 +05:30
// DefaultLocale is the default LC_ALL to run git commands in.
const DefaultLocale = "C"
2016-11-04 03:46:01 +05:30
// Command represents a command with its subcommands or arguments.
type Command struct {
2022-03-27 14:39:56 +05:30
name string
args [ ] string
parentContext context . Context
desc string
globalArgsLength int
2022-10-15 17:48:31 +05:30
brokenArgs [ ] string
2016-11-04 03:46:01 +05:30
}
2022-10-23 20:14:45 +05:30
type CmdArg string
2016-11-04 03:46:01 +05:30
func ( c * Command ) String ( ) string {
if len ( c . args ) == 0 {
return c . name
}
return fmt . Sprintf ( "%s %s" , c . name , strings . Join ( c . args , " " ) )
}
// NewCommand creates and returns a new Git Command based on given command and arguments.
2022-10-15 17:48:31 +05:30
// Each argument should be safe to be trusted. User-provided arguments should be passed to AddDynamicArguments instead.
2022-10-23 20:14:45 +05:30
func NewCommand ( ctx context . Context , args ... CmdArg ) * Command {
2022-01-25 23:45:58 +05:30
// Make an explicit copy of globalCommandArgs, otherwise append might overwrite it
2022-10-23 20:14:45 +05:30
cargs := make ( [ ] string , 0 , len ( globalCommandArgs ) + len ( args ) )
for _ , arg := range globalCommandArgs {
cargs = append ( cargs , string ( arg ) )
}
for _ , arg := range args {
cargs = append ( cargs , string ( arg ) )
}
2016-11-04 03:46:01 +05:30
return & Command {
2022-03-27 14:39:56 +05:30
name : GitExecutable ,
2022-10-23 20:14:45 +05:30
args : cargs ,
2022-03-27 14:39:56 +05:30
parentContext : ctx ,
globalArgsLength : len ( globalCommandArgs ) ,
2016-11-04 03:46:01 +05:30
}
}
2019-11-27 06:05:52 +05:30
// NewCommandNoGlobals creates and returns a new Git Command based on given command and arguments only with the specify args and don't care global command args
2022-10-15 17:48:31 +05:30
// Each argument should be safe to be trusted. User-provided arguments should be passed to AddDynamicArguments instead.
2022-10-23 20:14:45 +05:30
func NewCommandNoGlobals ( args ... CmdArg ) * Command {
2020-05-17 05:01:38 +05:30
return NewCommandContextNoGlobals ( DefaultContext , args ... )
}
// NewCommandContextNoGlobals creates and returns a new Git Command based on given command and arguments only with the specify args and don't care global command args
2022-10-15 17:48:31 +05:30
// Each argument should be safe to be trusted. User-provided arguments should be passed to AddDynamicArguments instead.
2022-10-23 20:14:45 +05:30
func NewCommandContextNoGlobals ( ctx context . Context , args ... CmdArg ) * Command {
cargs := make ( [ ] string , 0 , len ( args ) )
for _ , arg := range args {
cargs = append ( cargs , string ( arg ) )
}
2019-11-27 06:05:52 +05:30
return & Command {
2019-11-30 20:10:22 +05:30
name : GitExecutable ,
2022-10-23 20:14:45 +05:30
args : cargs ,
2020-05-17 05:01:38 +05:30
parentContext : ctx ,
2019-11-27 06:05:52 +05:30
}
}
2019-11-30 20:10:22 +05:30
// SetParentContext sets the parent context for this command
func ( c * Command ) SetParentContext ( ctx context . Context ) * Command {
c . parentContext = ctx
return c
}
// SetDescription sets the description for this command which be returned on
// c.String()
func ( c * Command ) SetDescription ( desc string ) * Command {
c . desc = desc
return c
}
2022-10-23 20:14:45 +05:30
// AddArguments adds new git argument(s) to the command. Each argument must be safe to be trusted.
2022-10-15 17:48:31 +05:30
// User-provided arguments should be passed to AddDynamicArguments instead.
2022-10-23 20:14:45 +05:30
func ( c * Command ) AddArguments ( args ... CmdArg ) * Command {
for _ , arg := range args {
c . args = append ( c . args , string ( arg ) )
}
2016-11-04 03:46:01 +05:30
return c
}
2022-10-15 16:19:26 +05:30
// AddDynamicArguments adds new dynamic argument(s) to the command.
2022-10-15 17:48:31 +05:30
// The arguments may come from user input and can not be trusted, so no leading '-' is allowed to avoid passing options
2022-10-15 16:19:26 +05:30
func ( c * Command ) AddDynamicArguments ( args ... string ) * Command {
for _ , arg := range args {
if arg != "" && arg [ 0 ] == '-' {
2022-10-15 17:48:31 +05:30
c . brokenArgs = append ( c . brokenArgs , arg )
2022-10-15 16:19:26 +05:30
}
}
2022-10-15 17:48:31 +05:30
if len ( c . brokenArgs ) != 0 {
return c
}
2022-10-15 16:19:26 +05:30
c . args = append ( c . args , args ... )
return c
}
2022-10-23 20:14:45 +05:30
// AddDashesAndList adds the "--" and then add the list as arguments, it's usually for adding file list
// At the moment, this function can be only called once, maybe in future it can be refactored to support multiple calls (if necessary)
func ( c * Command ) AddDashesAndList ( list ... string ) * Command {
c . args = append ( c . args , "--" )
// Some old code also checks `arg != ""`, IMO it's not necessary.
// If the check is needed, the list should be prepared before the call to this function
c . args = append ( c . args , list ... )
return c
}
// CmdArgCheck checks whether the string is safe to be used as a dynamic argument.
// It panics if the check fails. Usually it should not be used, it's just for refactoring purpose
// deprecated
func CmdArgCheck ( s string ) CmdArg {
if s != "" && s [ 0 ] == '-' {
panic ( "invalid git cmd argument: " + s )
}
return CmdArg ( s )
}
2022-08-06 18:43:11 +05:30
// RunOpts represents parameters to run the command. If UseContextTimeout is specified, then Timeout is ignored.
2022-04-01 08:25:30 +05:30
type RunOpts struct {
2022-08-06 18:43:11 +05:30
Env [ ] string
Timeout time . Duration
UseContextTimeout bool
Dir string
Stdout , Stderr io . Writer
Stdin io . Reader
PipelineFunc func ( context . Context , context . CancelFunc ) error
2021-08-18 18:40:39 +05:30
}
2022-07-08 13:39:07 +05:30
func commonBaseEnvs ( ) [ ] string {
2022-06-10 07:27:49 +05:30
// at the moment, do not set "GIT_CONFIG_NOSYSTEM", users may have put some configs like "receive.certNonceSeed" in it
2022-07-08 13:39:07 +05:30
envs := [ ] string {
2022-06-10 07:27:49 +05:30
"HOME=" + HomeDir ( ) , // make Gitea use internal git config only, to prevent conflicts with user's git config
2022-07-08 13:39:07 +05:30
"GIT_NO_REPLACE_OBJECTS=1" , // ignore replace references (https://git-scm.com/docs/git-replace)
}
// some environment variables should be passed to git command
passThroughEnvKeys := [ ] string {
"GNUPGHOME" , // git may call gnupg to do commit signing
}
for _ , key := range passThroughEnvKeys {
if val , ok := os . LookupEnv ( key ) ; ok {
envs = append ( envs , key + "=" + val )
}
2022-06-10 07:27:49 +05:30
}
2022-07-08 13:39:07 +05:30
return envs
}
// CommonGitCmdEnvs returns the common environment variables for a "git" command.
func CommonGitCmdEnvs ( ) [ ] string {
return append ( commonBaseEnvs ( ) , [ ] string {
"LC_ALL=" + DefaultLocale ,
"GIT_TERMINAL_PROMPT=0" , // avoid prompting for credentials interactively, supported since git v2.3
} ... )
2022-06-10 07:27:49 +05:30
}
2022-10-23 20:14:45 +05:30
// CommonCmdServEnvs is like CommonGitCmdEnvs, but it only returns minimal required environment variables for the "gitea serv" command
2022-06-10 07:27:49 +05:30
func CommonCmdServEnvs ( ) [ ] string {
2022-07-08 13:39:07 +05:30
return commonBaseEnvs ( )
2022-06-10 07:27:49 +05:30
}
2022-10-15 17:48:31 +05:30
var ErrBrokenCommand = errors . New ( "git command is broken" )
2022-04-01 08:25:30 +05:30
// Run runs the command with the RunOpts
func ( c * Command ) Run ( opts * RunOpts ) error {
2022-10-15 17:48:31 +05:30
if len ( c . brokenArgs ) != 0 {
log . Error ( "git command is broken: %s, broken args: %s" , c . String ( ) , strings . Join ( c . brokenArgs , " " ) )
return ErrBrokenCommand
}
2022-04-01 08:25:30 +05:30
if opts == nil {
opts = & RunOpts { }
}
2022-11-14 02:15:20 +05:30
// We must not change the provided options
timeout := opts . Timeout
if timeout <= 0 {
timeout = defaultCommandExecutionTimeout
2016-11-04 03:46:01 +05:30
}
2022-04-01 08:25:30 +05:30
if len ( opts . Dir ) == 0 {
2021-06-25 22:24:08 +05:30
log . Debug ( "%s" , c )
2016-11-04 03:46:01 +05:30
} else {
2022-04-01 08:25:30 +05:30
log . Debug ( "%s: %v" , opts . Dir , c )
2016-11-04 03:46:01 +05:30
}
2021-12-01 01:36:32 +05:30
desc := c . desc
if desc == "" {
2022-03-27 17:24:09 +05:30
args := c . args [ c . globalArgsLength : ]
var argSensitiveURLIndexes [ ] int
for i , arg := range c . args {
if strings . Contains ( arg , "://" ) && strings . Contains ( arg , "@" ) {
argSensitiveURLIndexes = append ( argSensitiveURLIndexes , i )
}
}
if len ( argSensitiveURLIndexes ) > 0 {
args = make ( [ ] string , len ( c . args ) )
copy ( args , c . args )
for _ , urlArgIndex := range argSensitiveURLIndexes {
2022-03-31 07:55:40 +05:30
args [ urlArgIndex ] = util . SanitizeCredentialURLs ( args [ urlArgIndex ] )
2022-03-27 17:24:09 +05:30
}
}
2022-04-01 08:25:30 +05:30
desc = fmt . Sprintf ( "%s %s [repo_path: %s]" , c . name , strings . Join ( args , " " ) , opts . Dir )
2021-12-01 01:36:32 +05:30
}
2022-08-06 18:43:11 +05:30
var ctx context . Context
var cancel context . CancelFunc
var finished context . CancelFunc
if opts . UseContextTimeout {
ctx , cancel , finished = process . GetManager ( ) . AddContext ( c . parentContext , desc )
} else {
2022-11-14 02:15:20 +05:30
ctx , cancel , finished = process . GetManager ( ) . AddContextTimeout ( c . parentContext , timeout , desc )
2022-08-06 18:43:11 +05:30
}
2021-12-01 01:36:32 +05:30
defer finished ( )
2017-04-08 07:53:39 +05:30
cmd := exec . CommandContext ( ctx , c . name , c . args ... )
2022-04-01 08:25:30 +05:30
if opts . Env == nil {
2021-05-17 16:29:31 +05:30
cmd . Env = os . Environ ( )
2019-11-10 14:12:51 +05:30
} else {
2022-04-01 08:25:30 +05:30
cmd . Env = opts . Env
2019-11-10 14:12:51 +05:30
}
Disable new signal-based asynchronous goroutine preemption from GO 1.14 in git env (#11237)
As seen in trouble shooting #11032 the new feature of Go 1.14 is causing several second delays in startup in certain situations. Debugging shows it spending several seconds handling SIGURG commands during init:
```
6922:04:51.984234 trace init() ./modules/queue/unique_queue_wrapped.go
remote: ) = 69 <0.000012>
remote: [pid 15984] 22:04:51 write(1, "\ttime taken: 236.761\302\265s\n\n", 25 time taken: 236.761µs
remote:
remote: ) = 25 <0.000011>
remote: [pid 15984] 22:04:51 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
remote: [pid 15984] 22:04:52 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
remote: [pid 15984] 22:04:52 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
```
This causes up to 20 seconds added to a push in some cases as it happens for each call of the gitea hook command. This is likely the cause of #10661 as well and would start to effect users once we release 1.12 which would be the first release compiled with Go 1.14. I suspect this is just a slight issue with the upstream implementatation as there have been a few very similar bugs fixed and reported:
https://github.com/golang/go/issues/37741
https://github.com/golang/go/issues/37942
We should revisit this in the future and see if a newer version of Go has solved it, but for now disable this option in the environment that gitea hook runs in to avoid it.
2020-04-28 21:15:32 +05:30
2022-06-03 20:06:18 +05:30
process . SetSysProcAttribute ( cmd )
2022-06-10 07:27:49 +05:30
cmd . Env = append ( cmd . Env , CommonGitCmdEnvs ( ) ... )
2022-04-01 08:25:30 +05:30
cmd . Dir = opts . Dir
cmd . Stdout = opts . Stdout
cmd . Stderr = opts . Stderr
cmd . Stdin = opts . Stdin
2016-11-04 03:46:01 +05:30
if err := cmd . Start ( ) ; err != nil {
return err
}
2022-04-01 08:25:30 +05:30
if opts . PipelineFunc != nil {
err := opts . PipelineFunc ( ctx , cancel )
2020-01-15 14:02:57 +05:30
if err != nil {
cancel ( )
2020-12-17 17:20:21 +05:30
_ = cmd . Wait ( )
2020-01-15 14:02:57 +05:30
return err
}
2019-11-11 17:16:28 +05:30
}
2019-12-13 14:33:38 +05:30
if err := cmd . Wait ( ) ; err != nil && ctx . Err ( ) != context . DeadlineExceeded {
2017-05-30 15:02:01 +05:30
return err
}
return ctx . Err ( )
2016-11-04 03:46:01 +05:30
}
2022-04-01 08:25:30 +05:30
type RunStdError interface {
2022-03-31 17:26:22 +05:30
error
2022-06-10 07:27:49 +05:30
Unwrap ( ) error
2022-03-31 17:26:22 +05:30
Stderr ( ) string
2022-06-10 07:27:49 +05:30
IsExitCode ( code int ) bool
2019-05-11 20:59:17 +05:30
}
2022-04-01 08:25:30 +05:30
type runStdError struct {
2022-03-31 17:26:22 +05:30
err error
stderr string
errMsg string
2019-05-11 20:59:17 +05:30
}
2022-04-01 08:25:30 +05:30
func ( r * runStdError ) Error ( ) string {
2022-03-31 17:26:22 +05:30
// the stderr must be in the returned error text, some code only checks `strings.Contains(err.Error(), "git error")`
if r . errMsg == "" {
r . errMsg = ConcatenateError ( r . err , r . stderr ) . Error ( )
}
return r . errMsg
2019-05-11 20:59:17 +05:30
}
2022-04-01 08:25:30 +05:30
func ( r * runStdError ) Unwrap ( ) error {
2022-03-31 17:26:22 +05:30
return r . err
}
2022-04-01 08:25:30 +05:30
func ( r * runStdError ) Stderr ( ) string {
2022-03-31 17:26:22 +05:30
return r . stderr
2016-11-04 03:46:01 +05:30
}
2022-06-10 07:27:49 +05:30
func ( r * runStdError ) IsExitCode ( code int ) bool {
var exitError * exec . ExitError
if errors . As ( r . err , & exitError ) {
return exitError . ExitCode ( ) == code
}
return false
}
2022-03-31 17:26:22 +05:30
func bytesToString ( b [ ] byte ) string {
return * ( * string ) ( unsafe . Pointer ( & b ) ) // that's what Golang's strings.Builder.String() does (go/src/strings/builder.go)
2019-05-11 20:59:17 +05:30
}
2022-04-01 08:25:30 +05:30
// RunStdString runs the command with options and returns stdout/stderr as string. and store stderr to returned error (err combined with stderr).
func ( c * Command ) RunStdString ( opts * RunOpts ) ( stdout , stderr string , runErr RunStdError ) {
stdoutBytes , stderrBytes , err := c . RunStdBytes ( opts )
2022-03-31 17:26:22 +05:30
stdout = bytesToString ( stdoutBytes )
stderr = bytesToString ( stderrBytes )
if err != nil {
2022-04-01 08:25:30 +05:30
return stdout , stderr , & runStdError { err : err , stderr : stderr }
2022-03-31 17:26:22 +05:30
}
// even if there is no err, there could still be some stderr output, so we just return stdout/stderr as they are
return stdout , stderr , nil
}
2022-04-01 08:25:30 +05:30
// RunStdBytes runs the command with options and returns stdout/stderr as bytes. and store stderr to returned error (err combined with stderr).
func ( c * Command ) RunStdBytes ( opts * RunOpts ) ( stdout , stderr [ ] byte , runErr RunStdError ) {
if opts == nil {
opts = & RunOpts { }
}
if opts . Stdout != nil || opts . Stderr != nil {
2022-03-31 17:26:22 +05:30
// we must panic here, otherwise there would be bugs if developers set Stdin/Stderr by mistake, and it would be very difficult to debug
2022-04-01 08:25:30 +05:30
panic ( "stdout and stderr field must be nil when using RunStdBytes" )
2022-03-31 17:26:22 +05:30
}
stdoutBuf := & bytes . Buffer { }
stderrBuf := & bytes . Buffer { }
2022-11-14 02:15:20 +05:30
// We must not change the provided options as it could break future calls - therefore make a copy.
newOpts := & RunOpts {
Env : opts . Env ,
Timeout : opts . Timeout ,
UseContextTimeout : opts . UseContextTimeout ,
Dir : opts . Dir ,
Stdout : stdoutBuf ,
Stderr : stderrBuf ,
Stdin : opts . Stdin ,
PipelineFunc : opts . PipelineFunc ,
}
err := c . Run ( newOpts )
2022-03-31 17:26:22 +05:30
stderr = stderrBuf . Bytes ( )
if err != nil {
2022-04-01 08:25:30 +05:30
return nil , stderr , & runStdError { err : err , stderr : bytesToString ( stderr ) }
2022-03-31 17:26:22 +05:30
}
// even if there is no err, there could still be some stderr output
return stdoutBuf . Bytes ( ) , stderr , nil
2016-11-04 03:46:01 +05:30
}
2022-01-25 23:45:58 +05:30
// AllowLFSFiltersArgs return globalCommandArgs with lfs filter, it should only be used for tests
2022-10-23 20:14:45 +05:30
func AllowLFSFiltersArgs ( ) [ ] CmdArg {
2022-01-25 23:45:58 +05:30
// Now here we should explicitly allow lfs filters to run
2022-10-23 20:14:45 +05:30
filteredLFSGlobalArgs := make ( [ ] CmdArg , len ( globalCommandArgs ) )
2022-01-25 23:45:58 +05:30
j := 0
for _ , arg := range globalCommandArgs {
2022-10-23 20:14:45 +05:30
if strings . Contains ( string ( arg ) , "lfs" ) {
2022-01-25 23:45:58 +05:30
j --
} else {
filteredLFSGlobalArgs [ j ] = arg
j ++
}
}
return filteredLFSGlobalArgs [ : j ]
}