2020-12-04 00:16:11 +05:30
|
|
|
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a MIT-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
Avatar refactor, move avatar code from `models` to `models.avatars`, remove duplicated code (#17123)
Why this refactor
The goal is to move most files from `models` package to `models.xxx` package. Many models depend on avatar model, so just move this first.
And the existing logic is not clear, there are too many function like `AvatarLink`, `RelAvatarLink`, `SizedRelAvatarLink`, `SizedAvatarLink`, `MakeFinalAvatarURL`, `HashedAvatarLink`, etc. This refactor make everything clear:
* user.AvatarLink()
* user.AvatarLinkWithSize(size)
* avatars.GenerateEmailAvatarFastLink(email, size)
* avatars.GenerateEmailAvatarFinalLink(email, size)
And many duplicated code are deleted in route handler, the handler and the model share the same avatar logic now.
2021-10-06 04:55:46 +05:30
|
|
|
package avatars
|
2020-12-04 00:16:11 +05:30
|
|
|
|
|
|
|
import (
|
|
|
|
"net/url"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
|
|
|
const gravatarSource = "https://secure.gravatar.com/avatar/"
|
|
|
|
|
|
|
|
func disableGravatar() {
|
|
|
|
setting.EnableFederatedAvatar = false
|
|
|
|
setting.LibravatarService = nil
|
|
|
|
setting.DisableGravatar = true
|
|
|
|
}
|
|
|
|
|
|
|
|
func enableGravatar(t *testing.T) {
|
|
|
|
setting.DisableGravatar = false
|
|
|
|
var err error
|
|
|
|
setting.GravatarSourceURL, err = url.Parse(gravatarSource)
|
|
|
|
assert.NoError(t, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestHashEmail(t *testing.T) {
|
|
|
|
assert.Equal(t,
|
|
|
|
"d41d8cd98f00b204e9800998ecf8427e",
|
|
|
|
HashEmail(""),
|
|
|
|
)
|
|
|
|
assert.Equal(t,
|
|
|
|
"353cbad9b58e69c96154ad99f92bedc7",
|
|
|
|
HashEmail("gitea@example.com"),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSizedAvatarLink(t *testing.T) {
|
2021-05-12 09:43:42 +05:30
|
|
|
setting.AppSubURL = "/testsuburl"
|
|
|
|
|
2020-12-04 00:16:11 +05:30
|
|
|
disableGravatar()
|
2021-05-12 09:43:42 +05:30
|
|
|
assert.Equal(t, "/testsuburl/assets/img/avatar_default.png",
|
Avatar refactor, move avatar code from `models` to `models.avatars`, remove duplicated code (#17123)
Why this refactor
The goal is to move most files from `models` package to `models.xxx` package. Many models depend on avatar model, so just move this first.
And the existing logic is not clear, there are too many function like `AvatarLink`, `RelAvatarLink`, `SizedRelAvatarLink`, `SizedAvatarLink`, `MakeFinalAvatarURL`, `HashedAvatarLink`, etc. This refactor make everything clear:
* user.AvatarLink()
* user.AvatarLinkWithSize(size)
* avatars.GenerateEmailAvatarFastLink(email, size)
* avatars.GenerateEmailAvatarFinalLink(email, size)
And many duplicated code are deleted in route handler, the handler and the model share the same avatar logic now.
2021-10-06 04:55:46 +05:30
|
|
|
GenerateEmailAvatarFastLink("gitea@example.com", 100))
|
2020-12-04 00:16:11 +05:30
|
|
|
|
|
|
|
enableGravatar(t)
|
|
|
|
assert.Equal(t,
|
|
|
|
"https://secure.gravatar.com/avatar/353cbad9b58e69c96154ad99f92bedc7?d=identicon&s=100",
|
Avatar refactor, move avatar code from `models` to `models.avatars`, remove duplicated code (#17123)
Why this refactor
The goal is to move most files from `models` package to `models.xxx` package. Many models depend on avatar model, so just move this first.
And the existing logic is not clear, there are too many function like `AvatarLink`, `RelAvatarLink`, `SizedRelAvatarLink`, `SizedAvatarLink`, `MakeFinalAvatarURL`, `HashedAvatarLink`, etc. This refactor make everything clear:
* user.AvatarLink()
* user.AvatarLinkWithSize(size)
* avatars.GenerateEmailAvatarFastLink(email, size)
* avatars.GenerateEmailAvatarFinalLink(email, size)
And many duplicated code are deleted in route handler, the handler and the model share the same avatar logic now.
2021-10-06 04:55:46 +05:30
|
|
|
GenerateEmailAvatarFastLink("gitea@example.com", 100),
|
2020-12-04 00:16:11 +05:30
|
|
|
)
|
|
|
|
}
|