2017-03-17 11:27:43 +05:30
|
|
|
<div class="four wide column">
|
|
|
|
<div class="ui segment metas">
|
2017-08-24 18:00:27 +05:30
|
|
|
{{template "repo/issue/branch_selector_field" .}}
|
|
|
|
|
2020-04-06 22:03:34 +05:30
|
|
|
{{if .Issue.IsPull }}
|
|
|
|
|
|
|
|
<input id="reviewer_id" name="reviewer_id" type="hidden" value="{{.reviewer_id}}">
|
|
|
|
<div class="ui {{if or (not .CanChooseReviewer) .Repository.IsArchived}}disabled{{end}} floating jump select-reviewers-modify dropdown">
|
|
|
|
<span class="text">
|
|
|
|
<strong>{{.i18n.Tr "repo.issues.review.reviewers"}}</strong>
|
|
|
|
{{if and .CanChooseReviewer (not .Repository.IsArchived)}}
|
|
|
|
{{svg "octicon-gear" 16}}
|
|
|
|
{{end}}
|
|
|
|
</span>
|
|
|
|
<div class="filter menu" data-action="" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/request_review">
|
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.i18n.Tr "repo.issues.new.add_reviewer_title"}}</div>
|
|
|
|
{{if .Reviewers}}
|
|
|
|
<div class="ui icon search input">
|
|
|
|
<i class="search icon"></i>
|
|
|
|
<input type="text" placeholder="{{.i18n.Tr "repo.issues.filter_reviewers"}}">
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
{{range .Reviewers}}
|
|
|
|
{{$ReviewerID := .ID}}
|
|
|
|
{{$checked := false}}
|
|
|
|
{{$canChoose := false}}
|
|
|
|
{{$notReviewed := true}}
|
|
|
|
|
|
|
|
{{range $.PullReviewers}}
|
|
|
|
{{if eq .ReviewerID $ReviewerID }}
|
|
|
|
{{$notReviewed = false }}
|
|
|
|
{{if eq .Type 4 }}
|
|
|
|
{{$checked = true}}
|
|
|
|
{{if or (eq $ReviewerID $.SignedUserID) $.Permission.IsAdmin}}
|
|
|
|
{{$canChoose = true}}
|
|
|
|
{{end}}
|
|
|
|
{{else}}
|
|
|
|
{{$canChoose = true}}
|
|
|
|
{{end}}
|
|
|
|
{{end}}
|
|
|
|
{{end}}
|
|
|
|
|
|
|
|
{{ if $notReviewed}}
|
|
|
|
{{$canChoose = true}}
|
|
|
|
{{end}}
|
|
|
|
|
|
|
|
<a class="{{if not $canChoose}}ui poping up{{end}} item {{if $checked}} checked {{end}}" href="#" data-id="{{.ID}}" data-id-selector="#review_request_{{.ID}}" data-can-change="{{if not $canChoose}}block{{end}}" {{if not $canChoose}} data-content="{{$.i18n.Tr "repo.issues.remove_request_review_block"}}"{{end}} data-is-checked="{{if $checked}}add{{else}}remove{{end}}">
|
|
|
|
<span class="octicon-check {{if not $checked}}invisible{{end}}">{{svg "octicon-check" 16}}</span>
|
|
|
|
<span class="text">
|
|
|
|
<img class="ui avatar image" src="{{.RelAvatarLink}}"> {{.GetDisplayName}}
|
|
|
|
</span>
|
|
|
|
</a>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
|
|
|
|
<div class="ui assignees list">
|
|
|
|
<span class="no-select item {{if .PullReviewers}}hide{{end}}">{{.i18n.Tr "repo.issues.new.no_reviewers"}}</span>
|
|
|
|
<div class="selected">
|
|
|
|
{{range .PullReviewers}}
|
|
|
|
<div class="item" style="margin-bottom: 10px;">
|
|
|
|
<a href="{{.Reviewer.HomeLink}}"><img class="ui avatar image" src="{{.Reviewer.RelAvatarLink}}"> {{.Reviewer.GetDisplayName}}</a>
|
|
|
|
<span class="ui right type-icon text {{if eq .Type 1}}green
|
|
|
|
{{- else if eq .Type 2}}grey
|
|
|
|
{{- else if eq .Type 3}}red
|
|
|
|
{{- else if eq .Type 4}}yellow
|
|
|
|
{{- else}}grey{{end}} right ">
|
|
|
|
|
|
|
|
{{$canChoose := false}}
|
|
|
|
{{if eq .Type 4}}
|
|
|
|
{{if or (eq .ReviewerID $.SignedUserID) $.Permission.IsAdmin}}
|
|
|
|
{{$canChoose = true}}
|
|
|
|
{{end}}
|
|
|
|
{{else}}
|
|
|
|
{{if and (or $.IsIssuePoster $.CanChooseReviewer) (not (eq $.SignedUserID .ReviewerID))}}
|
|
|
|
{{$canChoose = true}}
|
|
|
|
{{end}}
|
|
|
|
{{end}}
|
|
|
|
|
|
|
|
{{if $canChoose}}
|
|
|
|
<a href="#" class="ui poping up icon re-request-review" data-is-checked="{{if eq .Type 4}}remove{{else}}add{{end}}" data-content="{{ if eq .Type 4 }} {{$.i18n.Tr "repo.issues.remove_request_review"}} {{else}} {{$.i18n.Tr "repo.issues.re_request_review"}} {{end}}" data-issue-id="{{$.Issue.ID}}" data-id="{{.ReviewerID}}" data-update-url="{{$.RepoLink}}/issues/request_review">
|
|
|
|
{{svg "octicon-sync" 16}}
|
|
|
|
</a>
|
|
|
|
{{end}}
|
|
|
|
{{svg (printf "octicon-%s" .Type.Icon) 16}}
|
|
|
|
</span>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
|
|
|
|
{{end}}
|
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-label dropdown">
|
2017-03-17 11:27:43 +05:30
|
|
|
<span class="text">
|
|
|
|
<strong>{{.i18n.Tr "repo.issues.new.labels"}}</strong>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
|
2020-03-17 21:49:03 +05:30
|
|
|
{{svg "octicon-gear" 16}}
|
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
</span>
|
2020-02-12 02:10:47 +05:30
|
|
|
<div class="filter menu" data-action="update" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/labels">
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.i18n.Tr "repo.issues.new.add_labels_title"}}</div>
|
|
|
|
{{if or .Labels .OrgLabels}}
|
|
|
|
<div class="ui icon search input">
|
|
|
|
<i class="search icon"></i>
|
|
|
|
<input type="text" placeholder="{{.i18n.Tr "repo.issues.filter_labels"}}">
|
|
|
|
</div>
|
2017-03-17 11:27:43 +05:30
|
|
|
{{end}}
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="no-select item">{{.i18n.Tr "repo.issues.new.clear_labels"}}</div>
|
|
|
|
{{if or .Labels .OrgLabels}}
|
|
|
|
{{range .Labels}}
|
2020-04-30 13:40:15 +05:30
|
|
|
<a class="{{if .IsChecked}}checked{{end}} item" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{svg "octicon-check" 16}}</span><span class="label color" style="background-color: {{.Color}}"></span> {{.Name | RenderEmojiPlain}}
|
|
|
|
{{if .Description }}<br><small class="desc">{{.Description | RenderEmojiPlain}}</small>{{end}}</a>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{end}}
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
{{range .OrgLabels}}
|
2020-04-30 13:40:15 +05:30
|
|
|
<a class="{{if .IsChecked}}checked{{end}} item" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{svg "octicon-check" 16}}</span><span class="label color" style="background-color: {{.Color}}"></span> {{.Name | RenderEmojiPlain}}
|
|
|
|
{{if .Description }}<br><small class="desc">{{.Description | RenderEmojiPlain}}</small>{{end}}</a>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{end}}
|
|
|
|
{{else}}
|
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">{{.i18n.Tr "repo.issues.new.no_items"}}</div>
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 09:44:46 +05:30
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
<div class="ui labels list">
|
|
|
|
<span class="no-select item {{if .HasSelectedLabel}}hide{{end}}">{{.i18n.Tr "repo.issues.new.no_label"}}</span>
|
|
|
|
{{range .Labels}}
|
|
|
|
<div class="item">
|
2020-04-30 13:40:15 +05:30
|
|
|
<a class="ui label {{if not .IsChecked}}hide{{end}}" id="label_{{.ID}}" href="{{$.RepoLink}}/issues?labels={{.ID}}" style="color: {{.ForegroundColor}}; background-color: {{.Color}}" title="{{.Description}}">{{.Name | RenderEmojiPlain}}</a>
|
2017-03-17 11:27:43 +05:30
|
|
|
</div>
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 09:44:46 +05:30
|
|
|
{{end}}
|
|
|
|
{{range .OrgLabels}}
|
|
|
|
<div class="item">
|
2020-04-30 13:40:15 +05:30
|
|
|
<a class="ui label {{if not .IsChecked}}hide{{end}}" id="label_{{.ID}}" href="{{$.RepoLink}}/issues?labels={{.ID}}" style="color: {{.ForegroundColor}}; background-color: {{.Color}}" title="{{.Description}}">{{.Name | RenderEmojiPlain}}</a>
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 09:44:46 +05:30
|
|
|
</div>
|
2017-03-17 11:27:43 +05:30
|
|
|
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-milestone dropdown">
|
2017-03-17 11:27:43 +05:30
|
|
|
<span class="text">
|
|
|
|
<strong>{{.i18n.Tr "repo.issues.new.milestone"}}</strong>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
|
2020-03-17 21:49:03 +05:30
|
|
|
{{svg "octicon-gear" 16}}
|
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
</span>
|
|
|
|
<div class="menu" data-action="update" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/milestone">
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.i18n.Tr "repo.issues.new.add_milestone_title"}}</div>
|
|
|
|
{{if or .OpenMilestones .ClosedMilestones}}
|
|
|
|
<div class="ui icon search input">
|
|
|
|
<i class="search icon"></i>
|
|
|
|
<input type="text" placeholder="{{.i18n.Tr "repo.issues.filter_milestones"}}">
|
|
|
|
</div>
|
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
<div class="no-select item">{{.i18n.Tr "repo.issues.new.clear_milestone"}}</div>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if and (not .OpenMilestones) (not .ClosedMilestones)}}
|
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">
|
|
|
|
{{.i18n.Tr "repo.issues.new.no_items"}}
|
2017-03-17 11:27:43 +05:30
|
|
|
</div>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{else}}
|
|
|
|
{{if .OpenMilestones}}
|
|
|
|
<div class="divider"></div>
|
|
|
|
<div class="header">
|
|
|
|
{{svg "octicon-milestone" 16}}
|
|
|
|
{{.i18n.Tr "repo.issues.new.open_milestone"}}
|
|
|
|
</div>
|
|
|
|
{{range .OpenMilestones}}
|
|
|
|
<div class="item" data-id="{{.ID}}" data-href="{{$.RepoLink}}/issues?milestone={{.ID}}"> {{.Name}}</div>
|
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
{{end}}
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if .ClosedMilestones}}
|
|
|
|
<div class="divider"></div>
|
|
|
|
<div class="header">
|
|
|
|
{{svg "octicon-milestone" 16}}
|
|
|
|
{{.i18n.Tr "repo.issues.new.closed_milestone"}}
|
|
|
|
</div>
|
|
|
|
{{range .ClosedMilestones}}
|
|
|
|
<a class="item" data-id="{{.ID}}" data-href="{{$.RepoLink}}/issues?milestone={{.ID}}"> {{.Name}}</a>
|
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
{{end}}
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
<div class="ui select-milestone list">
|
|
|
|
<span class="no-select item {{if .Issue.Milestone}}hide{{end}}">{{.i18n.Tr "repo.issues.new.no_milestone"}}</span>
|
|
|
|
<div class="selected">
|
|
|
|
{{if .Issue.Milestone}}
|
2019-09-20 19:35:05 +05:30
|
|
|
<a class="item" href="{{.RepoLink}}/milestone/{{.Issue.Milestone.ID}}"> {{.Issue.Milestone.Name}}</a>
|
2017-03-17 11:27:43 +05:30
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
<input id="assignee_id" name="assignee_id" type="hidden" value="{{.assignee_id}}">
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-assignees-modify dropdown">
|
2017-03-17 11:27:43 +05:30
|
|
|
<span class="text">
|
2018-05-09 21:59:04 +05:30
|
|
|
<strong>{{.i18n.Tr "repo.issues.new.assignees"}}</strong>
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
|
2020-03-17 21:49:03 +05:30
|
|
|
{{svg "octicon-gear" 16}}
|
|
|
|
{{end}}
|
2017-03-17 11:27:43 +05:30
|
|
|
</span>
|
2018-05-09 21:59:04 +05:30
|
|
|
<div class="filter menu" data-action="" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/assignee">
|
2020-04-04 11:09:48 +05:30
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.i18n.Tr "repo.issues.new.add_assignees_title"}}</div>
|
|
|
|
<div class="ui icon search input">
|
|
|
|
<i class="search icon"></i>
|
|
|
|
<input type="text" placeholder="{{.i18n.Tr "repo.issues.filter_assignees"}}">
|
|
|
|
</div>
|
2018-05-09 21:59:04 +05:30
|
|
|
<div class="no-select item">{{.i18n.Tr "repo.issues.new.clear_assignees"}}</div>
|
2017-03-17 11:27:43 +05:30
|
|
|
{{range .Assignees}}
|
2018-05-09 21:59:04 +05:30
|
|
|
|
|
|
|
{{$AssigneeID := .ID}}
|
|
|
|
<a class="item{{range $.Issue.Assignees}}
|
|
|
|
{{if eq .ID $AssigneeID}}
|
|
|
|
checked
|
|
|
|
{{end}}
|
|
|
|
{{end}}" href="#" data-id="{{.ID}}" data-id-selector="#assignee_{{.ID}}">
|
2020-02-11 22:32:41 +05:30
|
|
|
{{$checked := false}}
|
|
|
|
{{range $.Issue.Assignees}}
|
|
|
|
{{if eq .ID $AssigneeID}}
|
|
|
|
{{$checked = true}}
|
|
|
|
{{end}}
|
2018-05-09 21:59:04 +05:30
|
|
|
{{end}}
|
2020-02-11 22:32:41 +05:30
|
|
|
<span class="octicon-check {{if not $checked}}invisible{{end}}">{{svg "octicon-check" 16}}</span>
|
2018-05-09 21:59:04 +05:30
|
|
|
<span class="text">
|
2019-05-08 14:11:35 +05:30
|
|
|
<img class="ui avatar image" src="{{.RelAvatarLink}}"> {{.GetDisplayName}}
|
2018-05-09 21:59:04 +05:30
|
|
|
</span>
|
|
|
|
</a>
|
2017-03-17 11:27:43 +05:30
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
2018-05-09 21:59:04 +05:30
|
|
|
<div class="ui assignees list">
|
|
|
|
<span class="no-select item {{if .Issue.Assignees}}hide{{end}}">{{.i18n.Tr "repo.issues.new.no_assignees"}}</span>
|
2017-03-17 11:27:43 +05:30
|
|
|
<div class="selected">
|
2018-05-09 21:59:04 +05:30
|
|
|
{{range .Issue.Assignees}}
|
|
|
|
<div class="item" style="margin-bottom: 10px;">
|
2019-05-08 14:11:35 +05:30
|
|
|
<a href="{{$.RepoLink}}/issues?assignee={{.ID}}"><img class="ui avatar image" src="{{.RelAvatarLink}}"> {{.GetDisplayName}}</a>
|
2018-05-09 21:59:04 +05:30
|
|
|
</div>
|
2017-03-17 11:27:43 +05:30
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
<div class="ui participants">
|
|
|
|
<span class="text"><strong>{{.i18n.Tr "repo.issues.num_participants" .NumParticipants}}</strong></span>
|
|
|
|
<div>
|
|
|
|
{{range .Participants}}
|
2019-03-28 03:52:39 +05:30
|
|
|
<a {{if gt .ID 0}}href="{{.HomeLink}}"{{end}}>
|
2019-05-08 14:11:35 +05:30
|
|
|
<img class="ui avatar image poping up" src="{{.RelAvatarLink}}" data-content="{{.GetDisplayName}}" data-position="top center" data-variation="small inverted">
|
2017-03-17 11:27:43 +05:30
|
|
|
</a>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
2017-03-30 05:01:47 +05:30
|
|
|
|
2019-01-24 00:28:38 +05:30
|
|
|
{{if and $.IssueWatch (not .Repository.IsArchived)}}
|
2017-09-12 12:18:13 +05:30
|
|
|
<div class="ui divider"></div>
|
2017-03-30 05:01:47 +05:30
|
|
|
|
2017-09-12 12:18:13 +05:30
|
|
|
<div class="ui watching">
|
|
|
|
<span class="text"><strong>{{.i18n.Tr "notification.notifications"}}</strong></span>
|
|
|
|
<div>
|
|
|
|
<form method="POST" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/watch">
|
|
|
|
<input type="hidden" name="watch" value="{{if $.IssueWatch.IsWatching}}0{{else}}1{{end}}" />
|
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
<button class="fluid ui button">
|
|
|
|
{{if $.IssueWatch.IsWatching}}
|
2020-02-11 22:32:41 +05:30
|
|
|
{{svg "octicon-mute" 16}}
|
2017-09-12 12:18:13 +05:30
|
|
|
{{.i18n.Tr "repo.issues.unsubscribe"}}
|
|
|
|
{{else}}
|
2020-02-11 22:32:41 +05:30
|
|
|
{{svg "octicon-unmute" 16}}
|
2017-09-12 12:18:13 +05:30
|
|
|
{{.i18n.Tr "repo.issues.subscribe"}}
|
|
|
|
{{end}}
|
|
|
|
</button>
|
|
|
|
</form>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
{{if .Repository.IsTimetrackerEnabled }}
|
2019-01-24 00:28:38 +05:30
|
|
|
{{if and .CanUseTimetracker (not .Repository.IsArchived)}}
|
2017-09-12 12:18:13 +05:30
|
|
|
<div class="ui divider"></div>
|
|
|
|
<div class="ui timetrack">
|
|
|
|
<span class="text"><strong>{{.i18n.Tr "repo.issues.tracker"}}</strong></span>
|
|
|
|
<div>
|
|
|
|
<form method="POST" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/times/stopwatch/toggle" id="toggle_stopwatch_form">
|
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
</form>
|
|
|
|
<form method="POST" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/times/stopwatch/cancel" id="cancel_stopwatch_form">
|
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
</form>
|
|
|
|
{{if $.IsStopwatchRunning}}
|
|
|
|
<div class="ui buttons fluid stop-cancel">
|
2019-11-13 20:22:13 +05:30
|
|
|
<button onclick="this.disabled=true;window.toggleStopwatch()" class="ui button stop">{{.i18n.Tr "repo.issues.stop_tracking"}}</button>
|
|
|
|
<button onclick="this.disabled=true;window.cancelStopwatch()" class="ui negative button cancel">{{.i18n.Tr "repo.issues.cancel_tracking"}}</button>
|
2017-09-12 12:18:13 +05:30
|
|
|
</div>
|
2017-03-30 05:01:47 +05:30
|
|
|
{{else}}
|
2017-09-12 12:18:13 +05:30
|
|
|
{{if .HasUserStopwatch}}
|
|
|
|
<div class="ui warning message">
|
|
|
|
{{.i18n.Tr "repo.issues.tracking_already_started" .OtherStopwatchURL | Safe}}
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
<div class="ui buttons two fluid start-add">
|
2019-11-13 20:22:13 +05:30
|
|
|
<button onclick="this.disabled=true;window.toggleStopwatch()" class="ui button poping up start" data-content='{{.i18n.Tr "repo.issues.start_tracking"}}' data-position="top center" data-variation="small inverted">{{.i18n.Tr "repo.issues.start_tracking_short"}}</button>
|
|
|
|
<button onclick="window.timeAddManual()" class="ui button green poping up add-time" data-content='{{.i18n.Tr "repo.issues.add_time"}}' data-position="top center" data-variation="small inverted">{{.i18n.Tr "repo.issues.add_time_short"}}</button>
|
2017-09-12 12:18:13 +05:30
|
|
|
<div class="ui mini modal">
|
|
|
|
<div class="header">{{.i18n.Tr "repo.issues.add_time"}}</div>
|
|
|
|
<div class="content">
|
|
|
|
<form method="POST" id="add_time_manual_form" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/times/add" class="ui action input fluid">
|
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
<input placeholder='{{.i18n.Tr "repo.issues.add_time_hours"}}' type="number" name="hours">
|
|
|
|
<input placeholder='{{.i18n.Tr "repo.issues.add_time_minutes"}}' type="number" name="minutes" class="ui compact">
|
|
|
|
</form>
|
|
|
|
</div>
|
|
|
|
<div class="actions">
|
|
|
|
<div class="ui green approve button">{{.i18n.Tr "repo.issues.add_time_short"}}</div>
|
|
|
|
<div class="ui red cancel button">{{.i18n.Tr "repo.issues.add_time_cancel"}}</div>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
</div>
|
2017-03-30 05:01:47 +05:30
|
|
|
{{end}}
|
2017-09-12 12:18:13 +05:30
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
{{if gt (len .WorkingUsers) 0}}
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
<div class="ui participants comments">
|
2018-04-29 11:28:47 +05:30
|
|
|
<span class="text"><strong>{{.i18n.Tr "repo.issues.time_spent_from_all_authors" ($.Issue.TotalTrackedTime | Sec2Time) | Safe}}</strong></span>
|
2017-09-12 12:18:13 +05:30
|
|
|
<div>
|
|
|
|
{{range $user, $trackedtime := .WorkingUsers}}
|
|
|
|
<div class="comment">
|
|
|
|
<a class="avatar">
|
|
|
|
<img src="{{$user.RelAvatarLink}}">
|
|
|
|
</a>
|
|
|
|
<div class="content">
|
|
|
|
<a class="author">{{$user.DisplayName}}</a>
|
|
|
|
<div class="text">
|
|
|
|
{{$trackedtime}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
2017-04-29 11:22:25 +05:30
|
|
|
{{end}}
|
2018-05-02 00:35:28 +05:30
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
<span class="text"><strong>{{.i18n.Tr "repo.issues.due_date"}}</strong></span>
|
2018-07-16 18:13:00 +05:30
|
|
|
<div class="ui form" id="deadline-loader">
|
|
|
|
<div class="ui negative message" id="deadline-err-invalid-date" style="display: none;">
|
|
|
|
<i class="close icon"></i>
|
|
|
|
{{.i18n.Tr "repo.issues.due_date_invalid"}}
|
|
|
|
</div>
|
|
|
|
{{if ne .Issue.DeadlineUnix 0}}
|
|
|
|
<p>
|
2020-02-11 22:32:41 +05:30
|
|
|
{{svg "octicon-calendar" 16}}
|
2018-07-16 18:13:00 +05:30
|
|
|
{{.Issue.DeadlineUnix.FormatShort}}
|
|
|
|
{{if .Issue.IsOverdue}}
|
|
|
|
<span style="color: red;">{{.i18n.Tr "repo.issues.due_date_overdue"}}</span>
|
2018-05-02 00:35:28 +05:30
|
|
|
{{end}}
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
|
2018-07-16 18:13:00 +05:30
|
|
|
<br/>
|
2019-11-13 20:22:13 +05:30
|
|
|
<a style="cursor:pointer;" onclick="window.toggleDeadlineForm();"><i class="edit icon"></i>{{$.i18n.Tr "repo.issues.due_date_form_edit"}}</a> -
|
2019-11-14 23:28:32 +05:30
|
|
|
<a style="cursor:pointer;" onclick="window.updateDeadline('');"><i class="remove icon"></i>{{$.i18n.Tr "repo.issues.due_date_form_remove"}}</a>
|
2018-07-16 18:13:00 +05:30
|
|
|
{{end}}
|
|
|
|
</p>
|
|
|
|
{{else}}
|
|
|
|
<p><i>{{.i18n.Tr "repo.issues.due_date_not_set"}}</i></p>
|
|
|
|
{{end}}
|
2018-05-02 00:35:28 +05:30
|
|
|
|
2020-04-04 11:09:48 +05:30
|
|
|
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
|
2018-07-16 18:13:00 +05:30
|
|
|
<div {{if ne .Issue.DeadlineUnix 0}} style="display: none;"{{end}} id="deadlineForm">
|
2019-11-13 20:22:13 +05:30
|
|
|
<form class="ui fluid action input" action="{{AppSubUrl}}/api/v1/repos/{{.Repository.Owner.Name}}/{{.Repository.Name}}/issues/{{.Issue.Index}}" method="post" id="update-issue-deadline-form" onsubmit="window.setDeadline();return false;">
|
2018-07-16 18:13:00 +05:30
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
<input required placeholder="{{.i18n.Tr "repo.issues.due_date_form"}}" {{if gt .Issue.DeadlineUnix 0}}value="{{.Issue.DeadlineUnix.Format "2006-01-02"}}"{{end}} type="date" name="deadlineDate" id="deadlineDate">
|
|
|
|
<button class="ui green icon button">
|
|
|
|
{{if ne .Issue.DeadlineUnix 0}}
|
|
|
|
<i class="edit icon"></i>
|
|
|
|
{{else}}
|
|
|
|
<i class="plus icon"></i>
|
|
|
|
{{end}}
|
|
|
|
</button>
|
|
|
|
</form>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
2018-07-18 02:53:58 +05:30
|
|
|
|
|
|
|
{{if .Repository.IsDependenciesEnabled}}
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
<div class="ui depending">
|
2018-09-07 08:02:46 +05:30
|
|
|
{{if (and (not .BlockedByDependencies) (not .BlockingDependencies))}}
|
|
|
|
<span class="text"><strong>{{.i18n.Tr "repo.issues.dependency.title"}}</strong></span>
|
|
|
|
<br>
|
|
|
|
<p>{{if .Issue.IsPull}}
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.pr_no_dependencies"}}
|
|
|
|
{{else}}
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.issue_no_dependencies"}}
|
|
|
|
{{end}}</p>
|
|
|
|
{{end}}
|
|
|
|
|
|
|
|
{{if .BlockingDependencies}}
|
2018-07-18 02:53:58 +05:30
|
|
|
<span class="text" data-tooltip="{{if .Issue.IsPull}}
|
2018-09-07 08:02:46 +05:30
|
|
|
{{.i18n.Tr "repo.issues.dependency.pr_close_blocks"}}
|
|
|
|
{{else}}
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.issue_close_blocks"}}
|
|
|
|
{{end}}" data-inverted="">
|
|
|
|
<strong>{{.i18n.Tr "repo.issues.dependency.blocks_short"}}</strong>
|
2018-07-18 02:53:58 +05:30
|
|
|
</span>
|
|
|
|
<div class="ui relaxed divided list">
|
2018-09-07 08:02:46 +05:30
|
|
|
{{range .BlockingDependencies}}
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 10:36:10 +05:30
|
|
|
<div class="item{{if .Issue.IsClosed}} is-closed{{end}}">
|
|
|
|
<span class="text grey right floated">#{{.Issue.Index}}</span>
|
|
|
|
<a class="title has-emoji" href="{{.Repository.Link}}/issues/{{.Issue.Index}}">{{.Issue.Title}}</a>
|
|
|
|
<div class="text small">{{.Repository.OwnerName}}/{{.Repository.Name}}</div>
|
|
|
|
<div class="ui transparent label right floated nopadding">
|
2019-01-24 00:28:38 +05:30
|
|
|
{{if and $.CanCreateIssueDependencies (not $.Repository.IsArchived)}}
|
2019-11-13 20:22:13 +05:30
|
|
|
<a class="delete-dependency-button" onclick="window.deleteDependencyModal({{.Issue.ID}}, 'blocking');"
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 10:36:10 +05:30
|
|
|
data-tooltip="{{$.i18n.Tr "repo.issues.dependency.remove_info"}}" data-inverted="">
|
|
|
|
<i class="delete icon text red nopadding nomargin"></i>
|
2018-07-18 02:53:58 +05:30
|
|
|
</a>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
|
2018-09-07 08:02:46 +05:30
|
|
|
{{if .BlockedByDependencies}}
|
2018-07-18 02:53:58 +05:30
|
|
|
<span class="text" data-tooltip="{{if .Issue.IsPull}}
|
2018-09-07 08:02:46 +05:30
|
|
|
{{.i18n.Tr "repo.issues.dependency.pr_closing_blockedby"}}
|
2019-11-30 00:35:49 +05:30
|
|
|
{{else}}
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.issue_closing_blockedby"}}
|
2018-09-07 08:02:46 +05:30
|
|
|
{{end}}" data-inverted="">
|
|
|
|
<strong>{{.i18n.Tr "repo.issues.dependency.blocked_by_short"}}</strong>
|
2018-07-18 02:53:58 +05:30
|
|
|
</span>
|
|
|
|
<div class="ui relaxed divided list">
|
2018-09-07 08:02:46 +05:30
|
|
|
{{range .BlockedByDependencies}}
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 10:36:10 +05:30
|
|
|
<div class="item{{if .Issue.IsClosed}} is-closed{{end}}">
|
|
|
|
<span class="text grey right floated">#{{.Issue.Index}}</span>
|
|
|
|
<a class="title has-emoji" href="{{.Repository.Link}}/issues/{{.Issue.Index}}">{{.Issue.Title}}</a>
|
|
|
|
<div class="text small">{{.Repository.OwnerName}}/{{.Repository.Name}}</div>
|
|
|
|
<div class="ui transparent label right floated nopadding">
|
|
|
|
{{if and $.CanCreateIssueDependencies (not $.Repository.IsArchived)}}
|
2019-11-13 20:22:13 +05:30
|
|
|
<a class="delete-dependency-button" onclick="window.deleteDependencyModal({{.Issue.ID}}, 'blockedBy');"
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 10:36:10 +05:30
|
|
|
data-tooltip="{{$.i18n.Tr "repo.issues.dependency.remove_info"}}" data-inverted="">
|
|
|
|
<i class="delete icon text red nopadding nomargin"></i>
|
2018-07-18 02:53:58 +05:30
|
|
|
</a>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
|
2019-01-24 00:28:38 +05:30
|
|
|
{{if and .CanCreateIssueDependencies (not .Repository.IsArchived)}}
|
2018-07-18 02:53:58 +05:30
|
|
|
<div>
|
|
|
|
<form method="POST" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/dependency/add" id="addDependencyForm">
|
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
<div class="ui fluid action input">
|
2019-05-12 16:40:12 +05:30
|
|
|
<div class="ui search selection dropdown" id="new-dependency-drop-list" data-issue-id="{{.Issue.ID}}">
|
2018-07-18 02:53:58 +05:30
|
|
|
<input name="newDependency" type="hidden">
|
|
|
|
<i class="dropdown icon"></i>
|
|
|
|
<input type="text" class="search">
|
|
|
|
<div class="default text">{{.i18n.Tr "repo.issues.dependency.add"}}</div>
|
|
|
|
</div>
|
|
|
|
<button class="ui green icon button">
|
|
|
|
<i class="plus icon"></i>
|
|
|
|
</button>
|
|
|
|
</div>
|
|
|
|
</form>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
2019-02-19 02:25:04 +05:30
|
|
|
|
2019-06-29 14:48:49 +05:30
|
|
|
{{ if and .IsRepoAdmin (not .Repository.IsArchived) }}
|
2019-02-19 02:25:04 +05:30
|
|
|
<div class="ui divider"></div>
|
|
|
|
<div class="ui watching">
|
|
|
|
<div>
|
|
|
|
<button class="fluid ui show-modal button {{if .Issue.IsLocked }} negative {{ end }}" data-modal="#lock">
|
|
|
|
{{if .Issue.IsLocked}}
|
2020-02-11 22:32:41 +05:30
|
|
|
{{svg "octicon-key" 16}}
|
2019-02-19 02:25:04 +05:30
|
|
|
{{.i18n.Tr "repo.issues.unlock"}}
|
|
|
|
{{else}}
|
2020-02-11 22:32:41 +05:30
|
|
|
{{svg "octicon-lock" 16}}
|
2019-02-19 02:25:04 +05:30
|
|
|
{{.i18n.Tr "repo.issues.lock"}}
|
|
|
|
{{end}}
|
|
|
|
</button>
|
|
|
|
</form>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
|
|
|
|
|
|
|
|
<div class="ui tiny modal" id="lock">
|
|
|
|
<div class="header">
|
|
|
|
{{ if .Issue.IsLocked }}
|
|
|
|
{{.i18n.Tr "repo.issues.unlock.title"}}
|
|
|
|
{{ else }}
|
|
|
|
{{.i18n.Tr "repo.issues.lock.title"}}
|
|
|
|
{{ end }}
|
|
|
|
</div>
|
|
|
|
<div class="content">
|
|
|
|
<div class="ui warning message text left">
|
|
|
|
{{ if .Issue.IsLocked }}
|
|
|
|
{{.i18n.Tr "repo.issues.unlock.notice_1"}}<br>
|
|
|
|
{{.i18n.Tr "repo.issues.unlock.notice_2"}}<br>
|
|
|
|
{{ else }}
|
|
|
|
{{.i18n.Tr "repo.issues.lock.notice_1"}}<br>
|
|
|
|
{{.i18n.Tr "repo.issues.lock.notice_2"}}<br>
|
|
|
|
{{.i18n.Tr "repo.issues.lock.notice_3"}}<br>
|
|
|
|
{{ end }}
|
|
|
|
</div>
|
|
|
|
|
|
|
|
<form class="ui form" action="{{$.RepoLink}}/issues/{{.Issue.Index}}{{ if .Issue.IsLocked }}/unlock{{ else }}/lock{{ end }}"
|
|
|
|
method="post">
|
|
|
|
{{.CsrfTokenHtml}}
|
|
|
|
|
|
|
|
{{ if not .Issue.IsLocked }}
|
|
|
|
<div class="field">
|
|
|
|
<strong> {{ .i18n.Tr "repo.issues.lock.reason" }} </strong>
|
|
|
|
</div>
|
|
|
|
|
|
|
|
<div class="field">
|
|
|
|
<div class="ui fluid dropdown selection" tabindex="0">
|
|
|
|
|
|
|
|
<select name="reason">
|
|
|
|
<option value=""> </option>
|
|
|
|
{{range .LockReasons}}
|
|
|
|
<option value="{{.}}">{{.}}</option>
|
|
|
|
{{end}}
|
|
|
|
</select>
|
|
|
|
<i class="dropdown icon"></i>
|
|
|
|
|
|
|
|
<div class="default text"> </div>
|
|
|
|
|
|
|
|
<div class="menu transition hidden" tabindex="-1" style="display: block !important;">
|
|
|
|
{{range .LockReasons}}
|
|
|
|
<div class="item" data-value="{{.}}">{{.}}</div>
|
|
|
|
{{end}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{ end }}
|
|
|
|
|
|
|
|
<div class="text right actions">
|
|
|
|
<div class="ui cancel button">{{.i18n.Tr "settings.cancel"}}</div>
|
|
|
|
<button class="ui red button">
|
|
|
|
{{ if .Issue.IsLocked }}
|
|
|
|
{{.i18n.Tr "repo.issues.unlock_confirm"}}
|
|
|
|
{{ else }}
|
|
|
|
{{.i18n.Tr "repo.issues.lock_confirm"}}
|
|
|
|
{{ end }}
|
|
|
|
</button>
|
|
|
|
</div>
|
|
|
|
</form>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{ end }}
|
|
|
|
|
2017-03-17 11:27:43 +05:30
|
|
|
</div>
|
|
|
|
</div>
|
2019-01-24 00:28:38 +05:30
|
|
|
{{if and .CanCreateIssueDependencies (not .Repository.IsArchived)}}
|
2018-11-25 22:55:55 +05:30
|
|
|
<input type="hidden" id="repolink" value="{{$.RepoRelPath}}">
|
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 10:36:10 +05:30
|
|
|
<input type="hidden" id="repoId" value="{{.Repository.ID}}">
|
|
|
|
<input type="hidden" id="crossRepoSearch" value="{{.AllowCrossRepositoryDependencies}}">
|
2020-01-19 12:13:38 +05:30
|
|
|
<input type="hidden" id="type" value="{{.IssueType}}">
|
2018-07-18 02:53:58 +05:30
|
|
|
<!-- I know, there is probably a better way to do this -->
|
|
|
|
<input type="hidden" id="issueIndex" value="{{.Issue.Index}}"/>
|
|
|
|
|
|
|
|
<div class="ui basic modal remove-dependency">
|
|
|
|
<div class="ui icon header">
|
|
|
|
<i class="trash icon"></i>
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.remove_header"}}
|
|
|
|
</div>
|
|
|
|
<div class="content">
|
|
|
|
<form method="POST" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/dependency/delete" id="removeDependencyForm">
|
|
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
<input type="hidden" value="" name="removeDependencyID" id="removeDependencyID"/>
|
|
|
|
<input type="hidden" value="" name="dependencyType" id="dependencyType"/>
|
|
|
|
</form>
|
|
|
|
<p>{{if .Issue.IsPull}}
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.pr_remove_text"}}
|
|
|
|
{{else}}
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.issue_remove_text"}}
|
|
|
|
{{end}}</p>
|
|
|
|
</div>
|
|
|
|
<div class="actions">
|
|
|
|
<div class="ui basic red cancel inverted button">
|
|
|
|
<i class="remove icon"></i>
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.cancel"}}
|
|
|
|
</div>
|
|
|
|
<div class="ui basic green ok inverted button">
|
|
|
|
<i class="checkmark icon"></i>
|
|
|
|
{{.i18n.Tr "repo.issues.dependency.remove"}}
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
{{end}}
|
|
|
|
{{end}}
|