2022-08-26 03:25:52 +05:30
|
|
|
{{$index := 0}}
|
2020-05-24 03:35:20 +05:30
|
|
|
<div class="timeline-item commits-list">
|
2021-08-09 23:38:51 +05:30
|
|
|
{{range .comment.Commits}}
|
2022-08-26 03:25:52 +05:30
|
|
|
{{$tag := printf "%s-%d" $.comment.HashTag $index}}
|
Use a general Eval function for expressions in templates. (#23927)
One of the proposals in #23328
This PR introduces a simple expression calculator
(templates/eval/eval.go), it can do basic expression calculations.
Many untested template helper functions like `Mul` `Add` can be replaced
by this new approach.
Then these `Add` / `Mul` / `percentage` / `Subtract` / `DiffStatsWidth`
could all use this `Eval`.
And it provides enhancements for Golang templates, and improves
readability.
Some examples:
----
* Before: `{{Add (Mul $glyph.Row 12) 12}}`
* After: `{{Eval $glyph.Row "*" 12 "+" 12}}`
----
* Before: `{{if lt (Add $i 1) (len $.Topics)}}`
* After: `{{if Eval $i "+" 1 "<" (len $.Topics)}}`
## FAQ
### Why not use an existing expression package?
We need a highly customized expression engine:
* do the calculation on the fly, without pre-compiling
* deal with int/int64/float64 types, to make the result could be used in
Golang template.
* make the syntax could be used in the Golang template directly
* do not introduce too much complex or strange syntax, we just need a
simple calculator.
* it needs to strictly follow Golang template's behavior, for example,
Golang template treats all non-zero values as truth, but many 3rd
packages don't do so.
### What's the benefit?
* Developers don't need to add more `Add`/`Mul`/`Sub`-like functions,
they were getting more and more.
Now, only one `Eval` is enough for all cases.
* The new code reads better than old `{{Add (Mul $glyph.Row 12) 12}}`,
the old one isn't familiar to most procedural programming developers
(eg, the Golang expression syntax).
* The `Eval` is fully covered by tests, many old `Add`/`Mul`-like
functions were never tested.
### The performance?
It doesn't use `reflect`, it doesn't need to parse or compile when used
in Golang template, the performance is as fast as native Go template.
### Is it too complex? Could it be unstable?
The expression calculator program is a common homework for computer
science students, and it's widely used as a teaching and practicing
purpose for developers. The algorithm is pretty well-known.
The behavior can be clearly defined, it is stable.
2023-04-07 18:55:49 +05:30
|
|
|
{{$index = Eval $index "+" 1}}
|
2020-05-24 03:35:20 +05:30
|
|
|
<div class="singular-commit" id="{{$tag}}">
|
2020-09-12 01:49:00 +05:30
|
|
|
<span class="badge badge-commit">{{svg "octicon-git-commit"}}</span>
|
2020-05-20 18:17:24 +05:30
|
|
|
{{if .User}}
|
2023-08-10 08:49:39 +05:30
|
|
|
<a class="avatar" href="{{.User.HomeLink}}">{{ctx.AvatarUtils.Avatar .User}}</a>
|
2020-05-20 18:17:24 +05:30
|
|
|
{{else}}
|
2023-08-10 08:49:39 +05:30
|
|
|
{{ctx.AvatarUtils.AvatarByEmail .Author.Email .Author.Name}}
|
2020-05-20 18:17:24 +05:30
|
|
|
{{end}}
|
|
|
|
|
|
2023-03-27 20:14:51 +05:30
|
|
|
{{$commitLink:= printf "%s/commit/%s" $.comment.Issue.PullRequest.BaseRepo.Link (PathEscape .ID.String)}}
|
|
|
|
|
|
2023-08-31 07:59:59 +05:30
|
|
|
<span class="shabox gt-df gt-ac gt-float-right">
|
2021-08-09 23:38:51 +05:30
|
|
|
{{template "repo/commit_statuses" dict "Status" .Status "Statuses" .Statuses "root" $.root}}
|
2020-05-20 18:17:24 +05:30
|
|
|
{{$class := "ui sha label"}}
|
|
|
|
|
{{if .Signature}}
|
|
|
|
|
{{$class = (printf "%s%s" $class " isSigned")}}
|
|
|
|
|
{{if .Verification.Verified}}
|
|
|
|
|
{{if eq .Verification.TrustStatus "trusted"}}
|
|
|
|
|
{{$class = (printf "%s%s" $class " isVerified")}}
|
|
|
|
|
{{else if eq .Verification.TrustStatus "untrusted"}}
|
|
|
|
|
{{$class = (printf "%s%s" $class " isVerifiedUntrusted")}}
|
|
|
|
|
{{else}}
|
|
|
|
|
{{$class = (printf "%s%s" $class " isVerifiedUnmatched")}}
|
|
|
|
|
{{end}}
|
|
|
|
|
{{else if .Verification.Warning}}
|
|
|
|
|
{{$class = (printf "%s%s" $class " isWarning")}}
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
2023-05-14 19:45:59 +05:30
|
|
|
<a href="{{$commitLink}}" rel="nofollow" class="gt-ml-3 {{$class}}">
|
2023-03-27 20:14:51 +05:30
|
|
|
<span class="shortsha">{{ShortSha .ID.String}}</span>
|
|
|
|
|
{{if .Signature}}
|
|
|
|
|
{{template "repo/shabox_badge" dict "root" $.root "verification" .Verification}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</a>
|
2020-05-20 18:17:24 +05:30
|
|
|
</span>
|
|
|
|
|
|
2023-02-13 23:29:59 +05:30
|
|
|
<span class="gt-mono commit-summary {{if gt .ParentCount 1}} grey text{{end}}" title="{{.Summary}}">{{RenderCommitMessageLinkSubject $.root.Context .Message ($.comment.Issue.PullRequest.BaseRepo.Link|Escape) $commitLink $.comment.Issue.PullRequest.BaseRepo.ComposeMetas}}</span>
|
2020-05-20 18:17:24 +05:30
|
|
|
{{if IsMultilineCommitMessage .Message}}
|
2023-07-27 16:17:41 +05:30
|
|
|
<button class="ui button js-toggle-commit-body ellipsis-button" aria-expanded="false">...</button>
|
2020-05-20 18:17:24 +05:30
|
|
|
{{end}}
|
|
|
|
|
{{if IsMultilineCommitMessage .Message}}
|
2023-02-19 09:36:14 +05:30
|
|
|
<pre class="commit-body gt-hidden">{{RenderCommitBody $.root.Context .Message ($.comment.Issue.PullRequest.BaseRepo.Link|Escape) $.comment.Issue.PullRequest.BaseRepo.ComposeMetas}}</pre>
|
2020-05-20 18:17:24 +05:30
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2020-05-24 03:35:20 +05:30
|
|
|
</div>
|
