2020-09-05 22:12:58 +05:30
// Copyright 2020 The Gitea Authors. All rights reserved.
2016-11-04 03:46:01 +05:30
// Copyright 2015 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package git
import (
"bytes"
2017-04-08 07:53:39 +05:30
"context"
2016-11-04 03:46:01 +05:30
"fmt"
"io"
2019-11-10 14:12:51 +05:30
"os"
2016-11-04 03:46:01 +05:30
"os/exec"
"strings"
"time"
2019-06-26 23:45:26 +05:30
"code.gitea.io/gitea/modules/process"
2016-11-04 03:46:01 +05:30
)
2016-12-22 15:00:52 +05:30
var (
// GlobalCommandArgs global command args for external package setting
GlobalCommandArgs [ ] string
2018-01-07 18:40:20 +05:30
// DefaultCommandExecutionTimeout default command execution timeout duration
2020-03-03 06:43:01 +05:30
DefaultCommandExecutionTimeout = 360 * time . Second
2016-12-22 15:00:52 +05:30
)
2019-11-10 14:12:51 +05:30
// DefaultLocale is the default LC_ALL to run git commands in.
const DefaultLocale = "C"
2016-11-04 03:46:01 +05:30
// Command represents a command with its subcommands or arguments.
type Command struct {
2019-11-30 20:10:22 +05:30
name string
args [ ] string
parentContext context . Context
desc string
2016-11-04 03:46:01 +05:30
}
func ( c * Command ) String ( ) string {
if len ( c . args ) == 0 {
return c . name
}
return fmt . Sprintf ( "%s %s" , c . name , strings . Join ( c . args , " " ) )
}
// NewCommand creates and returns a new Git Command based on given command and arguments.
func NewCommand ( args ... string ) * Command {
2020-05-17 05:01:38 +05:30
return NewCommandContext ( DefaultContext , args ... )
}
// NewCommandContext creates and returns a new Git Command based on given command and arguments.
func NewCommandContext ( ctx context . Context , args ... string ) * Command {
2018-11-28 12:30:25 +05:30
// Make an explicit copy of GlobalCommandArgs, otherwise append might overwrite it
cargs := make ( [ ] string , len ( GlobalCommandArgs ) )
copy ( cargs , GlobalCommandArgs )
2016-11-04 03:46:01 +05:30
return & Command {
2019-11-30 20:10:22 +05:30
name : GitExecutable ,
args : append ( cargs , args ... ) ,
2020-05-17 05:01:38 +05:30
parentContext : ctx ,
2016-11-04 03:46:01 +05:30
}
}
2019-11-27 06:05:52 +05:30
// NewCommandNoGlobals creates and returns a new Git Command based on given command and arguments only with the specify args and don't care global command args
func NewCommandNoGlobals ( args ... string ) * Command {
2020-05-17 05:01:38 +05:30
return NewCommandContextNoGlobals ( DefaultContext , args ... )
}
// NewCommandContextNoGlobals creates and returns a new Git Command based on given command and arguments only with the specify args and don't care global command args
func NewCommandContextNoGlobals ( ctx context . Context , args ... string ) * Command {
2019-11-27 06:05:52 +05:30
return & Command {
2019-11-30 20:10:22 +05:30
name : GitExecutable ,
args : args ,
2020-05-17 05:01:38 +05:30
parentContext : ctx ,
2019-11-27 06:05:52 +05:30
}
}
2019-11-30 20:10:22 +05:30
// SetParentContext sets the parent context for this command
func ( c * Command ) SetParentContext ( ctx context . Context ) * Command {
c . parentContext = ctx
return c
}
// SetDescription sets the description for this command which be returned on
// c.String()
func ( c * Command ) SetDescription ( desc string ) * Command {
c . desc = desc
return c
}
2016-11-04 03:46:01 +05:30
// AddArguments adds new argument(s) to the command.
func ( c * Command ) AddArguments ( args ... string ) * Command {
c . args = append ( c . args , args ... )
return c
}
2019-05-11 20:59:17 +05:30
// RunInDirTimeoutEnvPipeline executes the command in given directory with given timeout,
2016-11-04 03:46:01 +05:30
// it pipes stdout and stderr to given io.Writer.
2019-05-11 20:59:17 +05:30
func ( c * Command ) RunInDirTimeoutEnvPipeline ( env [ ] string , timeout time . Duration , dir string , stdout , stderr io . Writer ) error {
return c . RunInDirTimeoutEnvFullPipeline ( env , timeout , dir , stdout , stderr , nil )
}
// RunInDirTimeoutEnvFullPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer and passes in an io.Reader as stdin.
func ( c * Command ) RunInDirTimeoutEnvFullPipeline ( env [ ] string , timeout time . Duration , dir string , stdout , stderr io . Writer , stdin io . Reader ) error {
2019-11-11 17:16:28 +05:30
return c . RunInDirTimeoutEnvFullPipelineFunc ( env , timeout , dir , stdout , stderr , stdin , nil )
}
// RunInDirTimeoutEnvFullPipelineFunc executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer and passes in an io.Reader as stdin. Between cmd.Start and cmd.Wait the passed in function is run.
2020-01-15 14:02:57 +05:30
func ( c * Command ) RunInDirTimeoutEnvFullPipelineFunc ( env [ ] string , timeout time . Duration , dir string , stdout , stderr io . Writer , stdin io . Reader , fn func ( context . Context , context . CancelFunc ) error ) error {
2016-11-04 03:46:01 +05:30
if timeout == - 1 {
2018-01-07 18:40:20 +05:30
timeout = DefaultCommandExecutionTimeout
2016-11-04 03:46:01 +05:30
}
if len ( dir ) == 0 {
log ( c . String ( ) )
} else {
log ( "%s: %v" , dir , c )
}
2019-11-30 20:10:22 +05:30
ctx , cancel := context . WithTimeout ( c . parentContext , timeout )
2017-04-08 07:53:39 +05:30
defer cancel ( )
cmd := exec . CommandContext ( ctx , c . name , c . args ... )
2019-11-10 14:12:51 +05:30
if env == nil {
cmd . Env = append ( os . Environ ( ) , fmt . Sprintf ( "LC_ALL=%s" , DefaultLocale ) )
} else {
cmd . Env = env
cmd . Env = append ( cmd . Env , fmt . Sprintf ( "LC_ALL=%s" , DefaultLocale ) )
}
Disable new signal-based asynchronous goroutine preemption from GO 1.14 in git env (#11237)
As seen in trouble shooting #11032 the new feature of Go 1.14 is causing several second delays in startup in certain situations. Debugging shows it spending several seconds handling SIGURG commands during init:
```
6922:04:51.984234 trace init() ./modules/queue/unique_queue_wrapped.go
remote: ) = 69 <0.000012>
remote: [pid 15984] 22:04:51 write(1, "\ttime taken: 236.761\302\265s\n\n", 25 time taken: 236.761µs
remote:
remote: ) = 25 <0.000011>
remote: [pid 15984] 22:04:51 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
remote: [pid 15984] 22:04:52 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
remote: [pid 15984] 22:04:52 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
```
This causes up to 20 seconds added to a push in some cases as it happens for each call of the gitea hook command. This is likely the cause of #10661 as well and would start to effect users once we release 1.12 which would be the first release compiled with Go 1.14. I suspect this is just a slight issue with the upstream implementatation as there have been a few very similar bugs fixed and reported:
https://github.com/golang/go/issues/37741
https://github.com/golang/go/issues/37942
We should revisit this in the future and see if a newer version of Go has solved it, but for now disable this option in the environment that gitea hook runs in to avoid it.
2020-04-28 21:15:32 +05:30
2020-08-13 19:41:24 +05:30
// TODO: verify if this is still needed in golang 1.15
2020-09-05 22:12:58 +05:30
if goVersionLessThan115 {
2020-09-05 00:29:19 +05:30
cmd . Env = append ( cmd . Env , "GODEBUG=asyncpreemptoff=1" )
}
2016-11-04 03:46:01 +05:30
cmd . Dir = dir
cmd . Stdout = stdout
cmd . Stderr = stderr
2019-05-11 20:59:17 +05:30
cmd . Stdin = stdin
2016-11-04 03:46:01 +05:30
if err := cmd . Start ( ) ; err != nil {
return err
}
2019-11-30 20:10:22 +05:30
desc := c . desc
if desc == "" {
desc = fmt . Sprintf ( "%s %s %s [repo_path: %s]" , GitExecutable , c . name , strings . Join ( c . args , " " ) , dir )
}
pid := process . GetManager ( ) . Add ( desc , cancel )
2019-06-26 23:45:26 +05:30
defer process . GetManager ( ) . Remove ( pid )
2019-11-11 17:16:28 +05:30
if fn != nil {
2020-01-15 14:02:57 +05:30
err := fn ( ctx , cancel )
if err != nil {
cancel ( )
return err
}
2019-11-11 17:16:28 +05:30
}
2019-12-13 14:33:38 +05:30
if err := cmd . Wait ( ) ; err != nil && ctx . Err ( ) != context . DeadlineExceeded {
2017-05-30 15:02:01 +05:30
return err
}
return ctx . Err ( )
2016-11-04 03:46:01 +05:30
}
2019-05-11 20:59:17 +05:30
// RunInDirTimeoutPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirTimeoutPipeline ( timeout time . Duration , dir string , stdout , stderr io . Writer ) error {
return c . RunInDirTimeoutEnvPipeline ( nil , timeout , dir , stdout , stderr )
}
// RunInDirTimeoutFullPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer, and stdin from the given io.Reader
func ( c * Command ) RunInDirTimeoutFullPipeline ( timeout time . Duration , dir string , stdout , stderr io . Writer , stdin io . Reader ) error {
return c . RunInDirTimeoutEnvFullPipeline ( nil , timeout , dir , stdout , stderr , stdin )
}
2016-11-04 03:46:01 +05:30
// RunInDirTimeout executes the command in given directory with given timeout,
// and returns stdout in []byte and error (combined with stderr).
func ( c * Command ) RunInDirTimeout ( timeout time . Duration , dir string ) ( [ ] byte , error ) {
2019-05-11 20:59:17 +05:30
return c . RunInDirTimeoutEnv ( nil , timeout , dir )
}
// RunInDirTimeoutEnv executes the command in given directory with given timeout,
// and returns stdout in []byte and error (combined with stderr).
func ( c * Command ) RunInDirTimeoutEnv ( env [ ] string , timeout time . Duration , dir string ) ( [ ] byte , error ) {
2016-11-04 03:46:01 +05:30
stdout := new ( bytes . Buffer )
stderr := new ( bytes . Buffer )
2019-05-11 20:59:17 +05:30
if err := c . RunInDirTimeoutEnvPipeline ( env , timeout , dir , stdout , stderr ) ; err != nil {
2016-11-04 03:46:01 +05:30
return nil , concatenateError ( err , stderr . String ( ) )
}
if stdout . Len ( ) > 0 {
log ( "stdout:\n%s" , stdout . Bytes ( ) [ : 1024 ] )
}
return stdout . Bytes ( ) , nil
}
// RunInDirPipeline executes the command in given directory,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirPipeline ( dir string , stdout , stderr io . Writer ) error {
2019-05-11 20:59:17 +05:30
return c . RunInDirFullPipeline ( dir , stdout , stderr , nil )
}
// RunInDirFullPipeline executes the command in given directory,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirFullPipeline ( dir string , stdout , stderr io . Writer , stdin io . Reader ) error {
return c . RunInDirTimeoutFullPipeline ( - 1 , dir , stdout , stderr , stdin )
2016-11-04 03:46:01 +05:30
}
2016-12-22 15:00:52 +05:30
// RunInDirBytes executes the command in given directory
2016-11-04 03:46:01 +05:30
// and returns stdout in []byte and error (combined with stderr).
func ( c * Command ) RunInDirBytes ( dir string ) ( [ ] byte , error ) {
return c . RunInDirTimeout ( - 1 , dir )
}
// RunInDir executes the command in given directory
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) RunInDir ( dir string ) ( string , error ) {
2019-05-11 20:59:17 +05:30
return c . RunInDirWithEnv ( dir , nil )
}
// RunInDirWithEnv executes the command in given directory
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) RunInDirWithEnv ( dir string , env [ ] string ) ( string , error ) {
stdout , err := c . RunInDirTimeoutEnv ( env , - 1 , dir )
2016-11-04 03:46:01 +05:30
if err != nil {
return "" , err
}
return string ( stdout ) , nil
}
2019-03-27 15:03:00 +05:30
// RunTimeout executes the command in default working directory with given timeout,
2016-11-04 03:46:01 +05:30
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) RunTimeout ( timeout time . Duration ) ( string , error ) {
stdout , err := c . RunInDirTimeout ( timeout , "" )
if err != nil {
return "" , err
}
return string ( stdout ) , nil
}
2019-03-27 15:03:00 +05:30
// Run executes the command in default working directory
2016-11-04 03:46:01 +05:30
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) Run ( ) ( string , error ) {
return c . RunTimeout ( - 1 )
}