2022-01-29 02:30:11 +05:30
import $ from 'jquery' ;
2021-10-16 22:58:04 +05:30
import {
2022-12-23 21:33:11 +05:30
initRepoIssueBranchSelect , initRepoIssueCodeCommentCancel , initRepoIssueCommentDelete ,
initRepoIssueComments , initRepoIssueDependencyDelete , initRepoIssueReferenceIssue ,
2023-04-03 15:36:57 +05:30
initRepoIssueTitleEdit , initRepoIssueWipToggle ,
2023-03-03 01:23:22 +05:30
initRepoPullRequestUpdate , updateIssuesMeta , handleReply
2021-10-16 22:58:04 +05:30
} from './repo-issue.js' ;
2022-01-07 06:48:52 +05:30
import { initUnicodeEscapeButton } from './repo-unicode-escape.js' ;
2021-10-16 22:58:04 +05:30
import { svg } from '../svg.js' ;
import { htmlEscape } from 'escape-goat' ;
2023-03-14 15:21:20 +05:30
import { initRepoBranchTagSelector } from '../components/RepoBranchTagSelector.vue' ;
2021-10-16 22:58:04 +05:30
import {
2022-12-23 21:33:11 +05:30
initRepoCloneLink , initRepoCommonBranchOrTagDropdown , initRepoCommonFilterSearchDropdown ,
2021-10-16 22:58:04 +05:30
initRepoCommonLanguageStats ,
} from './repo-common.js' ;
2022-11-11 22:32:50 +05:30
import { initCitationFileCopyContent } from './citation.js' ;
2021-10-16 22:58:04 +05:30
import { initCompLabelEdit } from './comp/LabelEdit.js' ;
import { initRepoDiffConversationNav } from './repo-diff.js' ;
2022-12-23 21:33:11 +05:30
import { createDropzone } from './dropzone.js' ;
2021-10-16 22:58:04 +05:30
import { initCommentContent , initMarkupContent } from '../markup/content.js' ;
import { initCompReactionSelector } from './comp/ReactionSelector.js' ;
import { initRepoSettingBranches } from './repo-settings.js' ;
2022-12-23 21:33:11 +05:30
import { initRepoPullRequestMergeForm } from './repo-issue-pr-form.js' ;
2023-02-19 09:36:14 +05:30
import { hideElem , showElem } from '../utils/dom.js' ;
2023-04-03 15:36:57 +05:30
import { getComboMarkdownEditor , initComboMarkdownEditor } from './comp/ComboMarkdownEditor.js' ;
Append `(comment)` when a link points at a comment rather than the whole issue (#23734)
Close #23671
For the feature mentioned above, this PR append ' (comment)' to the
rendered html if it is a hashcomment.
After the PR, type in the following
```
pull request from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2
pull request from this repo:
http://localhost:3000/aaa/testA/pulls/2
issue comment from this repo:
http://localhost:3000/aaa/testA/issues/1#issuecomment-18
http://localhost:3000/aaa/testA/pulls/2#issue-9
issue comment from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issuecomment-24
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issue
```
Gives:
<img width="687" alt="截屏2023-03-27 13 53 06"
src="https://user-images.githubusercontent.com/17645053/227852387-2b218e0d-3468-4d90-ad81-d702ddd17fd2.png">
Other than the above feature, this PR also includes two other changes:
1 Right now, the render of links from file changed tab in pull request
might not be very proper, for example, if type in the following. (not
sure if this is an issue or design, if not an issue, I will revert the
changes). example on
[try.gitea.io](https://try.gitea.io/HesterG/testrepo/pulls/1)
```
https://try.gitea.io/HesterG/testrepo/pulls/1/files#issuecomment-162725
https://try.gitea.io/HesterG/testrepo/pulls/1/files
```
it will render the following
<img width="899" alt="截屏2023-03-24 15 41 37"
src="https://user-images.githubusercontent.com/17645053/227456117-5eccedb7-9118-4540-929d-aee9a76de852.png">
In this PR, skip processing the link into a ref issue if it is a link
from files changed tab in pull request
After:
type in following
```
hash comment on files changed tab:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files#issuecomment-24
files changed link:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files
```
Gives
<img width="708" alt="截屏2023-03-27 22 09 02"
src="https://user-images.githubusercontent.com/17645053/227964273-5dc06c50-3713-489c-b05d-d95367d0ab0f.png">
2 Right now, after editing the comment area, there will not be tippys
attached to `ref-issue`; and no tippy attached on preview as well.
example:
https://user-images.githubusercontent.com/17645053/227850540-5ae34e2d-b1d7-4d0d-9726-7701bf825d1f.mov
In this PR, in frontend, make sure tippy is added after editing the
comment, and to the comment on preview tab
After:
https://user-images.githubusercontent.com/17645053/227853777-06f56b4c-1148-467c-b6f7-f79418e67504.mov
2023-04-03 13:32:57 +05:30
import { attachRefIssueContextPopup } from './contextpopup.js' ;
2021-10-16 22:58:04 +05:30
2021-10-21 13:07:43 +05:30
const { csrfToken } = window . config ;
2021-10-16 22:58:04 +05:30
2023-04-03 15:36:57 +05:30
// if there are draft comments, confirm before reloading, to avoid losing comments
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
function reloadConfirmDraftComment ( ) {
const commentTextareas = [
document . querySelector ( '.edit-content-zone:not(.gt-hidden) textarea' ) ,
2023-04-03 15:36:57 +05:30
document . querySelector ( '#comment-form textarea' ) ,
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
] ;
for ( const textarea of commentTextareas ) {
2023-04-03 15:36:57 +05:30
// Most users won't feel too sad if they lose a comment with 10 chars, they can re-type these in seconds.
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
// But if they have typed more (like 50) chars and the comment is lost, they will be very unhappy.
2023-04-03 15:36:57 +05:30
if ( textarea && textarea . value . trim ( ) . length > 10 ) {
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
textarea . parentElement . scrollIntoView ( ) ;
if ( ! window . confirm ( 'Page will be reloaded, but there are draft comments. Continuing to reload will discard the comments. Continue?' ) ) {
return ;
}
break ;
}
}
window . location . reload ( ) ;
}
2021-10-16 22:58:04 +05:30
export function initRepoCommentForm ( ) {
2022-06-28 23:22:58 +05:30
const $commentForm = $ ( '.comment.form' ) ;
if ( $commentForm . length === 0 ) {
2021-10-16 22:58:04 +05:30
return ;
}
function initBranchSelector ( ) {
const $selectBranch = $ ( '.ui.select-branch' ) ;
const $branchMenu = $selectBranch . find ( '.reference-list-menu' ) ;
const $isNewIssue = $branchMenu . hasClass ( 'new-issue' ) ;
$branchMenu . find ( '.item:not(.no-select)' ) . click ( function ( ) {
const selectedValue = $ ( this ) . data ( 'id' ) ;
const editMode = $ ( '#editing_mode' ) . val ( ) ;
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . data ( 'id-selector' ) ) . val ( selectedValue ) ;
2021-10-16 22:58:04 +05:30
if ( $isNewIssue ) {
$selectBranch . find ( '.ui .branch-name' ) . text ( $ ( this ) . data ( 'name' ) ) ;
return ;
}
if ( editMode === 'true' ) {
const form = $ ( '#update_issueref_form' ) ;
2021-10-21 13:07:43 +05:30
$ . post ( form . attr ( 'action' ) , { _csrf : csrfToken , ref : selectedValue } , ( ) => window . location . reload ( ) ) ;
2021-10-16 22:58:04 +05:30
} else if ( editMode === '' ) {
$selectBranch . find ( '.ui .branch-name' ) . text ( selectedValue ) ;
}
} ) ;
$selectBranch . find ( '.reference.column' ) . on ( 'click' , function ( ) {
2023-02-19 09:36:14 +05:30
hideElem ( $selectBranch . find ( '.scrolling.reference-list-menu' ) ) ;
2021-10-16 22:58:04 +05:30
$selectBranch . find ( '.reference .text' ) . removeClass ( 'black' ) ;
2023-02-19 09:36:14 +05:30
showElem ( $ ( $ ( this ) . data ( 'target' ) ) ) ;
2021-10-16 22:58:04 +05:30
$ ( this ) . find ( '.text' ) . addClass ( 'black' ) ;
return false ;
} ) ;
}
2023-04-03 15:36:57 +05:30
const $statusButton = $ ( '#status-button' ) ;
$statusButton . on ( 'click' , ( e ) => {
e . preventDefault ( ) ;
$ ( '#status' ) . val ( $statusButton . data ( 'status-val' ) ) ;
$ ( '#comment-form' ) . trigger ( 'submit' ) ;
} ) ;
const _promise = initComboMarkdownEditor ( $commentForm . find ( '.combo-markdown-editor' ) , {
onContentChanged ( editor ) {
$statusButton . text ( $statusButton . attr ( editor . value ( ) . trim ( ) ? 'data-status-and-comment' : 'data-status' ) ) ;
} ,
} ) ;
2022-01-08 19:03:32 +05:30
2021-10-16 22:58:04 +05:30
initBranchSelector ( ) ;
2021-11-18 22:15:00 +05:30
// List submits
2021-10-16 22:58:04 +05:30
function initListSubmits ( selector , outerSelector ) {
const $list = $ ( ` .ui. ${ outerSelector } .list ` ) ;
const $noSelect = $list . find ( '.no-select' ) ;
const $listMenu = $ ( ` . ${ selector } .menu ` ) ;
let hasUpdateAction = $listMenu . data ( 'action' ) === 'update' ;
const items = { } ;
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
$ ( ` . ${ selector } ` ) . dropdown ( {
'action' : 'nothing' , // do not hide the menu if user presses Enter
fullTextSearch : 'exact' ,
async onHide ( ) {
hasUpdateAction = $listMenu . data ( 'action' ) === 'update' ; // Update the var
if ( hasUpdateAction ) {
// TODO: Add batch functionality and make this 1 network request.
const itemEntries = Object . entries ( items ) ;
for ( const [ elementId , item ] of itemEntries ) {
2021-11-16 07:51:13 +05:30
await updateIssuesMeta (
item [ 'update-url' ] ,
item . action ,
item [ 'issue-id' ] ,
elementId ,
) ;
}
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
if ( itemEntries . length ) {
reloadConfirmDraftComment ( ) ;
}
}
} ,
2021-10-16 22:58:04 +05:30
} ) ;
$listMenu . find ( '.item:not(.no-select)' ) . on ( 'click' , function ( e ) {
e . preventDefault ( ) ;
if ( $ ( this ) . hasClass ( 'ban-change' ) ) {
return false ;
}
hasUpdateAction = $listMenu . data ( 'action' ) === 'update' ; // Update the var
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 00:47:39 +05:30
const clickedItem = $ ( this ) ;
const scope = $ ( this ) . attr ( 'data-scope' ) ;
$ ( this ) . parent ( ) . find ( '.item' ) . each ( function ( ) {
if ( scope ) {
// Enable only clicked item for scoped labels
if ( $ ( this ) . attr ( 'data-scope' ) !== scope ) {
return true ;
2021-10-16 22:58:04 +05:30
}
2023-03-06 15:50:29 +05:30
if ( ! $ ( this ) . is ( clickedItem ) && ! $ ( this ) . hasClass ( 'checked' ) ) {
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 00:47:39 +05:30
return true ;
}
} else if ( ! $ ( this ) . is ( clickedItem ) ) {
// Toggle for other labels
return true ;
2021-10-16 22:58:04 +05:30
}
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 00:47:39 +05:30
if ( $ ( this ) . hasClass ( 'checked' ) ) {
$ ( this ) . removeClass ( 'checked' ) ;
$ ( this ) . find ( '.octicon-check' ) . addClass ( 'invisible' ) ;
if ( hasUpdateAction ) {
if ( ! ( $ ( this ) . data ( 'id' ) in items ) ) {
items [ $ ( this ) . data ( 'id' ) ] = {
'update-url' : $listMenu . data ( 'update-url' ) ,
action : 'detach' ,
'issue-id' : $listMenu . data ( 'issue-id' ) ,
} ;
} else {
delete items [ $ ( this ) . data ( 'id' ) ] ;
}
}
} else {
$ ( this ) . addClass ( 'checked' ) ;
$ ( this ) . find ( '.octicon-check' ) . removeClass ( 'invisible' ) ;
if ( hasUpdateAction ) {
if ( ! ( $ ( this ) . data ( 'id' ) in items ) ) {
items [ $ ( this ) . data ( 'id' ) ] = {
'update-url' : $listMenu . data ( 'update-url' ) ,
action : 'attach' ,
'issue-id' : $listMenu . data ( 'issue-id' ) ,
} ;
} else {
delete items [ $ ( this ) . data ( 'id' ) ] ;
}
2021-10-16 22:58:04 +05:30
}
}
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 00:47:39 +05:30
} ) ;
2021-10-16 22:58:04 +05:30
// TODO: Which thing should be done for choosing review requests
// to make chosen items be shown on time here?
if ( selector === 'select-reviewers-modify' || selector === 'select-assignees-modify' ) {
return false ;
}
const listIds = [ ] ;
$ ( this ) . parent ( ) . find ( '.item' ) . each ( function ( ) {
if ( $ ( this ) . hasClass ( 'checked' ) ) {
listIds . push ( $ ( this ) . data ( 'id' ) ) ;
2023-02-19 09:36:14 +05:30
$ ( $ ( this ) . data ( 'id-selector' ) ) . removeClass ( 'gt-hidden' ) ;
2021-10-16 22:58:04 +05:30
} else {
2023-02-19 09:36:14 +05:30
$ ( $ ( this ) . data ( 'id-selector' ) ) . addClass ( 'gt-hidden' ) ;
2021-10-16 22:58:04 +05:30
}
} ) ;
if ( listIds . length === 0 ) {
2023-02-19 09:36:14 +05:30
$noSelect . removeClass ( 'gt-hidden' ) ;
2021-10-16 22:58:04 +05:30
} else {
2023-02-19 09:36:14 +05:30
$noSelect . addClass ( 'gt-hidden' ) ;
2021-10-16 22:58:04 +05:30
}
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . parent ( ) . data ( 'id' ) ) . val ( listIds . join ( ',' ) ) ;
2021-10-16 22:58:04 +05:30
return false ;
} ) ;
$listMenu . find ( '.no-select.item' ) . on ( 'click' , function ( e ) {
e . preventDefault ( ) ;
if ( hasUpdateAction ) {
updateIssuesMeta (
$listMenu . data ( 'update-url' ) ,
'clear' ,
$listMenu . data ( 'issue-id' ) ,
'' ,
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
) . then ( reloadConfirmDraftComment ) ;
2021-10-16 22:58:04 +05:30
}
$ ( this ) . parent ( ) . find ( '.item' ) . each ( function ( ) {
$ ( this ) . removeClass ( 'checked' ) ;
2023-03-02 00:48:35 +05:30
$ ( this ) . find ( '.octicon-check' ) . addClass ( 'invisible' ) ;
2021-10-16 22:58:04 +05:30
} ) ;
if ( selector === 'select-reviewers-modify' || selector === 'select-assignees-modify' ) {
return false ;
}
$list . find ( '.item' ) . each ( function ( ) {
2023-02-19 09:36:14 +05:30
$ ( this ) . addClass ( 'gt-hidden' ) ;
2021-10-16 22:58:04 +05:30
} ) ;
2023-02-19 09:36:14 +05:30
$noSelect . removeClass ( 'gt-hidden' ) ;
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . parent ( ) . data ( 'id' ) ) . val ( '' ) ;
2021-10-16 22:58:04 +05:30
} ) ;
}
// Init labels and assignees
initListSubmits ( 'select-label' , 'labels' ) ;
initListSubmits ( 'select-assignees' , 'assignees' ) ;
initListSubmits ( 'select-assignees-modify' , 'assignees' ) ;
initListSubmits ( 'select-reviewers-modify' , 'assignees' ) ;
function selectItem ( select _id , input _id ) {
const $menu = $ ( ` ${ select _id } .menu ` ) ;
const $list = $ ( ` .ui ${ select _id } .list ` ) ;
const hasUpdateAction = $menu . data ( 'action' ) === 'update' ;
$menu . find ( '.item:not(.no-select)' ) . on ( 'click' , function ( ) {
$ ( this ) . parent ( ) . find ( '.item' ) . each ( function ( ) {
$ ( this ) . removeClass ( 'selected active' ) ;
} ) ;
$ ( this ) . addClass ( 'selected active' ) ;
if ( hasUpdateAction ) {
updateIssuesMeta (
$menu . data ( 'update-url' ) ,
'' ,
$menu . data ( 'issue-id' ) ,
$ ( this ) . data ( 'id' ) ,
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
) . then ( reloadConfirmDraftComment ) ;
2021-10-16 22:58:04 +05:30
}
let icon = '' ;
if ( input _id === '#milestone_id' ) {
2023-02-13 23:29:59 +05:30
icon = svg ( 'octicon-milestone' , 18 , 'gt-mr-3' ) ;
2021-10-16 22:58:04 +05:30
} else if ( input _id === '#project_id' ) {
2023-02-13 23:29:59 +05:30
icon = svg ( 'octicon-project' , 18 , 'gt-mr-3' ) ;
2021-10-16 22:58:04 +05:30
} else if ( input _id === '#assignee_id' ) {
2023-04-03 15:36:57 +05:30
icon = ` <img class="ui avatar image gt-mr-3" alt="avatar" src= ${ $ ( this ) . data ( 'avatar' ) } > ` ;
2021-10-16 22:58:04 +05:30
}
$list . find ( '.selected' ) . html ( `
< a class = "item muted sidebar-item-link" href = $ { $ ( this ) . data ( 'href' ) } >
$ { icon }
$ { htmlEscape ( $ ( this ) . text ( ) ) }
< / a >
` );
2023-02-19 09:36:14 +05:30
$ ( ` .ui ${ select _id } .list .no-select ` ) . addClass ( 'gt-hidden' ) ;
2021-10-16 22:58:04 +05:30
$ ( input _id ) . val ( $ ( this ) . data ( 'id' ) ) ;
} ) ;
$menu . find ( '.no-select.item' ) . on ( 'click' , function ( ) {
$ ( this ) . parent ( ) . find ( '.item:not(.no-select)' ) . each ( function ( ) {
$ ( this ) . removeClass ( 'selected active' ) ;
} ) ;
if ( hasUpdateAction ) {
updateIssuesMeta (
$menu . data ( 'update-url' ) ,
'' ,
$menu . data ( 'issue-id' ) ,
$ ( this ) . data ( 'id' ) ,
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 06:56:27 +05:30
) . then ( reloadConfirmDraftComment ) ;
2021-10-16 22:58:04 +05:30
}
$list . find ( '.selected' ) . html ( '' ) ;
2023-02-19 09:36:14 +05:30
$list . find ( '.no-select' ) . removeClass ( 'gt-hidden' ) ;
2022-01-16 16:49:26 +05:30
$ ( input _id ) . val ( '' ) ;
2021-10-16 22:58:04 +05:30
} ) ;
}
// Milestone, Assignee, Project
selectItem ( '.select-project' , '#project_id' ) ;
selectItem ( '.select-milestone' , '#milestone_id' ) ;
selectItem ( '.select-assignee' , '#assignee_id' ) ;
}
2021-11-18 22:15:00 +05:30
async function onEditContent ( event ) {
event . preventDefault ( ) ;
2022-01-05 17:47:25 +05:30
2021-11-18 22:15:00 +05:30
const $segment = $ ( this ) . closest ( '.header' ) . next ( ) ;
const $editContentZone = $segment . find ( '.edit-content-zone' ) ;
const $renderContent = $segment . find ( '.render-content' ) ;
const $rawContent = $segment . find ( '.raw-content' ) ;
2023-04-03 15:36:57 +05:30
let comboMarkdownEditor ;
const setupDropzone = async ( $dropzone ) => {
if ( $dropzone . length === 0 ) return null ;
2023-04-20 12:09:44 +05:30
let disableRemovedfileEvent = false ; // when resetting the dropzone (removeAllFiles), disable the "removedfile" event
let fileUuidDict = { } ; // to record: if a comment has been saved, then the uploaded files won't be deleted from server when clicking the Remove in the dropzone
2023-04-03 15:36:57 +05:30
const dz = await createDropzone ( $dropzone [ 0 ] , {
2023-04-20 12:09:44 +05:30
url : $dropzone . attr ( 'data-upload-url' ) ,
2023-04-03 15:36:57 +05:30
headers : { 'X-Csrf-Token' : csrfToken } ,
2023-04-20 12:09:44 +05:30
maxFiles : $dropzone . attr ( 'data-max-file' ) ,
maxFilesize : $dropzone . attr ( 'data-max-size' ) ,
acceptedFiles : ( [ '*/*' , '' ] . includes ( $dropzone . attr ( 'data-accepts' ) ) ) ? null : $dropzone . attr ( 'data-accepts' ) ,
2023-04-03 15:36:57 +05:30
addRemoveLinks : true ,
2023-04-20 12:09:44 +05:30
dictDefaultMessage : $dropzone . attr ( 'data-default-message' ) ,
dictInvalidFileType : $dropzone . attr ( 'data-invalid-input-type' ) ,
dictFileTooBig : $dropzone . attr ( 'data-file-too-big' ) ,
dictRemoveFile : $dropzone . attr ( 'data-remove-file' ) ,
2023-04-03 15:36:57 +05:30
timeout : 0 ,
thumbnailMethod : 'contain' ,
thumbnailWidth : 480 ,
thumbnailHeight : 480 ,
init ( ) {
this . on ( 'success' , ( file , data ) => {
file . uuid = data . uuid ;
fileUuidDict [ file . uuid ] = { submitted : false } ;
const input = $ ( ` <input id=" ${ data . uuid } " name="files" type="hidden"> ` ) . val ( data . uuid ) ;
$dropzone . find ( '.files' ) . append ( input ) ;
} ) ;
this . on ( 'removedfile' , ( file ) => {
2023-04-20 12:09:44 +05:30
if ( disableRemovedfileEvent ) return ;
2023-04-03 15:36:57 +05:30
$ ( ` # ${ file . uuid } ` ) . remove ( ) ;
2023-04-20 12:09:44 +05:30
if ( $dropzone . attr ( 'data-remove-url' ) && ! fileUuidDict [ file . uuid ] . submitted ) {
$ . post ( $dropzone . attr ( 'data-remove-url' ) , {
2023-04-03 15:36:57 +05:30
file : file . uuid ,
_csrf : csrfToken ,
2021-11-18 22:15:00 +05:30
} ) ;
2023-04-03 15:36:57 +05:30
}
} ) ;
this . on ( 'submit' , ( ) => {
$ . each ( fileUuidDict , ( fileUuid ) => {
fileUuidDict [ fileUuid ] . submitted = true ;
2021-11-18 22:15:00 +05:30
} ) ;
2023-04-03 15:36:57 +05:30
} ) ;
this . on ( 'reload' , ( ) => {
2023-04-20 12:09:44 +05:30
$ . getJSON ( $editContentZone . attr ( 'data-attachment-url' ) , ( data ) => {
// do not trigger the "removedfile" event, otherwise the attachments would be deleted from server
disableRemovedfileEvent = true ;
2023-04-03 15:36:57 +05:30
dz . removeAllFiles ( true ) ;
$dropzone . find ( '.files' ) . empty ( ) ;
2023-04-20 12:09:44 +05:30
fileUuidDict = { } ;
disableRemovedfileEvent = false ;
for ( const attachment of data ) {
const imgSrc = ` ${ $dropzone . attr ( 'data-link-url' ) } / ${ attachment . uuid } ` ;
dz . emit ( 'addedfile' , attachment ) ;
dz . emit ( 'thumbnail' , attachment , imgSrc ) ;
dz . emit ( 'complete' , attachment ) ;
dz . files . push ( attachment ) ;
fileUuidDict [ attachment . uuid ] = { submitted : true } ;
2023-04-03 15:36:57 +05:30
$dropzone . find ( ` img[src=' ${ imgSrc } '] ` ) . css ( 'max-width' , '100%' ) ;
2023-04-20 12:09:44 +05:30
const input = $ ( ` <input id=" ${ attachment . uuid } " name="files" type="hidden"> ` ) . val ( attachment . uuid ) ;
2023-04-03 15:36:57 +05:30
$dropzone . find ( '.files' ) . append ( input ) ;
2023-04-20 12:09:44 +05:30
}
2021-11-18 22:15:00 +05:30
} ) ;
2023-04-03 15:36:57 +05:30
} ) ;
} ,
} ) ;
dz . emit ( 'reload' ) ;
return dz ;
} ;
const cancelAndReset = ( dz ) => {
showElem ( $renderContent ) ;
hideElem ( $editContentZone ) ;
if ( dz ) {
2021-11-18 22:15:00 +05:30
dz . emit ( 'reload' ) ;
}
2023-04-03 15:36:57 +05:30
} ;
const saveAndRefresh = ( dz , $dropzone ) => {
showElem ( $renderContent ) ;
hideElem ( $editContentZone ) ;
const $attachments = $dropzone . find ( '.files' ) . find ( '[name=files]' ) . map ( function ( ) {
return $ ( this ) . val ( ) ;
} ) . get ( ) ;
2023-04-20 12:09:44 +05:30
$ . post ( $editContentZone . attr ( 'data-update-url' ) , {
2023-04-03 15:36:57 +05:30
_csrf : csrfToken ,
content : comboMarkdownEditor . value ( ) ,
2023-04-20 12:09:44 +05:30
context : $editContentZone . attr ( 'data-context' ) ,
2023-04-03 15:36:57 +05:30
files : $attachments ,
} , ( data ) => {
if ( ! data . content ) {
$renderContent . html ( $ ( '#no-content' ) . html ( ) ) ;
$rawContent . text ( '' ) ;
} else {
$renderContent . html ( data . content ) ;
$rawContent . text ( comboMarkdownEditor . value ( ) ) ;
2022-05-20 07:56:04 +05:30
2023-04-03 15:36:57 +05:30
const refIssues = $renderContent . find ( 'p .ref-issue' ) ;
attachRefIssueContextPopup ( refIssues ) ;
}
const $content = $segment ;
if ( ! $content . find ( '.dropzone-attachments' ) . length ) {
if ( data . attachments !== '' ) {
$content . append ( ` <div class="dropzone-attachments"></div> ` ) ;
$content . find ( '.dropzone-attachments' ) . replaceWith ( data . attachments ) ;
}
} else if ( data . attachments === '' ) {
$content . find ( '.dropzone-attachments' ) . remove ( ) ;
} else {
$content . find ( '.dropzone-attachments' ) . replaceWith ( data . attachments ) ;
}
2021-11-18 22:15:00 +05:30
if ( dz ) {
2023-04-03 15:36:57 +05:30
dz . emit ( 'submit' ) ;
2021-11-18 22:15:00 +05:30
dz . emit ( 'reload' ) ;
}
2023-04-03 15:36:57 +05:30
initMarkupContent ( ) ;
initCommentContent ( ) ;
2021-11-18 22:15:00 +05:30
} ) ;
2023-04-03 15:36:57 +05:30
} ;
2022-05-20 07:56:04 +05:30
2023-04-03 15:36:57 +05:30
if ( ! $editContentZone . html ( ) ) {
$editContentZone . html ( $ ( '#issue-comment-editor-template' ) . html ( ) ) ;
comboMarkdownEditor = await initComboMarkdownEditor ( $editContentZone . find ( '.combo-markdown-editor' ) ) ;
const $dropzone = $editContentZone . find ( '.dropzone' ) ;
const dz = await setupDropzone ( $dropzone ) ;
$editContentZone . find ( '.cancel.button' ) . on ( 'click' , ( e ) => {
e . preventDefault ( ) ;
cancelAndReset ( dz ) ;
} ) ;
$editContentZone . find ( '.save.button' ) . on ( 'click' , ( e ) => {
e . preventDefault ( ) ;
saveAndRefresh ( dz , $dropzone ) ;
2021-11-18 22:15:00 +05:30
} ) ;
2023-04-03 15:36:57 +05:30
} else {
comboMarkdownEditor = getComboMarkdownEditor ( $editContentZone . find ( '.combo-markdown-editor' ) ) ;
2021-11-18 22:15:00 +05:30
}
// Show write/preview tab and copy raw content as needed
2023-02-19 09:36:14 +05:30
showElem ( $editContentZone ) ;
hideElem ( $renderContent ) ;
2023-04-03 15:36:57 +05:30
if ( ! comboMarkdownEditor . value ( ) ) {
comboMarkdownEditor . value ( $rawContent . text ( ) ) ;
2021-11-18 22:15:00 +05:30
}
2023-04-03 15:36:57 +05:30
comboMarkdownEditor . focus ( ) ;
2021-11-18 22:15:00 +05:30
}
2021-11-09 14:57:25 +05:30
export function initRepository ( ) {
2021-10-16 22:58:04 +05:30
if ( $ ( '.repository' ) . length === 0 ) {
return ;
}
// File list and commits
2022-02-10 01:58:55 +05:30
if ( $ ( '.repository.file.list' ) . length > 0 || $ ( '.branch-dropdown' ) . length > 0 ||
2021-10-16 22:58:04 +05:30
$ ( '.repository.commits' ) . length > 0 || $ ( '.repository.release' ) . length > 0 ) {
2023-03-14 15:21:20 +05:30
initRepoBranchTagSelector ( '.js-branch-tag-selector' ) ;
2021-10-16 22:58:04 +05:30
}
// Options
if ( $ ( '.repository.settings.options' ) . length > 0 ) {
// Enable or select internal/external wiki system and issue tracker.
$ ( '.enable-system' ) . on ( 'change' , function ( ) {
if ( this . checked ) {
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . data ( 'target' ) ) . removeClass ( 'disabled' ) ;
if ( ! $ ( this ) . data ( 'context' ) ) $ ( $ ( this ) . data ( 'context' ) ) . addClass ( 'disabled' ) ;
2021-10-16 22:58:04 +05:30
} else {
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . data ( 'target' ) ) . addClass ( 'disabled' ) ;
if ( ! $ ( this ) . data ( 'context' ) ) $ ( $ ( this ) . data ( 'context' ) ) . removeClass ( 'disabled' ) ;
2021-10-16 22:58:04 +05:30
}
} ) ;
$ ( '.enable-system-radio' ) . on ( 'change' , function ( ) {
if ( this . value === 'false' ) {
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . data ( 'target' ) ) . addClass ( 'disabled' ) ;
2022-11-22 06:28:55 +05:30
if ( $ ( this ) . data ( 'context' ) !== undefined ) $ ( $ ( this ) . data ( 'context' ) ) . removeClass ( 'disabled' ) ;
2021-10-16 22:58:04 +05:30
} else if ( this . value === 'true' ) {
2022-01-16 16:49:26 +05:30
$ ( $ ( this ) . data ( 'target' ) ) . removeClass ( 'disabled' ) ;
2022-11-22 06:28:55 +05:30
if ( $ ( this ) . data ( 'context' ) !== undefined ) $ ( $ ( this ) . data ( 'context' ) ) . addClass ( 'disabled' ) ;
2021-10-16 22:58:04 +05:30
}
} ) ;
2022-06-10 11:09:53 +05:30
const $trackerIssueStyleRadios = $ ( '.js-tracker-issue-style' ) ;
$trackerIssueStyleRadios . on ( 'change input' , ( ) => {
const checkedVal = $trackerIssueStyleRadios . filter ( ':checked' ) . val ( ) ;
$ ( '#tracker-issue-style-regex-box' ) . toggleClass ( 'disabled' , checkedVal !== 'regexp' ) ;
} ) ;
2021-10-16 22:58:04 +05:30
}
// Labels
initCompLabelEdit ( '.repository.labels' ) ;
// Milestones
if ( $ ( '.repository.new.milestone' ) . length > 0 ) {
$ ( '#clear-date' ) . on ( 'click' , ( ) => {
$ ( '#deadline' ) . val ( '' ) ;
return false ;
} ) ;
}
// Repo Creation
if ( $ ( '.repository.new.repo' ) . length > 0 ) {
$ ( 'input[name="gitignores"], input[name="license"]' ) . on ( 'change' , ( ) => {
const gitignores = $ ( 'input[name="gitignores"]' ) . val ( ) ;
const license = $ ( 'input[name="license"]' ) . val ( ) ;
if ( gitignores || license ) {
$ ( 'input[name="auto_init"]' ) . prop ( 'checked' , true ) ;
}
} ) ;
}
2021-11-18 22:15:00 +05:30
// Compare or pull request
const $repoDiff = $ ( '.repository.diff' ) ;
if ( $repoDiff . length ) {
initRepoCommonBranchOrTagDropdown ( '.choose.branch .dropdown' ) ;
initRepoCommonFilterSearchDropdown ( '.choose.branch .dropdown' ) ;
}
2022-03-29 08:51:30 +05:30
initRepoCloneLink ( ) ;
2022-11-11 22:32:50 +05:30
initCitationFileCopyContent ( ) ;
2021-11-18 22:15:00 +05:30
initRepoCommonLanguageStats ( ) ;
initRepoSettingBranches ( ) ;
2021-10-16 22:58:04 +05:30
// Issues
if ( $ ( '.repository.view.issue' ) . length > 0 ) {
2021-11-18 22:15:00 +05:30
initRepoIssueCommentEdit ( ) ;
2021-10-16 22:58:04 +05:30
initRepoIssueBranchSelect ( ) ;
initRepoIssueTitleEdit ( ) ;
initRepoIssueWipToggle ( ) ;
initRepoIssueComments ( ) ;
initRepoDiffConversationNav ( ) ;
initRepoIssueReferenceIssue ( ) ;
initRepoIssueCommentDelete ( ) ;
initRepoIssueDependencyDelete ( ) ;
initRepoIssueCodeCommentCancel ( ) ;
initRepoPullRequestUpdate ( ) ;
initCompReactionSelector ( ) ;
2022-05-12 19:09:02 +05:30
initRepoPullRequestMergeForm ( ) ;
2021-10-16 22:58:04 +05:30
}
// Pull request
const $repoComparePull = $ ( '.repository.compare.pull' ) ;
if ( $repoComparePull . length > 0 ) {
// show pull request form
$repoComparePull . find ( 'button.show-form' ) . on ( 'click' , function ( e ) {
e . preventDefault ( ) ;
2023-02-19 09:36:14 +05:30
hideElem ( $ ( this ) . parent ( ) ) ;
2021-11-18 22:15:00 +05:30
const $form = $repoComparePull . find ( '.pullrequest-form' ) ;
2023-02-19 09:36:14 +05:30
showElem ( $form ) ;
2021-10-16 22:58:04 +05:30
} ) ;
}
2022-01-07 06:48:52 +05:30
initUnicodeEscapeButton ( ) ;
2021-10-16 22:58:04 +05:30
}
2021-11-18 22:15:00 +05:30
function initRepoIssueCommentEdit ( ) {
// Edit issue or comment content
$ ( document ) . on ( 'click' , '.edit-content' , onEditContent ) ;
2021-10-16 22:58:04 +05:30
// Quote reply
2023-03-03 01:23:22 +05:30
$ ( document ) . on ( 'click' , '.quote-reply' , async function ( event ) {
event . preventDefault ( ) ;
2021-10-16 22:58:04 +05:30
const target = $ ( this ) . data ( 'target' ) ;
2022-12-09 21:55:32 +05:30
const quote = $ ( ` # ${ target } ` ) . text ( ) . replace ( /\n/g , '\n> ' ) ;
2021-10-16 22:58:04 +05:30
const content = ` > ${ quote } \n \n ` ;
2023-04-03 15:36:57 +05:30
let editor ;
2021-10-16 22:58:04 +05:30
if ( $ ( this ) . hasClass ( 'quote-reply-diff' ) ) {
2023-03-03 01:23:22 +05:30
const $replyBtn = $ ( this ) . closest ( '.comment-code-cloud' ) . find ( 'button.comment-form-reply' ) ;
2023-04-03 15:36:57 +05:30
editor = await handleReply ( $replyBtn ) ;
2021-11-18 22:15:00 +05:30
} else {
// for normal issue/comment page
2023-04-03 15:36:57 +05:30
editor = getComboMarkdownEditor ( $ ( '#comment-form .combo-markdown-editor' ) ) ;
2021-10-16 22:58:04 +05:30
}
2023-04-03 15:36:57 +05:30
if ( editor ) {
if ( editor . value ( ) ) {
editor . value ( ` ${ editor . value ( ) } \n \n ${ content } ` ) ;
2021-10-16 22:58:04 +05:30
} else {
2023-04-03 15:36:57 +05:30
editor . value ( content ) ;
2021-10-16 22:58:04 +05:30
}
2023-04-03 15:36:57 +05:30
editor . focus ( ) ;
editor . moveCursorToEnd ( ) ;
2021-10-16 22:58:04 +05:30
}
} ) ;
}