2023-02-13 23:29:59 +05:30
|
|
|
<table id="repo-files-table" class="ui single line table gt-mt-0" data-last-commit-loader-url="{{.LastCommitLoaderURL}}">
|
2015-12-08 04:00:52 +05:30
|
|
|
<thead>
|
2017-11-30 10:38:40 +05:30
|
|
|
<tr class="commit-list">
|
2021-10-08 18:38:22 +05:30
|
|
|
<th colspan="2" {{if not .LatestCommit}}class="notready"{{end}}>
|
|
|
|
|
{{if not .LatestCommit}}
|
|
|
|
|
<div class="ui active tiny slow centered inline">…</div>
|
2015-12-08 04:00:52 +05:30
|
|
|
{{else}}
|
2021-10-08 18:38:22 +05:30
|
|
|
{{if .LatestCommitUser}}
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 19:07:34 +05:30
|
|
|
{{avatar $.Context .LatestCommitUser 24}}
|
2021-10-08 18:38:22 +05:30
|
|
|
{{if .LatestCommitUser.FullName}}
|
2023-02-24 01:58:18 +05:30
|
|
|
<a class="muted author-wrapper" title="{{.LatestCommitUser.FullName}}" href="{{.LatestCommitUser.HomeLink}}"><strong>{{.LatestCommitUser.FullName}}</strong></a>
|
2021-10-08 18:38:22 +05:30
|
|
|
{{else}}
|
2023-02-24 01:58:18 +05:30
|
|
|
<a class="muted author-wrapper" title="{{if .LatestCommit.Author}}{{.LatestCommit.Author.Name}}{{else}}{{.LatestCommitUser.Name}}{{end}}" href="{{.LatestCommitUser.HomeLink}}"><strong>{{if .LatestCommit.Author}}{{.LatestCommit.Author.Name}}{{else}}{{.LatestCommitUser.Name}}{{end}}</strong></a>
|
2021-10-08 18:38:22 +05:30
|
|
|
{{end}}
|
|
|
|
|
{{else}}
|
|
|
|
|
{{if .LatestCommit.Author}}
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 19:07:34 +05:30
|
|
|
{{avatarByEmail $.Context .LatestCommit.Author.Email .LatestCommit.Author.Name 24}}
|
2023-02-24 01:58:18 +05:30
|
|
|
<span class="author-wrapper" title="{{.LatestCommit.Author.Name}}"><strong>{{.LatestCommit.Author.Name}}</strong></span>
|
2021-10-08 18:38:22 +05:30
|
|
|
{{end}}
|
2020-02-29 18:57:19 +05:30
|
|
|
{{end}}
|
2022-08-26 03:25:52 +05:30
|
|
|
<a rel="nofollow" class="ui sha label {{if .LatestCommit.Signature}} isSigned {{if .LatestCommitVerification.Verified}} isVerified{{if eq .LatestCommitVerification.TrustStatus "trusted"}}{{else if eq .LatestCommitVerification.TrustStatus "untrusted"}}Untrusted{{else}}Unmatched{{end}}{{else if .LatestCommitVerification.Warning}} isWarning{{end}}{{end}}" href="{{.RepoLink}}/commit/{{PathEscape .LatestCommit.ID.String}}">
|
2021-10-08 18:38:22 +05:30
|
|
|
<span class="shortsha">{{ShortSha .LatestCommit.ID.String}}</span>
|
|
|
|
|
{{if .LatestCommit.Signature}}
|
|
|
|
|
{{template "repo/shabox_badge" dict "root" $ "verification" .LatestCommitVerification}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</a>
|
|
|
|
|
{{template "repo/commit_statuses" dict "Status" .LatestCommitStatus "Statuses" .LatestCommitStatuses "root" $}}
|
2022-08-26 03:25:52 +05:30
|
|
|
{{$commitLink:= printf "%s/commit/%s" .RepoLink (PathEscape .LatestCommit.ID.String)}}
|
2022-01-20 04:56:57 +05:30
|
|
|
<span class="grey commit-summary" title="{{.LatestCommit.Summary}}"><span class="message-wrapper">{{RenderCommitMessageLinkSubject $.Context .LatestCommit.Message $.RepoLink $commitLink $.Repository.ComposeMetas}}</span>
|
2021-10-08 18:38:22 +05:30
|
|
|
{{if IsMultilineCommitMessage .LatestCommit.Message}}
|
2021-11-23 08:14:38 +05:30
|
|
|
<button class="ui button ellipsis-button" aria-expanded="false">...</button>
|
2023-02-19 09:36:14 +05:30
|
|
|
<pre class="commit-body gt-hidden">{{RenderCommitBody $.Context .LatestCommit.Message $.RepoLink $.Repository.ComposeMetas}}</pre>
|
2021-10-08 18:38:22 +05:30
|
|
|
{{end}}
|
|
|
|
|
</span>
|
2017-11-30 10:38:40 +05:30
|
|
|
{{end}}
|
2015-12-08 04:00:52 +05:30
|
|
|
</th>
|
2022-06-28 02:28:46 +05:30
|
|
|
<th class="text grey right age">{{if .LatestCommit}}{{if .LatestCommit.Committer}}{{TimeSince .LatestCommit.Committer.When $.locale}}{{end}}{{end}}</th>
|
2015-12-08 04:00:52 +05:30
|
|
|
</tr>
|
|
|
|
|
</thead>
|
|
|
|
|
<tbody>
|
|
|
|
|
{{if .HasParentPath}}
|
|
|
|
|
<tr class="has-parent">
|
2021-11-16 23:48:25 +05:30
|
|
|
<td colspan="3">{{svg "octicon-reply"}}<a href="{{.BranchLink}}{{if .ParentPath}}{{PathEscapeSegments .ParentPath}}{{end}}">..</a></td>
|
2015-12-08 04:00:52 +05:30
|
|
|
</tr>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{range $item := .Files}}
|
2020-12-17 19:30:47 +05:30
|
|
|
{{$entry := $item.Entry}}
|
|
|
|
|
{{$commit := $item.Commit}}
|
|
|
|
|
{{$subModuleFile := $item.SubModuleFile}}
|
2021-10-08 18:38:22 +05:30
|
|
|
<tr data-entryname="{{$entry.Name}}" data-ready="{{if $commit}}true{{else}}false{{end}}" class="{{if not $commit}}not{{end}}ready entry">
|
2020-08-26 21:22:44 +05:30
|
|
|
<td class="name four wide">
|
|
|
|
|
<span class="truncate">
|
|
|
|
|
{{if $entry.IsSubModule}}
|
2020-09-12 01:49:00 +05:30
|
|
|
{{svg "octicon-file-submodule"}}
|
Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861)
This PR follows:
* #21986
* #22831
This PR also introduce customized HTML elements, which would also help
problems like:
* #17760
* #21429
* #21440
With customized HTML elements, there won't be any load-search-replace
operations, and it can avoid page flicking (which @silverwind cares a
lot).
Browser support:
https://developer.mozilla.org/en-US/docs/Web/API/Window/customElements
# FAQ
## Why the component has the prefix?
As usual, I would strongly suggest to add prefixes for our own/private
names. The dedicated prefix will avoid conflicts in the future, and it
makes it easier to introduce various 3rd components, like GitHub's
`relative-time` component. If there is no prefix, it's impossible to
introduce another public component with the same name in the future.
## Why the `custcomp.js` is loaded before HTML body? The `index.js` is
after HTML body.
Customized components must be registered before the content loading.
Otherwise there would be still some flicking.
`custcomp.js` should have its own dependencies and should be very light,
so it won't affect the page loading time too much.
## Why use `data-url` attribute but not use the `textContent`?
According to the standard, the `connectedCallback` occurs on the
tag-opening moment. The element's children are not ready yet.
## Why not use `{{.GuessCurrentOrigin $.ctx ...}}` to let backend decide
the absolute URL?
It's difficult for backend to guess the correct protocol(scheme)
correctly with zero configuration. Generating the absolute URL from
frontend can guarantee that the URL is 100% correct -- since the user is
visiting it.
# Screenshot
<details>
</details>
2023-02-17 19:32:20 +05:30
|
|
|
{{$refURL := $subModuleFile.RefURL AppUrl $.Repository.FullName $.SSHDomain}} {{/* FIXME: the usage of AppUrl seems incorrect, it would be fixed in the future, use AppSubUrl instead */}}
|
2020-08-26 21:22:44 +05:30
|
|
|
{{if $refURL}}
|
2022-07-22 16:19:24 +05:30
|
|
|
<a class="muted" href="{{$refURL}}">{{$entry.Name}}</a><span class="at">@</span><a href="{{$refURL}}/commit/{{PathEscape $subModuleFile.RefID}}">{{ShortSha $subModuleFile.RefID}}</a>
|
2020-08-26 21:22:44 +05:30
|
|
|
{{else}}
|
2020-12-17 19:30:47 +05:30
|
|
|
{{$entry.Name}}<span class="at">@</span>{{ShortSha $subModuleFile.RefID}}
|
2020-08-26 21:22:44 +05:30
|
|
|
{{end}}
|
2020-08-24 00:35:17 +05:30
|
|
|
{{else}}
|
2020-08-26 21:22:44 +05:30
|
|
|
{{if $entry.IsDir}}
|
|
|
|
|
{{$subJumpablePathName := $entry.GetSubJumpablePathName}}
|
|
|
|
|
{{$subJumpablePath := SubJumpablePath $subJumpablePathName}}
|
2022-04-01 05:45:46 +05:30
|
|
|
{{svg "octicon-file-directory-fill"}}
|
2022-07-22 16:19:24 +05:30
|
|
|
<a class="muted" href="{{$.TreeLink}}/{{PathEscapeSegments $subJumpablePathName}}" title="{{$subJumpablePathName}}">
|
2020-08-26 21:22:44 +05:30
|
|
|
{{if eq (len $subJumpablePath) 2}}
|
2022-07-22 16:19:24 +05:30
|
|
|
<span class="color-text-light-2">{{index $subJumpablePath 0}}</span>{{index $subJumpablePath 1}}
|
2020-08-26 21:22:44 +05:30
|
|
|
{{else}}
|
|
|
|
|
{{index $subJumpablePath 0}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</a>
|
|
|
|
|
{{else}}
|
2020-09-12 01:49:00 +05:30
|
|
|
{{svg (printf "octicon-%s" (EntryIcon $entry))}}
|
2022-07-22 16:19:24 +05:30
|
|
|
<a class="muted" href="{{$.TreeLink}}/{{PathEscapeSegments $entry.Name}}" title="{{$entry.Name}}">{{$entry.Name}}</a>
|
2020-08-26 21:22:44 +05:30
|
|
|
{{end}}
|
2020-08-24 00:35:17 +05:30
|
|
|
{{end}}
|
2020-08-26 21:22:44 +05:30
|
|
|
</span>
|
|
|
|
|
</td>
|
2019-11-02 05:56:21 +05:30
|
|
|
<td class="message nine wide">
|
2020-08-26 21:22:44 +05:30
|
|
|
<span class="truncate">
|
2021-10-08 18:38:22 +05:30
|
|
|
{{if $commit}}
|
2021-12-03 21:45:53 +05:30
|
|
|
{{$commitLink := printf "%s/commit/%s" $.RepoLink (PathEscape $commit.ID.String)}}
|
2022-01-20 04:56:57 +05:30
|
|
|
{{RenderCommitMessageLinkSubject $.Context $commit.Message $.RepoLink $commitLink $.Repository.ComposeMetas}}
|
2021-10-08 18:38:22 +05:30
|
|
|
{{else}}
|
|
|
|
|
<div class="ui active tiny slow centered inline">…</div>
|
|
|
|
|
{{end}}
|
2020-08-26 21:22:44 +05:30
|
|
|
</span>
|
2015-12-08 04:00:52 +05:30
|
|
|
</td>
|
2022-06-28 02:28:46 +05:30
|
|
|
<td class="text right age three wide">{{if $commit}}{{TimeSince $commit.Committer.When $.locale}}{{end}}</td>
|
2015-12-08 04:00:52 +05:30
|
|
|
</tr>
|
|
|
|
|
{{end}}
|
|
|
|
|
</tbody>
|
2014-07-26 09:54:27 +05:30
|
|
|
</table>
|
|
|
|
|
{{if .ReadmeExist}}
|
2015-12-08 04:00:52 +05:30
|
|
|
{{template "repo/view_file" .}}
|
2015-07-28 14:12:06 +05:30
|
|
|
{{end}}
|
