135 lines
4.4 KiB
Ruby
135 lines
4.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Dashboard::TodosController do
|
|
let(:user) { create(:user) }
|
|
let(:author) { create(:user) }
|
|
let(:project) { create(:project) }
|
|
let(:todo_service) { TodoService.new }
|
|
|
|
before do
|
|
sign_in(user)
|
|
project.add_developer(user)
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
context 'project authorization' do
|
|
it 'renders 404 when user does not have read access on given project' do
|
|
unauthorized_project = create(:project, :private)
|
|
|
|
get :index, params: { project_id: unauthorized_project.id }
|
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
end
|
|
|
|
it 'renders 404 when given project does not exists' do
|
|
get :index, params: { project_id: 999 }
|
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
end
|
|
|
|
it 'renders 200 when filtering for "any project" todos' do
|
|
get :index, params: { project_id: '' }
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
|
|
it 'renders 200 when user has access on given project' do
|
|
authorized_project = create(:project, :public)
|
|
|
|
get :index, params: { project_id: authorized_project.id }
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
end
|
|
|
|
context 'group authorization' do
|
|
it 'renders 404 when user does not have read access on given group' do
|
|
unauthorized_group = create(:group, :private)
|
|
|
|
get :index, params: { group_id: unauthorized_group.id }
|
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
end
|
|
end
|
|
|
|
context 'when using pagination' do
|
|
let(:last_page) { user.todos.page.total_pages }
|
|
let!(:issues) { create_list(:issue, 3, project: project, assignees: [user]) }
|
|
|
|
before do
|
|
issues.each { |issue| todo_service.new_issue(issue, user) }
|
|
allow(Kaminari.config).to receive(:default_per_page).and_return(2)
|
|
end
|
|
|
|
it 'redirects to last_page if page number is larger than number of pages' do
|
|
get :index, params: { page: (last_page + 1).to_param }
|
|
|
|
expect(response).to redirect_to(dashboard_todos_path(page: last_page))
|
|
end
|
|
|
|
it 'goes to the correct page' do
|
|
get :index, params: { page: last_page }
|
|
|
|
expect(assigns(:todos).current_page).to eq(last_page)
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
|
|
it 'does not redirect to external sites when provided a host field' do
|
|
external_host = "www.example.com"
|
|
get :index, params: { page: (last_page + 1).to_param, host: external_host }
|
|
|
|
expect(response).to redirect_to(dashboard_todos_path(page: last_page))
|
|
end
|
|
|
|
context 'when providing no filters' do
|
|
it 'does not perform a query to get the page count, but gets that from the user' do
|
|
allow(controller).to receive(:current_user).and_return(user)
|
|
|
|
expect(user).to receive(:todos_pending_count).and_call_original
|
|
|
|
get :index, params: { page: (last_page + 1).to_param, sort: :created_asc }
|
|
|
|
expect(response).to redirect_to(dashboard_todos_path(page: last_page, sort: :created_asc))
|
|
end
|
|
end
|
|
|
|
context 'when providing filters' do
|
|
it 'performs a query to get the correct page count' do
|
|
allow(controller).to receive(:current_user).and_return(user)
|
|
|
|
expect(user).not_to receive(:todos_pending_count)
|
|
|
|
get :index, params: { page: (last_page + 1).to_param, project_id: project.id }
|
|
|
|
expect(response).to redirect_to(dashboard_todos_path(page: last_page, project_id: project.id))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PATCH #restore' do
|
|
let(:todo) { create(:todo, :done, user: user, project: project, author: author) }
|
|
|
|
it 'restores the todo to pending state' do
|
|
patch :restore, params: { id: todo.id }
|
|
|
|
expect(todo.reload).to be_pending
|
|
expect(response).to have_gitlab_http_status(200)
|
|
expect(json_response).to eq({ "count" => "1", "done_count" => "0" })
|
|
end
|
|
end
|
|
|
|
describe 'PATCH #bulk_restore' do
|
|
let(:todos) { create_list(:todo, 2, :done, user: user, project: project, author: author) }
|
|
|
|
it 'restores the todos to pending state' do
|
|
patch :bulk_restore, params: { ids: todos.map(&:id) }
|
|
|
|
todos.each do |todo|
|
|
expect(todo.reload).to be_pending
|
|
end
|
|
expect(response).to have_gitlab_http_status(200)
|
|
expect(json_response).to eq({ 'count' => '2', 'done_count' => '0' })
|
|
end
|
|
end
|
|
end
|