303 lines
8.1 KiB
Ruby
303 lines
8.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Groups::Settings::CiCdController do
|
|
include ExternalAuthorizationServiceHelpers
|
|
|
|
let(:group) { create(:group) }
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
describe 'GET #show' do
|
|
context 'when user is owner' do
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
it 'renders show with 200 status code' do
|
|
get :show, params: { group_id: group }
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
expect(response).to render_template(:show)
|
|
end
|
|
end
|
|
|
|
context 'when user is not owner' do
|
|
before do
|
|
group.add_maintainer(user)
|
|
end
|
|
|
|
it 'renders a 404' do
|
|
get :show, params: { group_id: group }
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
context 'external authorization' do
|
|
before do
|
|
enable_external_authorization_service_check
|
|
group.add_owner(user)
|
|
end
|
|
|
|
it 'renders show with 200 status code' do
|
|
get :show, params: { group_id: group }
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PUT #reset_registration_token' do
|
|
subject { put :reset_registration_token, params: { group_id: group } }
|
|
|
|
context 'when user is owner' do
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
it 'resets runner registration token' do
|
|
expect { subject }.to change { group.reload.runners_token }
|
|
end
|
|
|
|
it 'redirects the user to admin runners page' do
|
|
subject
|
|
|
|
expect(response).to redirect_to(group_settings_ci_cd_path)
|
|
end
|
|
end
|
|
|
|
context 'when user is not owner' do
|
|
before do
|
|
group.add_maintainer(user)
|
|
end
|
|
|
|
it 'renders a 404' do
|
|
subject
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PATCH #update_auto_devops' do
|
|
let(:auto_devops_param) { '1' }
|
|
|
|
subject do
|
|
patch :update_auto_devops, params: {
|
|
group_id: group,
|
|
group: { auto_devops_enabled: auto_devops_param }
|
|
}
|
|
end
|
|
|
|
context 'when user does not have enough permission' do
|
|
before do
|
|
group.add_maintainer(user)
|
|
end
|
|
|
|
it { is_expected.to have_gitlab_http_status(:not_found) }
|
|
end
|
|
|
|
context 'when user has enough privileges' do
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
it { is_expected.to redirect_to(group_settings_ci_cd_path) }
|
|
|
|
context 'when service execution went wrong' do
|
|
before do
|
|
allow_any_instance_of(Groups::AutoDevopsService).to receive(:execute).and_return(false)
|
|
allow_any_instance_of(Group).to receive_message_chain(:errors, :full_messages)
|
|
.and_return(['Error 1'])
|
|
|
|
subject
|
|
end
|
|
|
|
it 'returns a flash alert' do
|
|
expect(response).to set_flash[:alert]
|
|
.to eq("There was a problem updating Auto DevOps pipeline: [\"Error 1\"].")
|
|
end
|
|
end
|
|
|
|
context 'when service execution was successful' do
|
|
it 'returns a flash notice' do
|
|
subject
|
|
|
|
expect(response).to set_flash[:notice]
|
|
.to eq('Auto DevOps pipeline was updated for the group')
|
|
end
|
|
end
|
|
|
|
context 'when changing auto devops value' do
|
|
before do
|
|
subject
|
|
|
|
group.reload
|
|
end
|
|
|
|
context 'when explicitly enabling auto devops' do
|
|
it 'updates group attribute' do
|
|
expect(group.auto_devops_enabled).to eq(true)
|
|
end
|
|
end
|
|
|
|
context 'when explicitly disabling auto devops' do
|
|
let(:auto_devops_param) { '0' }
|
|
|
|
it 'updates group attribute' do
|
|
expect(group.auto_devops_enabled).to eq(false)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PATCH #update' do
|
|
subject do
|
|
patch :update, params: {
|
|
group_id: group,
|
|
group: { max_artifacts_size: 10 }
|
|
}
|
|
end
|
|
|
|
context 'when user is not an admin' do
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
it { is_expected.to have_gitlab_http_status(:not_found) }
|
|
end
|
|
|
|
context 'when user is an admin' do
|
|
let(:user) { create(:admin) }
|
|
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it { is_expected.to have_gitlab_http_status(:not_found) }
|
|
end
|
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it { is_expected.to redirect_to(group_settings_ci_cd_path) }
|
|
|
|
context 'when service execution went wrong' do
|
|
let(:update_service) { double }
|
|
|
|
before do
|
|
allow(Groups::UpdateService).to receive(:new).and_return(update_service)
|
|
allow(update_service).to receive(:execute).and_return(false)
|
|
allow_any_instance_of(Group).to receive_message_chain(:errors, :full_messages)
|
|
.and_return(['Error 1'])
|
|
|
|
subject
|
|
end
|
|
|
|
it 'returns a flash alert' do
|
|
expect(response).to set_flash[:alert]
|
|
.to eq("There was a problem updating the pipeline settings: [\"Error 1\"].")
|
|
end
|
|
end
|
|
|
|
context 'when service execution was successful' do
|
|
it 'returns a flash notice' do
|
|
subject
|
|
|
|
expect(response).to set_flash[:notice]
|
|
.to eq('Pipeline settings was updated for the group')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST create_deploy_token' do
|
|
context 'when ajax_new_deploy_token feature flag is disabled for the project' do
|
|
before do
|
|
stub_feature_flags(ajax_new_deploy_token: { enabled: false, thing: group })
|
|
entity.add_owner(user)
|
|
end
|
|
|
|
it_behaves_like 'a created deploy token' do
|
|
let(:entity) { group }
|
|
let(:create_entity_params) { { group_id: group } }
|
|
let(:deploy_token_type) { DeployToken.deploy_token_types[:group_type] }
|
|
end
|
|
end
|
|
|
|
context 'when ajax_new_deploy_token feature flag is enabled for the project' do
|
|
let(:good_deploy_token_params) do
|
|
{
|
|
name: 'name',
|
|
expires_at: 1.day.from_now.to_s,
|
|
username: 'deployer',
|
|
read_repository: '1',
|
|
deploy_token_type: DeployToken.deploy_token_types[:group_type]
|
|
}
|
|
end
|
|
let(:request_params) do
|
|
{
|
|
group_id: group.to_param,
|
|
deploy_token: deploy_token_params
|
|
}
|
|
end
|
|
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
subject { post :create_deploy_token, params: request_params, format: :json }
|
|
|
|
context('a good request') do
|
|
let(:deploy_token_params) { good_deploy_token_params }
|
|
let(:expected_response) do
|
|
{
|
|
'id' => be_a(Integer),
|
|
'name' => deploy_token_params[:name],
|
|
'username' => deploy_token_params[:username],
|
|
'expires_at' => Time.parse(deploy_token_params[:expires_at]),
|
|
'token' => be_a(String),
|
|
'scopes' => deploy_token_params.inject([]) do |scopes, kv|
|
|
key, value = kv
|
|
key.to_s.start_with?('read_') && !value.to_i.zero? ? scopes << key.to_s : scopes
|
|
end
|
|
}
|
|
end
|
|
|
|
it 'creates the deploy token' do
|
|
subject
|
|
|
|
expect(response).to have_gitlab_http_status(:created)
|
|
expect(response).to match_response_schema('public_api/v4/deploy_token')
|
|
expect(json_response).to match(expected_response)
|
|
end
|
|
end
|
|
|
|
context('a bad request') do
|
|
let(:deploy_token_params) { good_deploy_token_params.except(:read_repository) }
|
|
let(:expected_response) { { 'message' => "Scopes can't be blank" } }
|
|
|
|
it 'does not create the deploy token' do
|
|
subject
|
|
|
|
expect(response).to have_gitlab_http_status(:bad_request)
|
|
expect(json_response).to match(expected_response)
|
|
end
|
|
end
|
|
|
|
context('an invalid request') do
|
|
let(:deploy_token_params) { good_deploy_token_params.except(:name) }
|
|
|
|
it 'raises a validation error' do
|
|
expect { subject }.to raise_error(ActiveRecord::StatementInvalid)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|