79 lines
2.2 KiB
Ruby
79 lines
2.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe SearchController do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
it 'finds issue comments' do
|
|
project = create(:project, :public)
|
|
note = create(:note_on_issue, project: project)
|
|
|
|
get :show, project_id: project.id, scope: 'notes', search: note.note
|
|
|
|
expect(assigns[:search_objects].first).to eq note
|
|
end
|
|
|
|
context 'when the user cannot read cross project' do
|
|
before do
|
|
allow(Ability).to receive(:allowed?).and_call_original
|
|
allow(Ability).to receive(:allowed?)
|
|
.with(user, :read_cross_project, :global) { false }
|
|
end
|
|
|
|
it 'still allows accessing the search page' do
|
|
get :show
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
|
|
it 'still blocks searches without a project_id' do
|
|
get :show, search: 'hello'
|
|
|
|
expect(response).to have_gitlab_http_status(403)
|
|
end
|
|
|
|
it 'allows searches with a project_id' do
|
|
get :show, search: 'hello', project_id: create(:project, :public).id
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
end
|
|
|
|
context 'on restricted projects' do
|
|
context 'when signed out' do
|
|
before do
|
|
sign_out(user)
|
|
end
|
|
|
|
it "doesn't expose comments on issues" do
|
|
project = create(:project, :public, :issues_private)
|
|
note = create(:note_on_issue, project: project)
|
|
|
|
get :show, project_id: project.id, scope: 'notes', search: note.note
|
|
|
|
expect(assigns[:search_objects].count).to eq(0)
|
|
end
|
|
end
|
|
|
|
it "doesn't expose comments on merge_requests" do
|
|
project = create(:project, :public, :merge_requests_private)
|
|
note = create(:note_on_merge_request, project: project)
|
|
|
|
get :show, project_id: project.id, scope: 'notes', search: note.note
|
|
|
|
expect(assigns[:search_objects].count).to eq(0)
|
|
end
|
|
|
|
it "doesn't expose comments on snippets" do
|
|
project = create(:project, :public, :snippets_private)
|
|
note = create(:note_on_project_snippet, project: project)
|
|
|
|
get :show, project_id: project.id, scope: 'notes', search: note.note
|
|
|
|
expect(assigns[:search_objects].count).to eq(0)
|
|
end
|
|
end
|
|
end
|