173 lines
5.1 KiB
Ruby
173 lines
5.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'gitlab-dangerfiles'
|
|
require 'gitlab/dangerfiles/spec_helper'
|
|
require 'rspec-parameterized'
|
|
require 'httparty'
|
|
|
|
require_relative '../../../tooling/danger/stable_branch'
|
|
|
|
RSpec.describe Tooling::Danger::StableBranch, feature_category: :delivery do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
include_context 'with dangerfile'
|
|
let(:fake_danger) { DangerSpecHelper.fake_danger.include(described_class) }
|
|
|
|
let(:stable_branch) { fake_danger.new(helper: fake_helper) }
|
|
|
|
describe '#check!' do
|
|
subject { stable_branch.check! }
|
|
|
|
shared_examples 'without a failure' do
|
|
it 'does not add a failure' do
|
|
expect(stable_branch).not_to receive(:fail)
|
|
|
|
subject
|
|
end
|
|
end
|
|
|
|
shared_examples 'with a failure' do |failure_message|
|
|
it 'fails' do
|
|
expect(stable_branch).to receive(:fail).with(failure_message)
|
|
|
|
subject
|
|
end
|
|
end
|
|
|
|
shared_examples 'with a warning' do |failure_message|
|
|
it 'fails' do
|
|
expect(stable_branch).to receive(:warn).with(failure_message)
|
|
|
|
subject
|
|
end
|
|
end
|
|
|
|
context 'when not applicable' do
|
|
where(:stable_branch?, :security_mr?) do
|
|
true | true
|
|
false | true
|
|
false | false
|
|
end
|
|
|
|
with_them do
|
|
before do
|
|
allow(fake_helper).to receive(:mr_target_branch).and_return(stable_branch? ? '15-1-stable-ee' : 'main')
|
|
allow(fake_helper).to receive(:security_mr?).and_return(security_mr?)
|
|
end
|
|
|
|
it_behaves_like "without a failure"
|
|
end
|
|
end
|
|
|
|
context 'when applicable' do
|
|
let(:target_branch) { '15-1-stable-ee' }
|
|
let(:feature_label_present) { false }
|
|
let(:bug_label_present) { true }
|
|
let(:response_success) { true }
|
|
let(:parsed_response) do
|
|
[
|
|
{ 'version' => '15.1.1' },
|
|
{ 'version' => '15.1.0' },
|
|
{ 'version' => '15.0.2' },
|
|
{ 'version' => '15.0.1' },
|
|
{ 'version' => '15.0.0' },
|
|
{ 'version' => '14.10.3' },
|
|
{ 'version' => '14.10.2' },
|
|
{ 'version' => '14.9.3' }
|
|
]
|
|
end
|
|
|
|
let(:version_response) do
|
|
instance_double(
|
|
HTTParty::Response,
|
|
success?: response_success,
|
|
parsed_response: parsed_response
|
|
)
|
|
end
|
|
|
|
before do
|
|
allow(fake_helper).to receive(:mr_target_branch).and_return(target_branch)
|
|
allow(fake_helper).to receive(:security_mr?).and_return(false)
|
|
allow(fake_helper).to receive(:mr_has_labels?).with('type::feature').and_return(feature_label_present)
|
|
allow(fake_helper).to receive(:mr_has_labels?).with('type::bug').and_return(bug_label_present)
|
|
allow(HTTParty).to receive(:get).with(/page=1/).and_return(version_response)
|
|
end
|
|
|
|
# the stubbed behavior above is the success path
|
|
it_behaves_like "without a failure"
|
|
|
|
context 'with a feature label' do
|
|
let(:feature_label_present) { true }
|
|
|
|
it_behaves_like 'with a failure', described_class::FEATURE_ERROR_MESSAGE
|
|
end
|
|
|
|
context 'without a bug label' do
|
|
let(:bug_label_present) { false }
|
|
|
|
it_behaves_like 'with a failure', described_class::BUG_ERROR_MESSAGE
|
|
end
|
|
|
|
context 'when not an applicable version' do
|
|
let(:target_branch) { '14-9-stable-ee' }
|
|
|
|
it_behaves_like 'with a warning', described_class::VERSION_WARNING_MESSAGE
|
|
end
|
|
|
|
context 'when the version API request fails' do
|
|
let(:response_success) { false }
|
|
|
|
it_behaves_like 'with a warning', described_class::FAILED_VERSION_REQUEST_MESSAGE
|
|
end
|
|
|
|
context 'when more than one page of versions is needed' do
|
|
# we target a version we know will not be returned in the first request
|
|
let(:target_branch) { '14-10-stable-ee' }
|
|
|
|
let(:first_version_response) do
|
|
instance_double(
|
|
HTTParty::Response,
|
|
success?: response_success,
|
|
parsed_response: [
|
|
{ 'version' => '15.1.1' },
|
|
{ 'version' => '15.1.0' },
|
|
{ 'version' => '15.0.2' },
|
|
{ 'version' => '15.0.1' }
|
|
]
|
|
)
|
|
end
|
|
|
|
let(:second_version_response) do
|
|
instance_double(
|
|
HTTParty::Response,
|
|
success?: response_success,
|
|
parsed_response: [
|
|
{ 'version' => '15.0.0' },
|
|
{ 'version' => '14.10.3' },
|
|
{ 'version' => '14.10.2' },
|
|
{ 'version' => '14.9.3' }
|
|
]
|
|
)
|
|
end
|
|
|
|
before do
|
|
allow(HTTParty).to receive(:get).with(/page=1/).and_return(first_version_response)
|
|
allow(HTTParty).to receive(:get).with(/page=2/).and_return(second_version_response)
|
|
end
|
|
|
|
it_behaves_like "without a failure"
|
|
end
|
|
|
|
context 'when too many version API requests are made' do
|
|
let(:parsed_response) { [{ 'version' => '15.0.0' }] }
|
|
|
|
it 'adds a warning' do
|
|
expect(HTTParty).to receive(:get).and_return(version_response).at_least(10).times
|
|
expect(stable_branch).to receive(:warn).with(described_class::FAILED_VERSION_REQUEST_MESSAGE)
|
|
|
|
subject
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|