92 lines
3 KiB
Ruby
92 lines
3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe ProtectedBranches::CreateService do
|
|
let(:project) { create(:project) }
|
|
let(:user) { project.owner }
|
|
let(:params) do
|
|
{
|
|
name: name,
|
|
merge_access_levels_attributes: [{ access_level: Gitlab::Access::MAINTAINER }],
|
|
push_access_levels_attributes: [{ access_level: Gitlab::Access::MAINTAINER }]
|
|
}
|
|
end
|
|
|
|
describe '#execute' do
|
|
let(:name) { 'master' }
|
|
|
|
subject(:service) { described_class.new(project, user, params) }
|
|
|
|
it 'creates a new protected branch' do
|
|
expect { service.execute }.to change(ProtectedBranch, :count).by(1)
|
|
expect(project.protected_branches.last.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::MAINTAINER])
|
|
expect(project.protected_branches.last.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::MAINTAINER])
|
|
end
|
|
|
|
context 'when name has escaped HTML' do
|
|
let(:name) { 'feature->test' }
|
|
|
|
it 'creates the new protected branch matching the unescaped version' do
|
|
expect { service.execute }.to change(ProtectedBranch, :count).by(1)
|
|
expect(project.protected_branches.last.name).to eq('feature->test')
|
|
end
|
|
|
|
context 'and name contains HTML tags' do
|
|
let(:name) { '<b>master</b>' }
|
|
|
|
it 'creates the new protected branch with sanitized name' do
|
|
expect { service.execute }.to change(ProtectedBranch, :count).by(1)
|
|
expect(project.protected_branches.last.name).to eq('master')
|
|
end
|
|
|
|
context 'and contains unsafe HTML' do
|
|
let(:name) { '<script>alert('foo');</script>' }
|
|
|
|
it 'does not create the new protected branch' do
|
|
expect { service.execute }.not_to change(ProtectedBranch, :count)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when name contains unescaped HTML tags' do
|
|
let(:name) { '<b>master</b>' }
|
|
|
|
it 'creates the new protected branch with sanitized name' do
|
|
expect { service.execute }.to change(ProtectedBranch, :count).by(1)
|
|
expect(project.protected_branches.last.name).to eq('master')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when user does not have permission' do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
project.add_developer(user)
|
|
end
|
|
|
|
it 'creates a new protected branch if we skip authorization step' do
|
|
expect { service.execute(skip_authorization: true) }.to change(ProtectedBranch, :count).by(1)
|
|
end
|
|
|
|
it 'raises Gitlab::Access:AccessDeniedError' do
|
|
expect { service.execute }.to raise_error(Gitlab::Access::AccessDeniedError)
|
|
end
|
|
end
|
|
|
|
context 'when a policy restricts rule creation' do
|
|
before do
|
|
policy = instance_double(ProtectedBranchPolicy, allowed?: false)
|
|
expect(ProtectedBranchPolicy).to receive(:new).and_return(policy)
|
|
end
|
|
|
|
it "prevents creation of the protected branch rule" do
|
|
expect do
|
|
service.execute
|
|
end.to raise_error(Gitlab::Access::AccessDeniedError)
|
|
end
|
|
end
|
|
end
|
|
end
|